staging: sm750fb: fix a type issue in sm750_set_chip_type()

PATCH New Dan Carpenter 1 participant 1 message Nov 26, 2016

Subsystems (4)

Staging Kernel janitors Framebuffer layer Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Dan Carpenter

author

2016-11-26 10:20 UTC #0 lore raw

PATCH 1/1 staging: sm750fb: fix a type issue in sm750_set_chip_type()

"revId" needs to be unsigned because we use it to test:

	if (revId = SM750LE_REVISION_ID) {

and SM750LE_REVISION_ID is ((unsigned char )0xfe).

Fixes 81dee67e215b ("staging: sm750fb: add sm750 to staging")

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/sm750fb/ddk750_chip.h +1 -1

index e97e859..e63b8b2 100644
@@ -87,7 +87,7 @@ struct initchip_param {
 };
 
 logical_chip_type_t sm750_get_chip_type(void);
-void sm750_set_chip_type(unsigned short devId, char revId);
+void sm750_set_chip_type(unsigned short devId, u8 revId);
 unsigned int sm750_calc_pll_value(unsigned int request, struct  pll_value *pll);
 unsigned int sm750_format_pll_reg(struct pll_value *pPLL);
 unsigned int ddk750_get_vm_size(void);

drivers/staging/sm750fb/ddk750_chip.c +1 -1

index 94f59f4..f59ce5c 100644
@@ -14,7 +14,7 @@ logical_chip_type_t sm750_get_chip_type(void)
 	return chip;
 }
 
-void sm750_set_chip_type(unsigned short devId, char revId)
+void sm750_set_chip_type(unsigned short devId, u8 revId)
 {
 	if (devId = 0x718)
 		chip = SM718;