Skip to contentSkip to conversation

m68k: add special gcc flag to avoid ICE for coldfire

PATCH New Waldemar Brodkorb 3 participants 9 messages Nov 26, 2016 – Mar 10, 2017

lore
Share & tools
lore

Waldemar Brodkorb

author
#0 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Signed-off-by Arnout Vandecappelle <[email protected]>
Tested-by Waldemar Brodkorb <[email protected]>
Signed-off-by Waldemar Brodkorb <[email protected]>
---
 toolchain/toolchain-wrapper.mk | 7 +++++++
 1 file changed, 7 insertions(+)
toolchain/toolchain-wrapper.mk +7 -0
index c7b5019..463ba42 100644
@@ -9,6 +9,13 @@ else
 TOOLCHAIN_WRAPPER_HASH_STYLE = both
 endif
 
+TARGET_FLAGS += $(call qstrip,$(BR2_TARGET_OPTIMIZATION))
+
+# Internal error, aborting at dw2gencfi.c:214 in emit_expr_encoded
+ifeq ($(BR2_m68k_cf),y)
+TARGET_FLAGS += -fno-dwarf2-cfi-asm
+endif
+
 TOOLCHAIN_WRAPPER_ARGS = $($(PKG)_TOOLCHAIN_WRAPPER_ARGS)
 TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"'
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Quoted 3 lines · Waldemar Brodkorb

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Did you test whether exception handling still works?

Quoted 5 lines

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Signed-off-by Arnout Vandecappelle <[email protected]>

Not sure if this warrants a Sob from me, but OK.

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 25 lines
Tested-by Waldemar Brodkorb <[email protected]>
Signed-off-by Waldemar Brodkorb <[email protected]>
---
 toolchain/toolchain-wrapper.mk | 7 +++++++
 1 file changed, 7 insertions(+)
toolchain/toolchain-wrapper.mk +7 -0
index c7b5019..463ba42 100644
@@ -9,6 +9,13 @@ else
 TOOLCHAIN_WRAPPER_HASH_STYLE = both
 endif
 
+TARGET_FLAGS += $(call qstrip,$(BR2_TARGET_OPTIMIZATION))
+
+# Internal error, aborting at dw2gencfi.c:214 in emit_expr_encoded
+ifeq ($(BR2_m68k_cf),y)
+TARGET_FLAGS += -fno-dwarf2-cfi-asm
+endif
+
 TOOLCHAIN_WRAPPER_ARGS = $($(PKG)_TOOLCHAIN_WRAPPER_ARGS)
 TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"'
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#2 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Hi Arnout,
Arnout Vandecappelle wrote,

Quoted 6 lines · Waldemar Brodkorb
Quoted 3 lines

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Did you test whether exception handling still works?

Tested with attached C++ app.
Before and after the patches.

Quoted 8 lines
Quoted 4 lines

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Signed-off-by Arnout Vandecappelle <[email protected]>

Not sure if this warrants a Sob from me, but OK.

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Will you provide the bigger patch Thomas wants to have?

best regards
Waldemar
-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.cc
Type: text/x-c++src
Size: 2835 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20161127/64501825/attachment.cc>

#3 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

In reply to Waldemar Brodkorb

Hello,

Quoted 6 lines · Waldemar Brodkorb

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Hum, thanks but this patch you're pointing to is really material for next at this point, so I cannot apply your patch, which should be applied on master in order to fix the autobuilder issues.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Quoted 7 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Waldemar Brodkorb

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Quoted 6 lines
Quoted 2 lines

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Hum, thanks but this patch you're pointing to is really material for next at this point, so I cannot apply your patch, which should be applied on master in order to fix the autobuilder issues.

Begging to differ: doing the same without patch 683830 would be a much bigger
patch (adding yet another -D option to the wrapper, updating the wrapper itself). But OK, it's getting a bit later to still take _any_ risk, so probably the bigger patch is better.

Regards,
Arnout

Quoted 5 lines

Thanks,

Thomas

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#5 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Hello,

Quoted 8 lines · Arnout Vandecappelle
Quoted 3 lines

Hum, thanks but this patch you're pointing to is really material for next at this point, so I cannot apply your patch, which should be applied on master in order to fix the autobuilder issues.

Begging to differ: doing the same without patch 683830 would be a much bigger
patch (adding yet another -D option to the wrapper, updating the wrapper itself). But OK, it's getting a bit later to still take _any_ risk, so probably the bigger patch is better.

That's my point: that late in the cycle, I don't want to touch too many things around the toolchain wrapper. So adding one more CFLAGS or LDFLAGS specific to m68k is OK (worst thing is a regression on m68k, which probably isn't very widely used). But a change that touches the toolchain wrapper, and can potentially break major architectures, I'm not a big fan.

If nobody provides the bigger patch, I think I'm going to live with the m68k autobuilder failures until the release, and merge afterwards.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

In reply to Arnout Vandecappelle

Hello,

Quoted 4 lines · Arnout Vandecappelle

Begging to differ: doing the same without patch 683830 would be a much bigger
patch (adding yet another -D option to the wrapper, updating the wrapper itself). But OK, it's getting a bit later to still take _any_ risk, so probably the bigger patch is better.

Have you had the chance to work on your toolchain wrapper patches, at least enough to be able to merge this m68k change?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#7 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Arnout Vandecappelle

Begging to differ: doing the same without patch 683830 would be a much bigger
patch (adding yet another -D option to the wrapper, updating the wrapper itself). But OK, it's getting a bit later to still take _any_ risk, so probably the bigger patch is better.

Have you had the chance to work on your toolchain wrapper patches, at least enough to be able to merge this m68k change?

Not yet, and it doesn't look like I'll have much time this year...

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#8 lore raw

PATCH 1/1 m68k: add special gcc flag to avoid ICE for coldfire

In reply to Waldemar Brodkorb

Hello,

Quoted 10 lines · Waldemar Brodkorb

Fixes:
http://autobuild.buildroot.net/results/d47fa41aa860d82471b83ac90967d3a3dacd8611
http://autobuild.buildroot.net/results/a21de4747f40a5ce93108c8979fbc0277d040e79

Requires this as prerequisite:
http://patchwork.ozlabs.org/patch/683830/

Signed-off-by Arnout Vandecappelle <[email protected]>
Tested-by Waldemar Brodkorb <[email protected]>
Signed-off-by Waldemar Brodkorb <[email protected]>

We've added -fno-dwarf2-cfi-asm to 4 packages so far, and it seems to have fixed the problem. So I would for now prefer to keep this as it is today, and not use the wrapper to pass this flag to all packages.

I'll mark your patch as Rejected in patchwork, since it anyway cannot be applied because Arnout patches have not been merged.

Let me know if you disagree, of course.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com