Skip to contentSkip to conversation

x86/intel_mid_thermal: Fix suspend handlers unused warning

PATCH In review Borislav Petkov 2 participants 2 messages Nov 26, 2016 – Dec 3, 2016 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/intel_mid_thermal: Fix suspend handlers unused warning

From: Borislav Petkov <[email protected]>

Fix:

drivers/platform/x86/intel_mid_thermal.c:424:12: warning: ‘mid_thermal_resume’ defined but not used [-Wunused-function]
static int mid_thermal_resume(struct device *dev)

              ^
  drivers/platform/x86/intel_mid_thermal.c:436:12: warning: ‘mid_thermal_suspend’
  defined but not used [-Wunused-function]
   static int mid_thermal_suspend(struct device *dev)
              ^

which I see during randbuilds here.

---
 drivers/platform/x86/intel_mid_thermal.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/platform/x86/intel_mid_thermal.c +2 -0
index 9f713b832ba3..0df3c9d37509 100644
@@ -415,6 +415,7 @@ static struct thermal_device_info *initialize_sensor(int index)
 	return td_info;
 }
 
+#ifdef CONFIG_PM_SLEEP
 /**
  * mid_thermal_resume - resume routine
  * @dev: device structure
@@ -442,6 +443,7 @@ static int mid_thermal_suspend(struct device *dev)
 	 */
 	return configure_adc(0);
 }
+#endif
 
 static SIMPLE_DEV_PM_OPS(mid_thermal_pm,
 			 mid_thermal_suspend, mid_thermal_resume);
Signature · 1 line
2.10.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

Fix:

drivers/platform/x86/intel_mid_thermal.c:424:12: warning: ‘mid_thermal_resume’ defined but not used [-Wunused-function]
static int mid_thermal_resume(struct device *dev)

Quoted 7 lines
              ^
  drivers/platform/x86/intel_mid_thermal.c:436:12: warning: ‘mid_thermal_suspend’
  defined but not used [-Wunused-function]
   static int mid_thermal_suspend(struct device *dev)
              ^

which I see during randbuilds here.

Thanks!

Quoted 35 lines
---
 drivers/platform/x86/intel_mid_thermal.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/platform/x86/intel_mid_thermal.c +2 -1
index 9f713b832ba3..0df3c9d37509 100644
@@ -415,6 +415,7 @@ static struct thermal_device_info *initialize_sensor(int index)
        return td_info;
 }
 
+#ifdef CONFIG_PM_SLEEP
 /**
  * mid_thermal_resume - resume routine
  * @dev: device structure
@@ -442,6 +443,7 @@ static int mid_thermal_suspend(struct device *dev)
         */
        return configure_adc(0);
 }
+#endif
 
 static SIMPLE_DEV_PM_OPS(mid_thermal_pm,
                         mid_thermal_suspend, mid_thermal_resume);
--

2.10.0

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
With Best Regards,
Andy Shevchenko