Skip to contentSkip to conversation

drivers/pci/host/vmd: Fix suspend handlers unused warning

PATCH In review Borislav Petkov 3 participants 3 messages Nov 26, 2016 – Dec 7, 2016 PCI

lore
Share & tools
lore

Borislav Petkov

author
#0 lore raw

PATCH 1/1 drivers/pci/host/vmd: Fix suspend handlers unused warning

From: Borislav Petkov <[email protected]>

Fix:

drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
static int vmd_suspend(struct device *dev)

              ^
  drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
   static int vmd_resume(struct device *dev)
              ^
Signed-off-by Borislav Petkov <[email protected]>
Cc Keith Busch <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc [email protected]
---
 drivers/pci/host/vmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/vmd.c +1 -1
index 37e29b580be3..0e7f8f319fe3 100644
@@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
 	irq_domain_remove(vmd->irq_domain);
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int vmd_suspend(struct device *dev)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
Signature · 1 line
2.10.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

Fix:

Quoted 8 lines

drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
static int vmd_suspend(struct device *dev)

              ^
  drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
   static int vmd_resume(struct device *dev)
              ^
Signed-off-by Borislav Petkov <[email protected]>

Thanks for the fix.

Reviewed-by Keith Busch <[email protected]>
#2 lore raw
In reply to Borislav Petkov
Quoted 11 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

Fix:

drivers/pci/host/vmd.c:731:12: warning: ‘vmd_suspend’ defined but not used [-Wunused-function]
static int vmd_suspend(struct device *dev)

              ^
  drivers/pci/host/vmd.c:739:12: warning: ‘vmd_resume’ defined but not used [-Wunused-function]
   static int vmd_resume(struct device *dev)
              ^
Quoted 4 lines
Signed-off-by Borislav Petkov <[email protected]>
Cc Keith Busch <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Cc [email protected]

Applied with Keith's reviewed-by to pci/host-vmd for v4.10, thanks!

Quoted 24 lines
---
 drivers/pci/host/vmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/host/vmd.c +1 -1
index 37e29b580be3..0e7f8f319fe3 100644
@@ -727,7 +727,7 @@ static void vmd_remove(struct pci_dev *dev)
 	irq_domain_remove(vmd->irq_domain);
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 static int vmd_suspend(struct device *dev)
 {
 	struct pci_dev *pdev = to_pci_dev(dev);
Signature · 6 lines
2.10.0

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html