Skip to contentSkip to conversation

swupd-client: fix invalid directory in do_install_append()

PATCH In review André Draszik 2 participants 2 messages Nov 28, 2016 – Nov 30, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 swupd-client: fix invalid directory in do_install_append()

From: André Draszik <[email protected]>

---
 recipes-core/swupd-client/swupd-client_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
recipes-core/swupd-client/swupd-client_git.bb +1 -1
index fd4716f..3aed480 100644
@@ -38,7 +38,7 @@ SWUPD_FORMAT ??= "3"
 SWUPD_PINNED_PUBKEY ??= ""
 do_install_append () {
     # TODO: This should be a less os-specific directory and not hard-code datadir
-    install -d ${D}$/usr/share/clear/bundles
+    install -d ${D}/usr/share/clear/bundles
 
     # Write default values to the configuration hierarchy (since 3.4.0)
     install -d ${D}/usr/share/defaults/swupd
Signature · 1 line
2.10.2
#1 lore raw

recipes-core/swupd-client/swupd-client_git.bb SWUPD_FORMAT ??= "3" · line 44

Quoted 13 lines · André Draszik
recipes-core/swupd-client/swupd-client_git.bb +1 -1
index fd4716f..3aed480 100644
@@ -38,7 +38,7 @@ SWUPD_FORMAT ??= "3"
 SWUPD_PINNED_PUBKEY ??= ""
 do_install_append () {
     # TODO: This should be a less os-specific directory and not hard-code datadir
-    install -d ${D}$/usr/share/clear/bundles
+    install -d ${D}/usr/share/clear/bundles
 
     # Write default values to the configuration hierarchy (since 3.4.0)
     install -d ${D}/usr/share/defaults/swupd

I'm about to remove this entire do_install_append. create_bundle_manifest() in swupd-image.bbclass is what really creates that directory, and onfiguring the image so that the swupd-client is usable is part of image creation, not of compiling the client.

For example, different images may need different settings, and that can't be done with settings compiled into swupd-client because it gets built only once.

Signature · 6 lines
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.