media: ti-vpe: vpdma: fix a timeout loop
Subsystems (2)
PATCH 1/1 media: ti-vpe: vpdma: fix a timeout loop
The check assumes that we end on zero but actually we end on -1. Change the post-op to a pre-op so that we do end on zero. Techinically now we only loop 499 times instead of 500 but that's fine.
Fixes dc12b124353b ("[media] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs")
Signed-off-by Dan Carpenter <[email protected]>
drivers/media/platform/ti-vpe/vpdma.c +1 -1
@@ -453,7 +453,7 @@ int vpdma_list_cleanup(struct vpdma_data *vpdma, int list_num,if (ret)return ret; -while (vpdma_list_busy (vpdma, list_num) && timeout--) +while (vpdma_list_busy (vpdma, list_num) && --timeout) ;if (timeout =0 ) {
Dan,
Thanks for the patch.
Acked-by Benoit Parrot <[email protected]>
Dan Carpenter <[email protected]> wrote on Sat [2016-Nov-26 00:28:34 +0300]:
Quoted 20 lines
The check assumes that we end on zero but actually we end on -1. Change the post-op to a pre-op so that we do end on zero. Techinically now we only loop 499 times instead of 500 but that's fine.
Fixes dc12b124353b ("[media] media: ti-vpe: vpdma: Add abort channel desc and cleanup APIs")Signed-off-by Dan Carpenter <[email protected]>drivers/media/platform/ti-vpe/vpdma.c +1
-1@@ -453,7 +453,7 @@ int vpdma_list_cleanup(struct vpdma_data *vpdma, int list_num,if (ret)return ret; -while (vpdma_list_busy (vpdma, list_num) && timeout--) +while (vpdma_list_busy (vpdma, list_num) && --timeout) ;if (timeout =0 ) {