Skip to contentSkip to conversation

readline: bump version to 7.0

PATCH New Vicente Olivert Riera 3 participants 9 messages Nov 29, 2016 – Nov 30, 2016

lore
Share & tools
lore

Vicente Olivert Riera

author
#0 lore raw

PATCH 1/2 readline: bump version to 7.0

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/readline/0001-patchlevel-1.patch | 47 ----------------------
 package/readline/0002-patchlevel-2.patch | 48 -----------------------
 package/readline/0003-patchlevel-3.patch | 51 ------------------------
 package/readline/0004-patchlevel-4.patch | 49 -----------------------
 package/readline/0005-patchlevel-5.patch | 62 -----------------------------
 package/readline/0006-patchlevel-6.patch | 67 --------------------------------
 package/readline/0007-patchlevel-7.patch | 51 ------------------------
 package/readline/0008-patchlevel-8.patch | 51 ------------------------
 package/readline/readline.hash           |  2 +-
 package/readline/readline.mk             |  2 +-
 10 files changed, 2 insertions(+), 428 deletions(-)
 delete mode 100644 package/readline/0001-patchlevel-1.patch
 delete mode 100644 package/readline/0002-patchlevel-2.patch
 delete mode 100644 package/readline/0003-patchlevel-3.patch
 delete mode 100644 package/readline/0004-patchlevel-4.patch
 delete mode 100644 package/readline/0005-patchlevel-5.patch
 delete mode 100644 package/readline/0006-patchlevel-6.patch
 delete mode 100644 package/readline/0007-patchlevel-7.patch
 delete mode 100644 package/readline/0008-patchlevel-8.patch
package/readline/0001-patchlevel-1.patch deleted +0 -47
deleted file mode 100644
index 8593073..0000000
@@ -1,47 +0,0 @@
-From http://ftp.gnu.org/pub/gnu/readline/readline-6.3-patches/readline63-001
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-			   READLINE PATCH REPORT
-			   =====================
-
-Readline-Release: 6.3
-Patch-ID: readline63-001
-
-Bug-Reported-by:	Daan van Rossum <[email protected]>
-Bug-Reference-ID:	<[email protected]>
-Bug-Reference-URL:	
-
-Bug-Description:
-
-The `.' command in vi mode cannot undo multi-key commands beginning with
-`c', `d', and `y' (command plus motion specifier).
-
-Patch (apply with `patch -p0'):
-
-*** a/readline-6.3/readline.c	2013-10-28 14:58:06.000000000 -0400
---- b/readline.c	2014-03-07 15:20:33.000000000 -0500
-***************
-*** 965,969 ****
-    if (rl_editing_mode == vi_mode && _rl_keymap == vi_movement_keymap &&
-        key != ANYOTHERKEY &&
-!       rl_key_sequence_length == 1 &&	/* XXX */
-        _rl_vi_textmod_command (key))
-      _rl_vi_set_last (key, rl_numeric_arg, rl_arg_sign);
---- 965,969 ----
-    if (rl_editing_mode == vi_mode && _rl_keymap == vi_movement_keymap &&
-        key != ANYOTHERKEY &&
-!       _rl_dispatching_keymap == vi_movement_keymap &&
-        _rl_vi_textmod_command (key))
-      _rl_vi_set_last (key, rl_numeric_arg, rl_arg_sign);
-*** a/readline-6.3/patchlevel	2013-11-15 08:11:11.000000000 -0500
---- b/patchlevel	2014-03-21 08:28:40.000000000 -0400
-***************
-*** 1,3 ****
-  # Do not edit -- exists only for use by patch
-  
-! 5
---- 1,3 ----
-  # Do not edit -- exists only for use by patch
-  
-! 1
package/readline/0002-patchlevel-2.patch deleted +0 -48

48 lines not on this page · raw message

package/readline/0003-patchlevel-3.patch deleted +0 -51

51 lines not on this page · raw message

package/readline/0004-patchlevel-4.patch deleted +0 -49

49 lines not on this page · raw message

package/readline/0005-patchlevel-5.patch deleted +0 -62

62 lines not on this page · raw message

package/readline/0006-patchlevel-6.patch deleted +0 -67

67 lines not on this page · raw message

package/readline/0007-patchlevel-7.patch deleted +0 -51

51 lines not on this page · raw message

package/readline/0008-patchlevel-8.patch deleted +0 -51

51 lines not on this page · raw message

package/readline/readline.hash +1 -1
index d8833e9..43f8c64 100644
@@ -1,2 +1,2 @@
 # Locally calculated after checking pgp signature
-sha256	56ba6071b9462f980c5a72ab0023893b65ba6debb4eeb475d7a563dc65cafd43	readline-6.3.tar.gz
+sha256 750d437185286f40a369e1e4f4764eda932b9459b5ec9a731628393dd3d32334  readline-7.0.tar.gz
package/readline/readline.mk +1 -1
index 7631970..ed4e144 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-READLINE_VERSION = 6.3
+READLINE_VERSION = 7.0
 READLINE_SITE = $(BR2_GNU_MIRROR)/readline
 READLINE_INSTALL_STAGING = YES
 READLINE_DEPENDENCIES = ncurses
Signature · 1 line
2.10.1
author
#1 lore raw

PATCH 2/2 bash: bump version to 4.4

Signed-off-by Vicente Olivert Riera <[email protected]>

---
Notes to maintainer
- This new version contains a small security fix. From
http://tiswww.case.edu/php/chet/bash/NEWS:

"Shells running as root no longer inherit PS4 from the environment, closing a security hole involving PS4 expansion performing command substitution."

However, taking into account that bash is a critical package and the 2016.11 release is very close I've marked this patch as "next".

---
 package/bash/0031-patchlevel-31.patch | 116 -----------------
 package/bash/0032-patchlevel-32.patch |  55 --------
 package/bash/0033-patchlevel-33.patch | 229 ----------------------------------
 package/bash/0034-patchlevel-34.patch |  94 --------------
 package/bash/0035-patchlevel-35.patch |  67 ----------
 package/bash/0036-patchlevel-36.patch |  61 ---------
 package/bash/0037-patchlevel-37.patch |  47 -------
 package/bash/0038-patchlevel-38.patch |  92 --------------
 package/bash/0039-patchlevel-39.patch |  61 ---------
 package/bash/0040-patchlevel-40.patch |  51 --------
 package/bash/0041-patchlevel-41.patch |  76 -----------
 package/bash/0042-patchlevel-42.patch |  59 ---------
 package/bash/0043-patchlevel-43.patch |  63 ----------
 package/bash/0044-patchlevel-44.patch |  52 --------
 package/bash/0045-patchlevel-45.patch |  56 ---------
 package/bash/0046-patchlevel-46.patch |  59 ---------
 package/bash/bash.hash                |   2 +-
 package/bash/bash.mk                  |   2 +-
 18 files changed, 2 insertions(+), 1240 deletions(-)
 delete mode 100644 package/bash/0031-patchlevel-31.patch
 delete mode 100644 package/bash/0032-patchlevel-32.patch
 delete mode 100644 package/bash/0033-patchlevel-33.patch
 delete mode 100644 package/bash/0034-patchlevel-34.patch
 delete mode 100644 package/bash/0035-patchlevel-35.patch
 delete mode 100644 package/bash/0036-patchlevel-36.patch
 delete mode 100644 package/bash/0037-patchlevel-37.patch
 delete mode 100644 package/bash/0038-patchlevel-38.patch
 delete mode 100644 package/bash/0039-patchlevel-39.patch
 delete mode 100644 package/bash/0040-patchlevel-40.patch
 delete mode 100644 package/bash/0041-patchlevel-41.patch
 delete mode 100644 package/bash/0042-patchlevel-42.patch
 delete mode 100644 package/bash/0043-patchlevel-43.patch
 delete mode 100644 package/bash/0044-patchlevel-44.patch
 delete mode 100644 package/bash/0045-patchlevel-45.patch
 delete mode 100644 package/bash/0046-patchlevel-46.patch
package/bash/0031-patchlevel-31.patch deleted +0 -116
deleted file mode 100644
index d285a1f..0000000
@@ -1,116 +0,0 @@
-From http://ftp.gnu.org/pub/gnu/bash/bash-4.3-patches/bash43-031
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-			     BASH PATCH REPORT
-			     =================
-
-Bash-Release:	4.3
-Patch-ID:	bash43-031
-
-Bug-Reported-by:	lolilolicon <[email protected]>
-Bug-Reference-ID:	<CAMtVo_Nz=32Oq=zWTb6=+8gUNXOo2rRvud1W4oPnA-cgVk_ZqQ@mail.gmail.com>
-Bug-Reference-URL:	http://lists.gnu.org/archive/html/bug-bash/2014-08/msg00139.html
-
-Bug-Description:
-
-The new nameref assignment functionality introduced in bash-4.3 did not perform
-enough validation on the variable value and would create variables with
-invalid names.
-
-Patch (apply with `patch -p0'):
-
-*** a/bash-4.3-patched/subst.h	2014-01-11 21:02:27.000000000 -0500
---- b/subst.h	2014-09-01 12:16:56.000000000 -0400
-***************
-*** 48,51 ****
---- 48,52 ----
-  #define ASS_MKGLOBAL	0x0008	/* force global assignment */
-  #define ASS_NAMEREF	0x0010	/* assigning to nameref variable */
-+ #define ASS_FROMREF	0x0020	/* assigning from value of nameref variable */
-  
-  /* Flags for the string extraction functions. */
-*** a/bash-4.3-patched/variables.c	2014-05-15 08:26:50.000000000 -0400
---- b/variables.c	2014-09-01 14:37:44.000000000 -0400
-***************
-*** 2504,2511 ****
-       int hflags, aflags;
-  {
-!   char *newval;
-    SHELL_VAR *entry;
-  
-    entry = (hflags & HASH_NOSRCH) ? (SHELL_VAR *)NULL : hash_lookup (name, table);
-    /* Follow the nameref chain here if this is the global variables table */
-    if (entry && nameref_p (entry) && (invisible_p (entry) == 0) && table == global_variables->table)
---- 2566,2590 ----
-       int hflags, aflags;
-  {
-!   char *newname, *newval;
-    SHELL_VAR *entry;
-+ #if defined (ARRAY_VARS)
-+   arrayind_t ind;
-+   char *subp;
-+   int sublen;
-+ #endif
-  
-+   newname = 0;
-+ #if defined (ARRAY_VARS)
-+   if ((aflags & ASS_FROMREF) && (hflags & HASH_NOSRCH) == 0 && valid_array_reference (name))
-+     {
-+       newname = array_variable_name (name, &subp, &sublen);
-+       if (newname == 0)
-+ 	return (SHELL_VAR *)NULL;	/* XXX */
-+       entry = hash_lookup (newname, table);
-+     }
-+   else
-+ #endif
-    entry = (hflags & HASH_NOSRCH) ? (SHELL_VAR *)NULL : hash_lookup (name, table);
-+ 
-    /* Follow the nameref chain here if this is the global variables table */
-    if (entry && nameref_p (entry) && (invisible_p (entry) == 0) && table == global_variables->table)
-***************
-*** 2538,2541 ****
---- 2617,2630 ----
-        }
-      }
-+ #if defined (ARRAY_VARS)
-+   else if (entry == 0 && newname)
-+     {
-+       entry = make_new_array_variable (newname);	/* indexed array by default */
-+       if (entry == 0)
-+ 	return entry;
-+       ind = array_expand_index (name, subp, sublen);
-+       bind_array_element (entry, ind, value, aflags);
-+     }
-+ #endif
-    else if (entry == 0)
-      {
-***************
-*** 2658,2662 ****
-  		      if (nameref_cell (nv) == 0)
-  			return (bind_variable_internal (nv->name, value, nvc->table, 0, flags));
-! 		      return (bind_variable_internal (nameref_cell (nv), value, nvc->table, 0, flags));
-  		    }
-  		  else
---- 2747,2752 ----
-  		      if (nameref_cell (nv) == 0)
-  			return (bind_variable_internal (nv->name, value, nvc->table, 0, flags));
-! 		      /* XXX - bug here with ref=array[index] */
-! 		      return (bind_variable_internal (nameref_cell (nv), value, nvc->table, 0, flags|ASS_FROMREF));
-  		    }
-  		  else
-*** a/bash-4.3/patchlevel.h	2012-12-29 10:47:57.000000000 -0500
---- b/patchlevel.h	2014-03-20 20:01:28.000000000 -0400
-***************
-*** 26,30 ****
-     looks for to find the patch level (for the sccs version string). */
-  
-! #define PATCHLEVEL 30
-  
-  #endif /* _PATCHLEVEL_H_ */
---- 26,30 ----
-     looks for to find the patch level (for the sccs version string). */
-  
-! #define PATCHLEVEL 31
-  
-  #endif /* _PATCHLEVEL_H_ */
package/bash/0032-patchlevel-32.patch deleted +0 -55

55 lines not on this page · raw message

package/bash/0033-patchlevel-33.patch deleted +0 -229

229 lines not on this page · raw message

package/bash/0034-patchlevel-34.patch deleted +0 -94

94 lines not on this page · raw message

package/bash/0035-patchlevel-35.patch deleted +0 -67

67 lines not on this page · raw message

package/bash/0036-patchlevel-36.patch deleted +0 -61

61 lines not on this page · raw message

package/bash/0037-patchlevel-37.patch deleted +0 -47

47 lines not on this page · raw message

package/bash/0038-patchlevel-38.patch deleted +0 -92

92 lines not on this page · raw message

package/bash/0039-patchlevel-39.patch deleted +0 -61

61 lines not on this page · raw message

package/bash/0040-patchlevel-40.patch deleted +0 -51

51 lines not on this page · raw message

package/bash/0041-patchlevel-41.patch deleted +0 -76

76 lines not on this page · raw message

package/bash/0042-patchlevel-42.patch deleted +0 -59

59 lines not on this page · raw message

package/bash/0043-patchlevel-43.patch deleted +0 -63

63 lines not on this page · raw message

package/bash/0044-patchlevel-44.patch deleted +0 -52

52 lines not on this page · raw message

package/bash/0045-patchlevel-45.patch deleted +0 -56

56 lines not on this page · raw message

package/bash/0046-patchlevel-46.patch deleted +0 -59

59 lines not on this page · raw message

package/bash/bash.hash +1 -1
index faf2364..adbd608 100644
@@ -1,2 +1,2 @@
 # Locally calculated after checking pgp signature
-sha256	317881019bbf2262fb814b7dd8e40632d13c3608d2f237800a8828fbb8a640dd	bash-4.3.30.tar.gz
+sha256 d86b3392c1202e8ff5a423b302e6284db7f8f435ea9f39b5b1b20fd3ac36dfcb  bash-4.4.tar.gz
package/bash/bash.mk +1 -1
index 3cd8d82..090cf52 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-BASH_VERSION = 4.3.30
+BASH_VERSION = 4.4
 BASH_SITE = $(BR2_GNU_MIRROR)/bash
 # Build after since bash is better than busybox shells
 BASH_DEPENDENCIES = ncurses readline host-bison \
Signature · 1 line
2.10.1
#2 lore raw

PATCH 2/2 bash: bump version to 4.4

Hello,

Quoted 6 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>

---
Notes to maintainer
- This new version contains a small security fix. From
http://tiswww.case.edu/php/chet/bash/NEWS:

Quoted 6 lines

"Shells running as root no longer inherit PS4 from the environment, closing a security hole involving PS4 expansion performing command substitution."

However, taking into account that bash is a critical package and the 2016.11 release is very close I've marked this patch as "next".

"is a critical package" or "is *NOT* a critical package" ? If it's a critical package like you suggest, then perhaps we want it in master anyway ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#3 lore raw

PATCH 2/2 bash: bump version to 4.4

Hi Thomas,

Quoted 13 lines · Thomas Petazzoni

Hello,

Quoted 10 lines · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>

---
Notes to maintainer
- This new version contains a small security fix. From
http://tiswww.case.edu/php/chet/bash/NEWS:

"Shells running as root no longer inherit PS4 from the environment, closing a security hole involving PS4 expansion performing command substitution."

Quoted 6 lines
Quoted 2 lines

However, taking into account that bash is a critical package and the 2016.11 release is very close I've marked this patch as "next".

"is a critical package" or "is *NOT* a critical package" ? If it's a critical package like you suggest, then perhaps we want it in master anyway ?

It *IS*, that's why I thought you may not want to have such a big changes in master so close to the next release if you consider that security fix is not very important.

Of course, if you think it's important then apply it to master.

I'm gonna test more reverse dependencies of readline by the way. I'll let you know how it goes.

Vincent

Quoted 5 lines

Thanks,

Thomas

#4 lore raw

PATCH 2/2 bash: bump version to 4.4

In reply to Vicente Olivert Riera
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Signed-off-by Vicente Olivert Riera <[email protected]>

---
Notes to maintainer
- This new version contains a small security fix. From
http://tiswww.case.edu/php/chet/bash/NEWS:

Quoted 6 lines

"Shells running as root no longer inherit PS4 from the environment, closing a security hole involving PS4 expansion performing command substitution."

However, taking into account that bash is a critical package and the 2016.11 release is very close I've marked this patch as "next".

Yes, I think that is the best approach as well.

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/2 readline: bump version to 7.0

In reply to Vicente Olivert Riera

Hello,

Quoted 1 line · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>

Did you do a bit of build testing of the readline reverse dependencies, just to check there is no obvious regression caused by possible API changes?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#6 lore raw

PATCH 1/2 readline: bump version to 7.0

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 1 line · Vicente Olivert Riera
Signed-off-by Vicente Olivert Riera <[email protected]>

Did you do a bit of build testing of the readline reverse dependencies, just to check there is no obvious regression caused by possible API changes?

no, just bash-4.4.

Vincent

Quoted 4 lines

Thanks,

Thomas

author
#7 lore raw

PATCH 1/2 readline: bump version to 7.0

Hi Thomas,

Quoted 5 lines · Vicente Olivert Riera

Hi Thomas,

Quoted 2 lines · Thomas Petazzoni

Hello,

Quoted 8 lines
Quoted 6 lines · Vicente Olivert Riera
Quoted 1 line
Signed-off-by Vicente Olivert Riera <[email protected]>

Did you do a bit of build testing of the readline reverse dependencies, just to check there is no obvious regression caused by possible API changes?

no, just bash-4.4.

I have tested the new version of readline with this reverse dependencies:

gnuchess
python-readline
php-ext-readline
sqlite
chrony
socat
connman-client
xorriso
quagga-vtysh
wpa_supplicant
gawk
gnupg2
dropwatch
atftp
nftables
postgresql
lftp
softether
neardal
libnfc-examples
ipmitool-ipmishell
gnuplot
lvm2
lua-readline
bind
ruby
mysql
bash
slang
util-linux
parted
unixodbc
jack2

All of them built fine.

Regards,

Vincent

Quoted 12 lines

Vincent

Quoted 4 lines

Thanks,

Thomas

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#8 lore raw

PATCH 1/2 readline: bump version to 7.0

In reply to Vicente Olivert Riera
Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Signed-off-by Vicente Olivert Riera <[email protected]>
---
 package/readline/0001-patchlevel-1.patch | 47 ----------------------
 package/readline/0002-patchlevel-2.patch | 48 -----------------------
 package/readline/0003-patchlevel-3.patch | 51 ------------------------
 package/readline/0004-patchlevel-4.patch | 49 -----------------------
 package/readline/0005-patchlevel-5.patch | 62 -----------------------------
 package/readline/0006-patchlevel-6.patch | 67 --------------------------------
 package/readline/0007-patchlevel-7.patch | 51 ------------------------
 package/readline/0008-patchlevel-8.patch | 51 ------------------------
 package/readline/readline.hash           |  2 +-
 package/readline/readline.mk             |  2 +-
 10 files changed, 2 insertions(+), 428 deletions(-)
Quoted 8 lines
 delete mode 100644 package/readline/0001-patchlevel-1.patch
 delete mode 100644 package/readline/0002-patchlevel-2.patch
 delete mode 100644 package/readline/0003-patchlevel-3.patch
 delete mode 100644 package/readline/0004-patchlevel-4.patch
 delete mode 100644 package/readline/0005-patchlevel-5.patch
 delete mode 100644 package/readline/0006-patchlevel-6.patch
 delete mode 100644 package/readline/0007-patchlevel-7.patch
 delete mode 100644 package/readline/0008-patchlevel-8.patch

Committed to next, thanks.

Signature · 1 line
Bye, Peter Korsgaard