Skip to contentSkip to conversation

staging: sm750fb: fix function definition argument style warning

PATCH In review Andrea Ghittino 4 participants 7 messages Nov 27, 2016 – Nov 29, 2016

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Andrea Ghittino

author
#0 lore raw

PATCH 1/1 staging: sm750fb: fix function definition argument style warning

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <aghittino at gmail.com>

---

drivers/staging/sm750fb/ddk750_chip.h +1 -1
index e97e859..30653dd 100644
@@ -91,6 +91,6 @@ void sm750_set_chip_type(unsigned short devId, char revId);
 unsigned int sm750_calc_pll_value(unsigned int request, struct  pll_value *pll);
 unsigned int sm750_format_pll_reg(struct pll_value *pPLL);
 unsigned int ddk750_get_vm_size(void);
-int ddk750_init_hw(struct initchip_param *);
+int ddk750_init_hw(struct initchip_param *pInitParam);
 
 #endif
drivers/staging/sm750fb/ddk750_display.h +1 -1
index 8abca88..c4a4cbf 100644
@@ -107,6 +107,6 @@ typedef enum _disp_output_t {
 }
 disp_output_t;
 
-void ddk750_setLogicalDispOut(disp_output_t);
+void ddk750_setLogicalDispOut(disp_output_t output);
 
 #endif
drivers/staging/sm750fb/ddk750_mode.h +1 -1
index e846dc2..bdcfe69 100644
@@ -35,7 +35,7 @@ typedef struct _mode_parameter_t {
 }
 mode_parameter_t;
 
-int ddk750_setModeTiming(mode_parameter_t *, clock_type_t);
+int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
 
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index eb088b0..6de0458 100644
@@ -14,7 +14,7 @@ DPMS_t;
 	       (PEEK32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
 
-void ddk750_set_dpms(DPMS_t);
+void ddk750_set_dpms(DPMS_t state);
 void sm750_set_power_mode(unsigned int powerMode);
 void sm750_set_current_gate(unsigned int gate);
drivers/staging/sm750fb/sm750.h +14 -10
index 28f4b9b..3b7bced 100644
@@ -184,19 +184,23 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
 }
 
 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *);
-void hw_sm750_initAccel(struct sm750_dev *);
+int hw_sm750_inithw(struct sm750_dev *sm750_dev,, struct pci_dev *pdev);
+void hw_sm750_initAccel(struct sm750_dev *sm750_dev);
 int hw_sm750_deWait(void);
 int hw_sm750le_deWait(void);
 
-int hw_sm750_output_setMode(struct lynxfb_output*, struct fb_var_screeninfo*,
-			    struct fb_fix_screeninfo*);
-int hw_sm750_crtc_checkMode(struct lynxfb_crtc*, struct fb_var_screeninfo*);
-int hw_sm750_crtc_setMode(struct lynxfb_crtc*, struct fb_var_screeninfo*,
-			  struct fb_fix_screeninfo*);
-int hw_sm750_setColReg(struct lynxfb_crtc*, ushort, ushort, ushort, ushort);
-int hw_sm750_setBLANK(struct lynxfb_output*, int);
-int hw_sm750le_setBLANK(struct lynxfb_output*, int);
+int hw_sm750_output_setMode(struct lynxfb_output *output,
+				struct fb_var_screeninfo *var,
+				struct fb_fix_screeninfo *fix);
+int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo* var);
+int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo *var,
+			  	struct fb_fix_screeninfo *fix);
+int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
+				ushort red, ushort green , ushort blue);
+int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
+int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
 int hw_sm750_pan_display(struct lynxfb_crtc *crtc,
 			 const struct fb_var_screeninfo *var,
 			 const struct fb_info *info);
build bot
#1 lore raw
url: https://github.com/0day-ci/linux/commits/Andrea-Ghittino/staging-sm750fb-fix-function-definition-argument-style-warning/20161128-004817 config: i386-allmodconfig (attached as .config) compiler…

Hi Andrea,

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on next-20161125]
[cannot apply to v4.9-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Andrea-Ghittino/staging-sm750fb-fix-function-definition-argument-style-warning/20161128-004817
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

        # save the attached .config to linux build tree
        make ARCH=i386

All errors (new ones prefixed by >>):

In file included from drivers/staging/sm750fb/sm750.c:18:0:

>> drivers/staging/sm750fb/sm750.h:187:49: error: expected declaration specifiers or '...' before ',' token
    int hw_sm750_inithw(struct sm750_dev *sm750_dev,, struct pci_dev *pdev);
                                                    ^
   drivers/staging/sm750fb/sm750.c: In function 'lynxfb_resume':
>> drivers/staging/sm750fb/sm750.c:475:2: error: implicit declaration of function 'hw_sm750_inithw' [-Werror=implicit-function-declaration]
     hw_sm750_inithw(sm750_dev, pdev);
     ^~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   In file included from drivers/staging/sm750fb/sm750_hw.c:22:0:
>> drivers/staging/sm750fb/sm750.h:187:49: error: expected declaration specifiers or '...' before ',' token
    int hw_sm750_inithw(struct sm750_dev *sm750_dev,, struct pci_dev *pdev);
                                                    ^

vim +187 drivers/staging/sm750fb/sm750.h

181 /* 10^12 / picosecond period gives frequency in Hz */
182 do_div(numerator, psvalue);
183 return (unsigned long)numerator;
184 }
185
186 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);

 > 187	int hw_sm750_inithw(struct sm750_dev *sm750_dev,, struct pci_dev *pdev);

188 void hw_sm750_initAccel(struct sm750_dev *sm750_dev);
189 int hw_sm750_deWait(void);
190 int hw_sm750le_deWait(void);

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

author
#2 lore raw

PATCH 1/1 staging: sm750fb: fix function definition argument style warning

In reply to Andrea Ghittino

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <aghittino at gmail.com>

---

drivers/staging/sm750fb/ddk750_chip.h +1 -1
index e97e859..30653dd 100644
@@ -91,6 +91,6 @@ void sm750_set_chip_type(unsigned short devId, char revId);
 unsigned int sm750_calc_pll_value(unsigned int request, struct  pll_value *pll);
 unsigned int sm750_format_pll_reg(struct pll_value *pPLL);
 unsigned int ddk750_get_vm_size(void);
-int ddk750_init_hw(struct initchip_param *);
+int ddk750_init_hw(struct initchip_param *pInitParam);
 
 #endif
drivers/staging/sm750fb/ddk750_display.h +1 -1
index 8abca88..c4a4cbf 100644
@@ -107,6 +107,6 @@ typedef enum _disp_output_t {
 }
 disp_output_t;
 
-void ddk750_setLogicalDispOut(disp_output_t);
+void ddk750_setLogicalDispOut(disp_output_t output);
 
 #endif
drivers/staging/sm750fb/ddk750_mode.h +1 -1
index e846dc2..bdcfe69 100644
@@ -35,7 +35,7 @@ typedef struct _mode_parameter_t {
 }
 mode_parameter_t;
 
-int ddk750_setModeTiming(mode_parameter_t *, clock_type_t);
+int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
 
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index eb088b0..6de0458 100644
@@ -14,7 +14,7 @@ DPMS_t;
 	       (PEEK32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
 
-void ddk750_set_dpms(DPMS_t);
+void ddk750_set_dpms(DPMS_t state);
 void sm750_set_power_mode(unsigned int powerMode);
 void sm750_set_current_gate(unsigned int gate);
drivers/staging/sm750fb/sm750.h +14 -10
index 28f4b9b..3b7bced 100644
@@ -184,19 +184,23 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
 }
 
 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *);
-void hw_sm750_initAccel(struct sm750_dev *);
+int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
+void hw_sm750_initAccel(struct sm750_dev *sm750_dev);
 int hw_sm750_deWait(void);
 int hw_sm750le_deWait(void);
 
-int hw_sm750_output_setMode(struct lynxfb_output*, struct fb_var_screeninfo*,
-			    struct fb_fix_screeninfo*);
-int hw_sm750_crtc_checkMode(struct lynxfb_crtc*, struct fb_var_screeninfo*);
-int hw_sm750_crtc_setMode(struct lynxfb_crtc*, struct fb_var_screeninfo*,
-			  struct fb_fix_screeninfo*);
-int hw_sm750_setColReg(struct lynxfb_crtc*, ushort, ushort, ushort, ushort);
-int hw_sm750_setBLANK(struct lynxfb_output*, int);
-int hw_sm750le_setBLANK(struct lynxfb_output*, int);
+int hw_sm750_output_setMode(struct lynxfb_output *output,
+				struct fb_var_screeninfo *var,
+				struct fb_fix_screeninfo *fix);
+int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo* var);
+int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo *var,
+			  	struct fb_fix_screeninfo *fix);
+int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
+				ushort red, ushort green , ushort blue);
+int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
+int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
 int hw_sm750_pan_display(struct lynxfb_crtc *crtc,
 			 const struct fb_var_screeninfo *var,
 			 const struct fb_info *info);
#3 lore raw
In reply to Andrea Ghittino
Quoted 5 lines · Andrea Ghittino

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <aghittino at gmail.com>

---

Does checkpatch not complain about the camelcase variable names and function names?

Signature · 1 line
~Randy
author
#4 lore raw
In reply to Andrea Ghittino
Quoted 7 lines · Randy Dunlap
Quoted 5 lines · Andrea Ghittino

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <aghittino at gmail.com>

---

Quoted 6 lines

Does checkpatch not complain about the camelcase variable names and function names?

--
~Randy

No, it doesn't. But I correct some errors and changed one name for a variable

andrea

author
#5 lore raw

PATCH 1/1 staging: sm750fb: fix function definition argument style warning

In reply to Andrea Ghittino

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <[email protected]>

---

drivers/staging/sm750fb/ddk750_chip.h +1 -1
index e97e859..30653dd 100644
@@ -91,6 +91,6 @@ void sm750_set_chip_type(unsigned short devId, char revId);
 unsigned int sm750_calc_pll_value(unsigned int request, struct  pll_value *pll);
 unsigned int sm750_format_pll_reg(struct pll_value *pPLL);
 unsigned int ddk750_get_vm_size(void);
-int ddk750_init_hw(struct initchip_param *);
+int ddk750_init_hw(struct initchip_param *p_init_param);
 
 #endif
drivers/staging/sm750fb/ddk750_display.h +1 -1
index 8abca88..c4a4cbf 100644
@@ -107,6 +107,6 @@ typedef enum _disp_output_t {
 }
 disp_output_t;
 
-void ddk750_setLogicalDispOut(disp_output_t);
+void ddk750_setLogicalDispOut(disp_output_t output);
 
 #endif
drivers/staging/sm750fb/ddk750_mode.h +1 -1
index e846dc2..bdcfe69 100644
@@ -35,7 +35,7 @@ typedef struct _mode_parameter_t {
 }
 mode_parameter_t;
 
-int ddk750_setModeTiming(mode_parameter_t *, clock_type_t);
+int ddk750_setModeTiming(mode_parameter_t *parm, clock_type_t clock);
 
 
 #endif
drivers/staging/sm750fb/ddk750_power.h +1 -1
index eb088b0..6de0458 100644
@@ -14,7 +14,7 @@ DPMS_t;
 	       (PEEK32(MISC_CTRL) & ~MISC_CTRL_DAC_POWER_OFF) | (off)); \
 }
 
-void ddk750_set_dpms(DPMS_t);
+void ddk750_set_dpms(DPMS_t state);
 void sm750_set_power_mode(unsigned int powerMode);
 void sm750_set_current_gate(unsigned int gate);
drivers/staging/sm750fb/sm750.h +14 -10
index 28f4b9b..3b7bced 100644
@@ -184,19 +184,23 @@ static inline unsigned long ps_to_hz(unsigned int psvalue)
 }
 
 int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
-int hw_sm750_inithw(struct sm750_dev*, struct pci_dev *);
-void hw_sm750_initAccel(struct sm750_dev *);
+int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev);
+void hw_sm750_initAccel(struct sm750_dev *sm750_dev);
 int hw_sm750_deWait(void);
 int hw_sm750le_deWait(void);
 
-int hw_sm750_output_setMode(struct lynxfb_output*, struct fb_var_screeninfo*,
-			    struct fb_fix_screeninfo*);
-int hw_sm750_crtc_checkMode(struct lynxfb_crtc*, struct fb_var_screeninfo*);
-int hw_sm750_crtc_setMode(struct lynxfb_crtc*, struct fb_var_screeninfo*,
-			  struct fb_fix_screeninfo*);
-int hw_sm750_setColReg(struct lynxfb_crtc*, ushort, ushort, ushort, ushort);
-int hw_sm750_setBLANK(struct lynxfb_output*, int);
-int hw_sm750le_setBLANK(struct lynxfb_output*, int);
+int hw_sm750_output_setMode(struct lynxfb_output *output,
+				struct fb_var_screeninfo *var,
+				struct fb_fix_screeninfo *fix);
+int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo *var);
+int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
+				struct fb_var_screeninfo *var,
+				struct fb_fix_screeninfo *fix);
+int hw_sm750_setColReg(struct lynxfb_crtc *crtc, ushort index,
+				ushort red, ushort green, ushort blue);
+int hw_sm750_setBLANK(struct lynxfb_output *output, int blank);
+int hw_sm750le_setBLANK(struct lynxfb_output *output, int blank);
 int hw_sm750_pan_display(struct lynxfb_crtc *crtc,
 			 const struct fb_var_screeninfo *var,
 			 const struct fb_info *info);
maintainer
#6 lore raw
In reply to Andrea Ghittino
Quoted 4 lines · Andrea Ghittino

Fixes sm750fb function definition argument style warning found by checkpatch.pl tool

Signed-off-by Andrea Ghittino <aghittino at gmail.com>

You need to version your patches when you send multiple copies out. Again, please read Documentation/SubmittingPatches for how to do this and also fix up your email address. I've dropped all of your patches from my patch review queue now, please resend everything.

thanks,

greg k-h