ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040
Subsystems (3)
PATCH 1/1 ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040
Dell Wyse 3040 requires the platform workaround for enabling dmic and jack detection as defined for Braswell CRB.
---
I guess the platform data should be applied generically to all CHT machines instead of DMI matching? DMI matching doesn't scale, obviously.
sound/soc/codecs/rt5670.c | 7 +++++++ 1 file changed, 7 insertions(+)
sound/soc/codecs/rt5670.c +7 -0
@@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"), }, }, + { + .ident = "Dell Wyse 3040", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), + }, + }, {} };
Signature · 1 line
2.10.2
Quoted 10 lines · Takashi Iwai
Dell Wyse 3040 requires the platform workaround for enabling dmic and jack detection as defined for Braswell CRB.
Signed-off-by Takashi Iwai <[email protected]>---
I guess the platform data should be applied generically to all CHT machines instead of DMI matching? DMI matching doesn't scale, obviously.
we ahve been doing this on other RT codecs like RT286/298 as well for combo jack to work. Yeah a better solution would be welcomed :)
Quoted 25 lines
sound/soc/codecs/rt5670.c | 7 +++++++ 1 file changed, 7 insertions(+)sound/soc/codecs/rt5670.c +7
-0@@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"), }, }, + { + .ident = "Dell Wyse 3040", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), + }, + }, {} };Signature · 1 line
2.10.2
Signature · 1 line
~Vinod
Quoted 7 lines · Vinod Koul
Quoted 5 lines · Takashi Iwai
Dell Wyse 3040 requires the platform workaround for enabling dmic and jack detection as defined for Braswell CRB.
Signed-off-by Takashi Iwai <[email protected]>
Quoted 8 lines
Quoted 5 lines
---
I guess the platform data should be applied generically to all CHT machines instead of DMI matching? DMI matching doesn't scale, obviously.
we ahve been doing this on other RT codecs like RT286/298 as well for combo jack to work. Yeah a better solution would be welcomed :)
Well, the question is how generic the given platform-specific setup is. I guess we can keep the dmi thingy for a while, although we'll need more generic solution (or a pattern matching for a wider range of machines). So, if you think the addition of DMI entries is OK, give your ack :)
thanks,
Takashi
Quoted 30 lines
Quoted 26 lines
sound/soc/codecs/rt5670.c | 7 +++++++ 1 file changed, 7 insertions(+)sound/soc/codecs/rt5670.c +7
-0@@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"), }, }, + { + .ident = "Dell Wyse 3040", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), + }, + }, {} };Signature · 1 line
2.10.2Signature · 1 line
~Vinod
Vinod Koul
Acked-byQuoted 15 lines · Takashi Iwai
Quoted 13 lines · Vinod Koul
Quoted 10 lines · Takashi Iwai
Dell Wyse 3040 requires the platform workaround for enabling dmic and jack detection as defined for Braswell CRB.
Signed-off-by Takashi Iwai <[email protected]>---
I guess the platform data should be applied generically to all CHT machines instead of DMI matching? DMI matching doesn't scale, obviously.
Quoted 7 lines
Quoted 2 lines
we ahve been doing this on other RT codecs like RT286/298 as well for combo jack to work. Yeah a better solution would be welcomed :)
Well, the question is how generic the given platform-specific setup is. I guess we can keep the dmi thingy for a while, although we'll need more generic solution (or a pattern matching for a wider range of machines).
Mostly if people stuck to Intel ref designs, then it would same, which has been a problem on embedded side, but who knows.. :(
Quoted 2 lines
So, if you think the addition of DMI entries is OK, give your ack :)
Absolutely atm :)
Signature · 1 line
~Vinod
Mark Brown
maintainerQuoted 9 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Well, the question is how generic the given platform-specific setup is. I guess we can keep the dmi thingy for a while, although we'll need more generic solution (or a pattern matching for a wider range of machines).
Mostly if people stuck to Intel ref designs, then it would same, which has been a problem on embedded side, but who knows.. :(
That's just not at all realistic - if the systems are only going to be supportable when people copy the reference designs verbatim then we're going to have serious problems, that's just not how things work in the real world (especially at the higher end of the market where there's a greater desire for differentiation).
Mark Brown
maintainerApplied "ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040" to the asoc tree
In reply to Takashi IwaiThe patch
ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
b4ff47d2843f7df61b956c8ee4a576bf83b11fabMon Sep 17 00:00:00 2001
From: Takashi Iwai <[email protected]>
Date: Wed, 30 Nov 2016 17:19:20 +0100
Subject: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell
Wyse 3040
Dell Wyse 3040 requires the platform workaround for enabling dmic and jack detection as defined for Braswell CRB.
--- sound/soc/codecs/rt5670.c | 7 +++++++ 1 file changed, 7 insertions(+)
sound/soc/codecs/rt5670.c +7 -0
@@ -2826,6 +2826,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = { DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"), }, }, + { + .ident = "Dell Wyse 3040", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"), + }, + }, {} };
Signature · 1 line
2.10.2