Skip to contentSkip to conversation

drm/i915: make i915_suspend_switcheroo static

PATCH In review Matthew Auld 3 participants 4 messages Dec 2, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: make i915_suspend_switcheroo static

Looks like this was missed when unexporting, so let's keep sparse happy.

Cc Tvrtko Ursulin <[email protected]>
Fixes 7f26cb88014a ("drm/i915: Unexport VGA switcheroo functions")
---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +1 -1
index ace9be8f6ff9..ae583c79c19f 100644
@@ -1522,7 +1522,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
 	return ret;
 }
 
-int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)
+static int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)
 {
 	int error;
 
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Matthew Auld

Looks like this was missed when unexporting, so let's keep sparse happy.

Cc Tvrtko Ursulin <[email protected]>
Fixes 7f26cb88014a ("drm/i915: Unexport VGA switcheroo functions")
---
 drivers/gpu/drm/i915/i915_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +0 -0
index ace9be8f6ff9..ae583c79c19f 100644

drivers/gpu/drm/i915/i915_drv.c static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation) · line 1527

Quoted 7 lines
drivers/gpu/drm/i915/i915_drv.c +1 -1
@@ -1522,7 +1522,7 @@ static int i915_drm_suspend_late(struct drm_device *dev, bool hibernation)
 	return ret;
 }
 
-int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)
+static int i915_suspend_switcheroo(struct drm_device *dev, pm_message_t state)
 {
 	int error;

Gah.. sorry, another half distracted. Thanks for fixing it.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✓ Fi.CI.BAT: success for drm/i915: make i915_suspend_switcheroo static

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: drm/i915: make i915_suspend_switcheroo static
URL : https://patchwork.freedesktop.org/series/16269/
State : success

== Summary ==

Series 16269v1 drm/i915: make i915_suspend_switcheroo static
https://patchwork.freedesktop.org/api/1.0/series/16269/revisions/1/mbox/

fi-bdw-5557u     total:245  pass:230  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:245  pass:205  dwarn:0   dfail:0   fail:0   skip:40 
fi-byt-j1900     total:245  pass:217  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:245  pass:213  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:245  pass:225  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:245  pass:225  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:245  pass:192  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7500u     total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:245  pass:231  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:245  pass:224  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:245  pass:223  dwarn:1   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:245  pass:231  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:245  pass:213  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:245  pass:212  dwarn:0   dfail:0   fail:0   skip:33 

f13868539d56703427fdce7f532907c22252f12f drm-tip: 2016y-12m-02d-09h-56m-05s UTC integration manifest d824940 drm/i915: make i915_suspend_switcheroo static

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3170/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: make i915_suspend_switcheroo static

Quoted 29 lines · Patchwork

== Series Details ==

Series: drm/i915: make i915_suspend_switcheroo static
URL : https://patchwork.freedesktop.org/series/16269/
State : success

== Summary ==

Series 16269v1 drm/i915: make i915_suspend_switcheroo static
https://patchwork.freedesktop.org/api/1.0/series/16269/revisions/1/mbox/

fi-bdw-5557u     total:245  pass:230  dwarn:0   dfail:0   fail:0   skip:15
fi-bsw-n3050     total:245  pass:205  dwarn:0   dfail:0   fail:0   skip:40
fi-byt-j1900     total:245  pass:217  dwarn:0   dfail:0   fail:0   skip:28
fi-byt-n2820     total:245  pass:213  dwarn:0   dfail:0   fail:0   skip:32
fi-hsw-4770      total:245  pass:225  dwarn:0   dfail:0   fail:0   skip:20
fi-hsw-4770r     total:245  pass:225  dwarn:0   dfail:0   fail:0   skip:20
fi-ilk-650       total:245  pass:192  dwarn:0   dfail:0   fail:0   skip:53
fi-ivb-3520m     total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22
fi-ivb-3770      total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22
fi-kbl-7500u     total:245  pass:223  dwarn:0   dfail:0   fail:0   skip:22
fi-skl-6260u     total:245  pass:231  dwarn:0   dfail:0   fail:0   skip:14
fi-skl-6700hq    total:245  pass:224  dwarn:0   dfail:0   fail:0   skip:21
fi-skl-6700k     total:245  pass:223  dwarn:1   dfail:0   fail:0   skip:21
fi-skl-6770hq    total:245  pass:231  dwarn:0   dfail:0   fail:0   skip:14
fi-snb-2520m     total:245  pass:213  dwarn:0   dfail:0   fail:0   skip:32
fi-snb-2600      total:245  pass:212  dwarn:0   dfail:0   fail:0   skip:33
Quoted 2 lines

f13868539d56703427fdce7f532907c22252f12f drm-tip: 2016y-12m-02d-09h-56m-05s UTC integration manifest d824940 drm/i915: make i915_suspend_switcheroo static

Pushed. Thanks again for cleaning up after me. :)

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx