Skip to contentSkip to conversation

mmc: spear: remove the entire spear_sdhci.c file

RFC PATCH New Jaehoon Chung 2 participants 3 messages Dec 2, 2016 – Dec 19, 2016 MMC, SD and SDIO

lore
Share & tools
lore

Jaehoon Chung

author
#0 lore raw

RFC PATCH 1/1 mmc: spear: remove the entire spear_sdhci.c file

Remove the entire spear_sdhci.c file.
There is no use case. This is dead codes.
Also there is no place to call "spear_sdhci_init()" anywhere.

If some people use this file, let me know, plz.

Signed-off-by Jaehoon Chung <[email protected]>
---
 drivers/mmc/Makefile      |  1 -
 drivers/mmc/spear_sdhci.c | 27 ---------------------------
 2 files changed, 28 deletions(-)
 delete mode 100644 drivers/mmc/spear_sdhci.c
drivers/mmc/Makefile +0 -1
index d850758..94da954 100644
@@ -52,7 +52,6 @@ obj-$(CONFIG_SDHCI) += sdhci.o
 obj-$(CONFIG_SH_MMCIF) += sh_mmcif.o
 obj-$(CONFIG_SH_SDHI) += sh_sdhi.o
 obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o
-obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o
 obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o
 obj-$(CONFIG_MMC_UNIPHIER) += uniphier-sd.o
 obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o
drivers/mmc/spear_sdhci.c deleted +0 -27
deleted file mode 100644
index 06179cd..0000000
@@ -1,27 +0,0 @@
-/*
- * (C) Copyright 2012
- * Vipin Kumar, ST Micoelectronics, vipin.kumar at st.com.
- *
- * SPDX-License-Identifier:	GPL-2.0+
- */
-
-#include <common.h>
-#include <malloc.h>
-#include <sdhci.h>
-
-int spear_sdhci_init(u32 regbase, u32 max_clk, u32 min_clk, u32 quirks)
-{
-	struct sdhci_host *host = NULL;
-	host = (struct sdhci_host *)malloc(sizeof(struct sdhci_host));
-	if (!host) {
-		printf("sdhci host malloc fail!\n");
-		return 1;
-	}
-
-	host->name = "sdhci";
-	host->ioaddr = (void *)regbase;
-	host->quirks = quirks;
-
-	add_sdhci(host, max_clk, min_clk);
-	return 0;
-}
Signature · 1 line
2.10.2
#1 lore raw

RFC PATCH 1/1 mmc: spear: remove the entire spear_sdhci.c file

Quoted 7 lines · Jaehoon Chung

Remove the entire spear_sdhci.c file.
There is no use case. This is dead codes.
Also there is no place to call "spear_sdhci_init()" anywhere.

If some people use this file, let me know, plz.

Signed-off-by Jaehoon Chung <[email protected]>

It looks like it was added as dead code so:

Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161202/36c0e59b/attachment.sig>
author
#2 lore raw

RFC PATCH 1/1 mmc: spear: remove the entire spear_sdhci.c file

Quoted 6 lines · Tom Rini
Quoted 4 lines · Jaehoon Chung

Remove the entire spear_sdhci.c file.
There is no use case. This is dead codes.
Also there is no place to call "spear_sdhci_init()" anywhere.

Quoted 7 lines
Quoted 3 lines

If some people use this file, let me know, plz.

Signed-off-by Jaehoon Chung <[email protected]>

It looks like it was added as dead code so:

Reviewed-by Tom Rini <[email protected]>

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

Quoted 1 line