Skip to contentSkip to conversation

drm/i915: Add I2C and DP-AUX char devices to debug kconfig

PATCH In review Imre Deak 3 participants 4 messages Dec 2, 2016 – Dec 5, 2016

Subsystems (2)
lore
Share & tools
lore

Imre Deak

author
#0 lore raw

PATCH 1/1 drm/i915: Add I2C and DP-AUX char devices to debug kconfig

These char devices exposing the driver's I2C and DP-AUX adapters for user space tools are useful to debug display output related issues. Enable them with the rest of additional driver debug options.

---
 drivers/gpu/drm/i915/Kconfig.debug | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/Kconfig.debug +2 -0
index a6c69b8..cc4ad57 100644
@@ -19,6 +19,8 @@ config DRM_I915_DEBUG
         bool "Enable additional driver debugging"
         depends on DRM_I915
         select PREEMPT_COUNT
+        select I2C_CHARDEV
+        select DRM_DP_AUX_CHARDEV
         select X86_MSR # used by igt/pm_rpm
         select DRM_VGEM # used by igt/prime_vgem (dmabuf interop checks)
         select DRM_DEBUG_MM if DRM=y
Signature · 6 lines
2.5.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915: Add I2C and DP-AUX char devices to debug kconfig

== Series Details ==

== Series Details ==

Series: drm/i915: Add I2C and DP-AUX char devices to debug kconfig
URL : https://patchwork.freedesktop.org/series/16295/
State : success

== Summary ==

Series 16295v1 drm/i915: Add I2C and DP-AUX char devices to debug kconfig
https://patchwork.freedesktop.org/api/1.0/series/16295/revisions/1/mbox/

fi-bdw-5557u     total:247  pass:232  dwarn:0   dfail:0   fail:0   skip:15 
fi-bsw-n3050     total:247  pass:207  dwarn:0   dfail:0   fail:0   skip:40 
fi-bxt-t5700     total:247  pass:219  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-j1900     total:247  pass:219  dwarn:0   dfail:0   fail:0   skip:28 
fi-byt-n2820     total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 
fi-hsw-4770      total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 
fi-hsw-4770r     total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 
fi-ilk-650       total:247  pass:194  dwarn:0   dfail:0   fail:0   skip:53 
fi-ivb-3520m     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 
fi-ivb-3770      total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 
fi-kbl-7500u     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 
fi-skl-6260u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-skl-6700hq    total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 
fi-skl-6700k     total:247  pass:223  dwarn:3   dfail:0   fail:0   skip:21 
fi-skl-6770hq    total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 
fi-snb-2520m     total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 
fi-snb-2600      total:247  pass:214  dwarn:0   dfail:0   fail:0   skip:33 

16c2727017476099091b70f53da7eb365f2a001e drm-tip: 2016y-12m-02d-16h-19m-57s UTC integration manifest c17d464 drm/i915: Add I2C and DP-AUX char devices to debug kconfig

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3176/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author Applied
#2 lore raw

Re: ✓ Fi.CI.BAT: success for drm/i915: Add I2C and DP-AUX char devices to debug kconfig

Quoted 10 lines · Patchwork

== Series Details ==

Series: drm/i915: Add I2C and DP-AUX char devices to debug kconfig URL   : https://patchwork.freedesktop.org/series/16295/
State : success

== Summary ==

Series 16295v1 drm/i915: Add I2C and DP-AUX char devices to debug kconfig
https://patchwork.freedesktop.org/api/1.0/series/16295/revisions/1/mbox/

Pushed to -dinq, thanks for the review.

Quoted 18 lines

fi-bdw-5557u     total:247  pass:232  dwarn:0   dfail:0   fail:0   skip:15 fi-bsw-n3050     total:247  pass:207  dwarn:0   dfail:0   fail:0   skip:40 fi-bxt-t5700     total:247  pass:219  dwarn:0   dfail:0   fail:0   skip:28 fi-byt-j1900     total:247  pass:219  dwarn:0   dfail:0   fail:0   skip:28 fi-byt-n2820     total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 fi-hsw-4770      total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 fi-hsw-4770r     total:247  pass:227  dwarn:0   dfail:0   fail:0   skip:20 fi-ilk-650       total:247  pass:194  dwarn:0   dfail:0   fail:0   skip:53 fi-ivb-3520m     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 fi-ivb-3770      total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 fi-kbl-7500u     total:247  pass:225  dwarn:0   dfail:0   fail:0   skip:22 fi-skl-6260u     total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 fi-skl-6700hq    total:247  pass:226  dwarn:0   dfail:0   fail:0   skip:21 fi-skl-6700k     total:247  pass:223  dwarn:3   dfail:0   fail:0   skip:21 fi-skl-6770hq    total:247  pass:233  dwarn:0   dfail:0   fail:0   skip:14 fi-snb-2520m     total:247  pass:215  dwarn:0   dfail:0   fail:0   skip:32 fi-snb-2600      total:247  pass:214  dwarn:0   dfail:0   fail:0   skip:33

Quoted 6 lines

16c2727017476099091b70f53da7eb365f2a001e drm-tip: 2016y-12m-02d-16h-19m-57s UTC integration manifest c17d464 drm/i915: Add I2C and DP-AUX char devices to debug kconfig

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3176/

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Imre Deak
Quoted 6 lines · Imre Deak

These char devices exposing the driver's I2C and DP-AUX adapters for user space tools are useful to debug display output related issues. Enable them with the rest of additional driver debug options.

Quoted 17 lines
---
 drivers/gpu/drm/i915/Kconfig.debug | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/Kconfig.debug +2 -0
index a6c69b8..cc4ad57 100644
@@ -19,6 +19,8 @@ config DRM_I915_DEBUG
         bool "Enable additional driver debugging"
         depends on DRM_I915
         select PREEMPT_COUNT
+        select I2C_CHARDEV
+        select DRM_DP_AUX_CHARDEV
         select X86_MSR # used by igt/pm_rpm
         select DRM_VGEM # used by igt/prime_vgem (dmabuf interop checks)
         select DRM_DEBUG_MM if DRM=y
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx