ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL setting
Subsystems (3)
PATCH 1/1 ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL setting
The logic of "value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_XXXXXX;" is unnecessary complex. By setting CS35L34_MCLK_DIV | CS35L34_MCLK_RATE_MASK as the mask for regmap_update_bits() call, what the code does is exactly the same as setting value = CS35L34_MCLK_RATE_XXXXXX.
--- sound/soc/codecs/cs35l34.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/cs35l34.c +3 -3
@@ -610,15 +610,15 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai,switch (freq) {case CS35L34_MCLK_5644 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_5P6448 ; + value =CS35L34_MCLK_RATE_5P6448 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P0000 ; + value =CS35L34_MCLK_RATE_6P0000 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6144 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P1440 ; + value =CS35L34_MCLK_RATE_6P1440 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_11289 :
Signature · 1 line
2.9.3
Quoted 23 lines · Axel Lin
The logic of "value = ~CS35L34_MCLK_DIV &
CS35L34_MCLK_RATE_XXXXXX;" is unnecessary complex. By settingCS35L34_MCLK_DIV|CS35L34_MCLK_RATE_MASKas the mask forregmap_update_bits()call, what the code does is exactly the same as setting value =CS35L34_MCLK_RATE_XXXXXX.Signed-off-by Axel Lin <[email protected]>--- sound/soc/codecs/cs35l34.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)sound/soc/codecs/cs35l34.c +1
-1@@ -610,15 +610,15 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai,switch (freq) {case CS35L34_MCLK_5644 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_5P6448 ; + value =CS35L34_MCLK_RATE_5P6448 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6 :
sound/soc/codecs/cs35l34.c static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai, · line 624
Quoted 10 lines
sound/soc/codecs/cs35l34.c +2
-2- value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P0000 ; + value =CS35L34_MCLK_RATE_6P0000 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6144 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P1440 ; + value =CS35L34_MCLK_RATE_6P1440 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_11289 :
Mark Brown
maintainerApplied "ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL setting" to the asoc tree
In reply to Axel LinThe patch
ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL setting
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
914657c2be09fb89a50c7841e98186301c93767eMon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Sat, 3 Dec 2016 15:10:50 +0800
Subject: [PATCH] ASoC: cs35l34: Simplify the logic to set CS35L34_MCLK_CTL
setting
The logic of "value = ~CS35L34_MCLK_DIV & CS35L34_MCLK_RATE_XXXXXX;" is unnecessary complex. By setting CS35L34_MCLK_DIV | CS35L34_MCLK_RATE_MASK as the mask for regmap_update_bits() call, what the code does is exactly the same as setting value = CS35L34_MCLK_RATE_XXXXXX.
--- sound/soc/codecs/cs35l34.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/cs35l34.c +3 -3
@@ -610,15 +610,15 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai,switch (freq) {case CS35L34_MCLK_5644 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_5P6448 ; + value =CS35L34_MCLK_RATE_5P6448 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P0000 ; + value =CS35L34_MCLK_RATE_6P0000 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_6144 : - value = ~CS35L34_MCLK_DIV &CS35L34_MCLK_RATE_6P1440 ; + value =CS35L34_MCLK_RATE_6P1440 ; cs35l34->mclk_int = freq;break ;case CS35L34_MCLK_11289 :
Signature · 1 line
2.10.2