sunxi: move CONFIG_SATAPWR to Kconfig option

PATCH New Jelle van der Waa 4 participants 11 messages Nov 23, 2016 – Dec 9, 2016 Arm/Allwinner sunXi SoC support

lore

Share & tools

lore

Jelle van der Waa

author

2016-11-23 18:28 UTC #0 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.

Signed-off-by Jelle van der Waa <[email protected]>

---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)

board/sunxi/Kconfig +7 -0

index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
 config SPL_STACK_R_ADDR
 	default 0x4fe00000 if MACH_SUN4I || MACH_SUN5I || MACH_SUN6I || MACH_SUN7I || MACH_SUN8I || MACH_SUN50I
 	default 0x2fe00000 if MACH_SUN9I

board/sunxi/board.c +6 -5

index 5365638..71b1ebf 100644
@@ -80,7 +80,7 @@ DECLARE_GLOBAL_DATA_PTR;
 /* add board specific code here */
 int board_init(void)
 {
-	__maybe_unused int id_pfr1, ret;
+	__maybe_unused int id_pfr1, ret, pin;
 
 	gd->bd->bi_boot_params = (PHYS_SDRAM_0 + 0x100);

@@ -117,10 +117,11 @@ int board_init(void)
 	if (ret)
 		return ret;
 
-#ifdef CONFIG_SATAPWR
-	gpio_request(CONFIG_SATAPWR, "satapwr");
-	gpio_direction_output(CONFIG_SATAPWR, 1);
-#endif
+pin = sunxi_name_to_gpio(CONFIG_SATAPWR);
+if (pin >= 0) {
+	gpio_request(pin, "satapwr");
+	gpio_direction_output(pin, 1);
+}
 #ifdef CONFIG_MACPWR
 	gpio_request(CONFIG_MACPWR, "macpwr");
 	gpio_direction_output(CONFIG_MACPWR, 1);

configs/A10-OLinuXino-Lime_defconfig +2 -1

index bb7eaf8..99b5744 100644
@@ -9,7 +9,8 @@ CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun4i-a10-olinuxino-lime"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_EMAC,SATAPWR=SUNXI_GPC(3)"
+CONFIG_SATAPWR="PC3"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_EMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/A20-OLinuXino-Lime2_defconfig +2 -1

index d48e35d..824fc86 100644
@@ -9,7 +9,8 @@ CONFIG_USB0_VBUS_DET="PH5"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,SATAPWR=SUNXI_GPC(3)"
+CONFIG_SATAPWR="PC3"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/A20-OLinuXino-Lime_defconfig +2 -1

index 7c5d84d..2791023 100644
@@ -7,7 +7,8 @@ CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,SATAPWR=SUNXI_GPC(3)"
+CONFIG_SATAPWR="PC3"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/A20-OLinuXino_MICRO_defconfig +2 -1

index 9eb5f1b..774099e 100644
@@ -10,7 +10,8 @@ CONFIG_VIDEO_VGA=y
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-micro"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,SATAPWR=SUNXI_GPB(8)"
+CONFIG_SATAPWR="PB8"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/A20-Olimex-SOM-EVB_defconfig +2 -1

index 53d800f..139173e 100644
@@ -12,7 +12,8 @@ CONFIG_USB0_VBUS_DET="PH5"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olimex-som-evb"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,SATAPWR=SUNXI_GPC(3)"
+CONFIG_SATAPWR="PC3"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Cubieboard2_defconfig +2 -1

index 9212a17..17923b7 100644
@@ -7,7 +7,8 @@ CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-cubieboard2"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,SATAPWR=SUNXI_GPB(8)"
+CONFIG_SATAPWR="PB8"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Cubieboard_defconfig +2 -1

index 6e7e741..5595e85 100644
@@ -7,7 +7,8 @@ CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun4i-a10-cubieboard"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_EMAC,SATAPWR=SUNXI_GPB(8)"
+CONFIG_SATAPWR="PB8"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_EMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Cubietruck_defconfig +2 -1

index 37b60b85..2825646 100644
@@ -12,7 +12,8 @@ CONFIG_GMAC_TX_DELAY=1
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-cubietruck"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,SATAPWR=SUNXI_GPH(12)"
+CONFIG_SATAPWR="PH12"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Itead_Ibox_A20_defconfig +2 -1

index d544d50..2bddab3 100644
@@ -7,7 +7,8 @@ CONFIG_MMC0_CD_PIN="PH1"
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-itead-ibox"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,SATAPWR=SUNXI_GPB(8)"
+CONFIG_SATAPWR="PB8"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Lamobo_R1_defconfig +2 -1

index 58bc5a2..aaa71bb 100644
@@ -8,7 +8,8 @@ CONFIG_GMAC_TX_DELAY=4
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-lamobo-r1"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,MACPWR=SUNXI_GPH(23),SATAPWR=SUNXI_GPB(3)"
+CONFIG_SATAPWR="PB3"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,MACPWR=SUNXI_GPH(23)"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Linksprite_pcDuino3_Nano_defconfig +2 -1

index 8cbe9c3..130dfe7 100644
@@ -9,7 +9,8 @@ CONFIG_GMAC_TX_DELAY=3
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-pcduino3-nano"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII,SATAPWR=SUNXI_GPH(2)"
+CONFIG_SATAPWR="PH2"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,RGMII"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Linksprite_pcDuino3_defconfig +2 -1

index 5d155b4..d64f388 100644
@@ -7,7 +7,8 @@ CONFIG_DRAM_ZQ=122
 CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-pcduino3"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
 CONFIG_AHCI=y
-CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC,SATAPWR=SUNXI_GPH(2)"
+CONFIG_SATAPWR="PH2"
+CONFIG_SYS_EXTRA_OPTIONS="SUNXI_GMAC"
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set

configs/Sinovoip_BPI_M3_defconfig +1 -1

index d15ac20..1507950 100644
@@ -13,7 +13,7 @@ CONFIG_USB1_VBUS_PIN="PD24"
 CONFIG_AXP_GPIO=y
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-a83t-sinovoip-bpi-m3"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
-CONFIG_SYS_EXTRA_OPTIONS="SATAPWR=SUNXI_GPD(25)"
+CONFIG_SATAPWR="PD25"
 CONFIG_CONSOLE_MUX=y
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set

configs/orangepi_plus_defconfig +2 -1

index bf88fef..e536095 100644
@@ -9,7 +9,8 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2
 CONFIG_USB1_VBUS_PIN="PG13"
 CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-orangepi-plus"
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
-CONFIG_SYS_EXTRA_OPTIONS="SATAPWR=SUNXI_GPG(11),MACPWR=SUNXI_GPD(6)"
+CONFIG_SATAPWR="PG11"
+CONFIG_SYS_EXTRA_OPTIONS="MACPWR=SUNXI_GPD(6)"
 CONFIG_CONSOLE_MUX=y
 CONFIG_SPL=y
 # CONFIG_CMD_IMLS is not set

Signature · 1 line

2.10.2

Maxime Ripard

2016-11-24 21:22 UTC #1 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 28 lines · Jelle van der Waa

Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.

Signed-off-by Jelle van der Waa <[email protected]>

---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)

board/sunxi/Kconfig +0 -0

index ae2fba1..fe2f7b4 100644

board/sunxi/Kconfig config GMAC_TX_DELAY · line 676

Quoted 10 lines

board/sunxi/Kconfig +7 -0

@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+

This looks like a rather generic option. Can't this be in drivers/block instead?

Thanks,
Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161124/238ed8cd/attachment.sig>

Hans de Goede

2016-11-25 08:12 UTC #2 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Hi,

Quoted 32 lines · Maxime Ripard

Quoted 31 lines · Jelle van der Waa

Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.

Signed-off-by Jelle van der Waa <[email protected]>

---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)

board/sunxi/Kconfig +0 -0

index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.

Quoted 10 lines

board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?

The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.

Regards,

Hans

Maxime Ripard

2016-11-28 12:42 UTC #3 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Hi Hans,

Quoted 46 lines · Hans de Goede

Hi,

Quoted 32 lines · Maxime Ripard

Quoted 31 lines · Jelle van der Waa

Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.

Signed-off-by Jelle van der Waa <[email protected]>

---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)

board/sunxi/Kconfig +0 -0

index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.

Quoted 10 lines

board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?

Quoted 5 lines

The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.

Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.

Moving that option to drivers/block would make more sense I guess.

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161128/30f5756e/attachment.sig>

Hans de Goede

2016-11-28 13:20 UTC #4 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

HI,

Quoted 55 lines · Maxime Ripard

Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.

Quoted 4 lines

Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Moving that option to drivers/block would make more sense I guess.

Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.

Anyways either way is fine with me.

Regards,

Hans

Maxime Ripard

2016-11-29 20:39 UTC #5 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 61 lines · Hans de Goede

HI,
Quoted 58 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.

Quoted 7 lines

Quoted 1 line
Moving that option to drivers/block would make more sense I guess.
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.
Anyways either way is fine with me.

I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161129/cdc51164/attachment.sig>

Tom Rini

2016-11-29 21:11 UTC #6 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 64 lines · Maxime Ripard

Quoted 63 lines · Hans de Goede
HI,
Quoted 59 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Moving that option to drivers/block would make more sense I guess.

Quoted 8 lines

Quoted 5 lines
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.
Anyways either way is fine with me.
I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.

We also don't want to get hung up on fixing sub-optional solutions while also converting to Kconfig. We can move the option now and see about re-naming or getting the information elsewhere afterwards. Thanks!

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161129/4bf1a0c8/attachment.sig>

Maxime Ripard

2016-11-29 21:17 UTC #7 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Hi Tom,

Quoted 69 lines · Tom Rini

Quoted 68 lines · Maxime Ripard
Quoted 67 lines · Hans de Goede
HI,
Quoted 55 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Quoted 4 lines
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Moving that option to drivers/block would make more sense I guess.
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
Anyways either way is fine with me.
I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.
We also don't want to get hung up on fixing sub-optional solutions while also converting to Kconfig. We can move the option now and see about re-naming or getting the information elsewhere afterwards. Thanks!

I'm not sure I got what you wanted. Do you want it to be merged in drivers/block as a generic option, or in board/sunxi as a platform-specific one?

Thanks,
Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161129/8d6ac9ba/attachment.sig>

Tom Rini

2016-11-29 22:25 UTC #8 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 77 lines · Maxime Ripard

Hi Tom,
Quoted 74 lines · Tom Rini
Quoted 72 lines · Maxime Ripard
Quoted 61 lines · Hans de Goede
HI,
Quoted 58 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Quoted 7 lines
Quoted 1 line
Moving that option to drivers/block would make more sense I guess.
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.
Anyways either way is fine with me.
I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.

Quoted 7 lines

Quoted 3 lines
We also don't want to get hung up on fixing sub-optional solutions while also converting to Kconfig. We can move the option now and see about re-naming or getting the information elsewhere afterwards. Thanks!
I'm not sure I got what you wanted. Do you want it to be merged in drivers/block as a generic option, or in board/sunxi as a platform-specific one?

I'm fine with either place. Today it's used just on sunxi as a config option with that name, so board/sunxi/Kconfig and make a note to investigate how all of the other platforms that have this issue handle it. For example, my gut (based on some other imx6 stuff I've been doing) is that on imx6 they just fiddle the GPIO and not have it in Kconfig because rather than 1 board.c and N defconfig files they have (roughly) N board.c files and N defconfigs.

Signature · 8 lines

Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161129/1f54b5ef/attachment.sig>

Jelle van der Waa

author

2016-12-05 20:43 UTC #9 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 86 lines · Tom Rini

Quoted 77 lines · Maxime Ripard
Hi Tom,
Quoted 74 lines · Tom Rini
Quoted 72 lines · Maxime Ripard
Quoted 61 lines · Hans de Goede
HI,
Quoted 58 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Quoted 7 lines
Quoted 1 line
Moving that option to drivers/block would make more sense I guess.
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.
Anyways either way is fine with me.
I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.
Quoted 7 lines
Quoted 3 lines
We also don't want to get hung up on fixing sub-optional solutions while also converting to Kconfig. We can move the option now and see about re-naming or getting the information elsewhere afterwards. Thanks!
I'm not sure I got what you wanted. Do you want it to be merged in drivers/block as a generic option, or in board/sunxi as a platform-specific one?

Quoted 7 lines

I'm fine with either place. Today it's used just on sunxi as a config option with that name, so board/sunxi/Kconfig and make a note to investigate how all of the other platforms that have this issue handle it. For example, my gut (based on some other imx6 stuff I've been doing) is that on imx6 they just fiddle the GPIO and not have it in Kconfig because rather than 1 board.c and N defconfig files they have (roughly) N board.c files and N defconfigs.

Maxime, what do you prefer?

I later also want to move the following options from CONFIG_SYS_EXTRA_OPTIONS. (haven't done so since those patches will conflict)

* SUNXI_GMAC

Should go to board/sunxi/Kconfig, I assume. The drivers is there too.

* RGMII

This is an interesting one, also used in drivers/net/macb.c and it seems selected for sama5d3xek by a #define. Not sure what to do here

* MACPWR=SUNXI_GPH(23)

Same issue as above, this patch :)

Signature · 8 lines

Jelle van der Waa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/7883c627/attachment.sig>

Maxime Ripard

2016-12-09 07:28 UTC #10 lore raw

PATCH 1/1 sunxi: move CONFIG_SATAPWR to Kconfig option

Quoted 105 lines · Jelle van der Waa

Quoted 86 lines · Tom Rini
Quoted 77 lines · Maxime Ripard
Hi Tom,
Quoted 74 lines · Tom Rini
Quoted 72 lines · Maxime Ripard
Quoted 61 lines · Hans de Goede
HI,
Quoted 58 lines · Maxime Ripard
Hi Hans,
Quoted 46 lines · Hans de Goede
Hi,
Quoted 32 lines · Maxime Ripard
Quoted 31 lines · Jelle van der Waa
Introduce a new CONFIG_SATAPWR Kconfig option to replace the option in CONFIG_SYS_EXTRA_OPTIONS.
Signed-off-by Jelle van der Waa <[email protected]>
---
 board/sunxi/Kconfig                        |  7 +++++++
 board/sunxi/board.c                        | 11 ++++++-----
 configs/A10-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino-Lime2_defconfig      |  3 ++-
 configs/A20-OLinuXino-Lime_defconfig       |  3 ++-
 configs/A20-OLinuXino_MICRO_defconfig      |  3 ++-
 configs/A20-Olimex-SOM-EVB_defconfig       |  3 ++-
 configs/Cubieboard2_defconfig              |  3 ++-
 configs/Cubieboard_defconfig               |  3 ++-
 configs/Cubietruck_defconfig               |  3 ++-
 configs/Itead_Ibox_A20_defconfig           |  3 ++-
 configs/Lamobo_R1_defconfig                |  3 ++-
 configs/Linksprite_pcDuino3_Nano_defconfig |  3 ++-
 configs/Linksprite_pcDuino3_defconfig      |  3 ++-
 configs/Sinovoip_BPI_M3_defconfig          |  2 +-
 configs/orangepi_plus_defconfig            |  3 ++-
 16 files changed, 40 insertions(+), 19 deletions(-)
board/sunxi/Kconfig +0 -0
index ae2fba1..fe2f7b4 100644
@@ -667,6 +667,13 @@ config GMAC_TX_DELAY
 	---help---
 	Set the GMAC Transmit Clock Delay Chain value.
 
Quoted 10 lines
board/sunxi/Kconfig config GMAC_TX_DELAY · line 676
Quoted 7 lines
board/sunxi/Kconfig +7 -0
+config SATAPWR
+	string "power pin for SATA"
+	default ""
+	---help---
+	Set the power pin for SATA. This takes a string in the format
+	understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H.
+
This looks like a rather generic option. Can't this be in drivers/block instead?
Quoted 5 lines
The proper solution would be to get the info from devicetree, which requires regulator support, which we don't have yet for sunxi. In the mean time getting rid of the need for CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific.
Quoted 7 lines
Quoted 1 line
Moving that option to drivers/block would make more sense I guess.
Hmm, but in the end this should be removed, as everything should' be using devicetree, so I'm not convinced it is a good idea to introduce a generic option for this.
Anyways either way is fine with me.
I don't know, in the end, not all platforms will be converted to device tree, so it still might be something worth adding.
Quoted 7 lines
Quoted 3 lines
We also don't want to get hung up on fixing sub-optional solutions while also converting to Kconfig. We can move the option now and see about re-naming or getting the information elsewhere afterwards. Thanks!
I'm not sure I got what you wanted. Do you want it to be merged in drivers/block as a generic option, or in board/sunxi as a platform-specific one?
Quoted 7 lines
I'm fine with either place. Today it's used just on sunxi as a config option with that name, so board/sunxi/Kconfig and make a note to investigate how all of the other platforms that have this issue handle it. For example, my gut (based on some other imx6 stuff I've been doing) is that on imx6 they just fiddle the GPIO and not have it in Kconfig because rather than 1 board.c and N defconfig files they have (roughly) N board.c files and N defconfigs.
Maxime, what do you prefer?
I later also want to move the following options from CONFIG_SYS_EXTRA_OPTIONS. (haven't done so since those patches will conflict)
* SUNXI_GMAC
Should go to board/sunxi/Kconfig, I assume. The drivers is there too.

Quoted 8 lines

* RGMII
This is an interesting one, also used in drivers/net/macb.c and it seems selected for sama5d3xek by a #define. Not sure what to do here
* MACPWR=SUNXI_GPH(23)
Same issue as above, this patch :)

We can do it as Tom suggested for now. Put it in board/sunxi with a comment that we should look into merging that with other architectures>

Maxime

Signature · 10 lines

Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161209/e524a7f0/attachment.sig>