Skip to contentSkip to conversation

arm64: Add CMDLINE_EXTEND

PATCH New Geoff Levand 3 participants 6 messages Dec 2, 2016 – Dec 6, 2016 arm64

lore
Share & tools
lore

Geoff Levand

author
#0 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

Signed-off-by Geoff Levand <[email protected]>
---
 arch/arm64/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)
arch/arm64/Kconfig +6 -0
index 969ef88..51f7545 100644
@@ -949,6 +949,12 @@ config CMDLINE
 	  entering them here. As a minimum, you should specify the the
 	  root device (e.g. root=/dev/nfs).
 
+config CMDLINE_EXTEND
+	bool "Extend bootloader kernel arguments"
+	help
+	  The command-line arguments provided by the boot loader will be
+	  appended to the default kernel command string.
+
 config CMDLINE_FORCE
 	bool "Always use the default kernel command string"
 	help
Signature · 1 line
2.9.3
maintainer
#1 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

Hi Geoff,

Quoted 2 lines · Geoff Levand

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

What's your use-case for this patch? Note that both CMDLINE_FORCE and CMDLINE_EXTEND (if we introduce it) are ignored by the EFI stub. However, we don't seem to have stated this anywhere.

Signature · 1 line
Catalin
author
#2 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

Hi Catalin,

Quoted 7 lines · Catalin Marinas
Quoted 2 lines · Geoff Levand

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

What's your use-case for this patch? Note that both CMDLINE_FORCE and CMDLINE_EXTEND (if we introduce it) are ignored by the EFI stub. However, we don't seem to have stated this anywhere.

I use this in CoreOS, where we need to set "acpi=force" for arm64. CoreOS uses a proper UEFI + grub.

See:

https://github.com/coreos/scripts/pull/610
https://github.com/coreos/coreos-overlay/pull/2298

I can add a comment for EFI stub, either in the Kconfig options, and/or in Documentation/efi-stub.txt. Just let me know.

-Geoff

#3 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

Quoted 11 lines · Geoff Levand
Quoted 7 lines · Catalin Marinas
Quoted 2 lines · Geoff Levand

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

What's your use-case for this patch? Note that both CMDLINE_FORCE and CMDLINE_EXTEND (if we introduce it) are ignored by the EFI stub. However, we don't seem to have stated this anywhere.

I use this in CoreOS, where we need to set "acpi=force" for arm64. CoreOS uses a proper UEFI + grub.

So why can't you just set that in grub if you want to boot with ACPI?

Will

author
#4 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

Hi Will,

Quoted 6 lines · Will Deacon
Quoted 5 lines · Geoff Levand
Quoted 4 lines · Catalin Marinas
Quoted 2 lines · Geoff Levand

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

What's your use-case for this patch? Note that both CMDLINE_FORCE and CMDLINE_EXTEND (if we introduce it) are ignored by the EFI stub. However, we don't seem to have stated this anywhere.

I use this in CoreOS, where we need to set "acpi=force" for arm64. CoreOS uses a proper UEFI + grub.

So why can't you just set that in grub if you want to boot with ACPI?

That is how I originally did it, but it was suggested I do it in the kernel config. See:

https://github.com/coreos/scripts/pull/610

Is there any reason why we don't want arm64 to have CMDLINE_EXTEND?

-Geoff

#5 lore raw

PATCH 1/1 arm64: Add CMDLINE_EXTEND

Quoted 16 lines · Geoff Levand
Quoted 6 lines · Will Deacon
Quoted 5 lines · Geoff Levand
Quoted 4 lines · Catalin Marinas
Quoted 2 lines · Geoff Levand

The device tree code already supports CMDLINE_EXTEND, so add the config option to make it available on arm64.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

What's your use-case for this patch? Note that both CMDLINE_FORCE and CMDLINE_EXTEND (if we introduce it) are ignored by the EFI stub. However, we don't seem to have stated this anywhere.

I use this in CoreOS, where we need to set "acpi=force" for arm64. CoreOS uses a proper UEFI + grub.

So why can't you just set that in grub if you want to boot with ACPI?

Quoted 7 lines

That is how I originally did it, but it was suggested I do it in the kernel config. See:

https://github.com/coreos/scripts/pull/610

Is there any reason why we don't want arm64 to have CMDLINE_EXTEND?

I'm yet to see a good use-case for it.

Will