Skip to contentSkip to conversation

perf tools: Explicitly document that --children is enabled by default

PATCH Applied Yannick Brosseau 3 participants 3 messages Dec 2, 2016 – Dec 7, 2016 perf events

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 perf tools: Explicitly document that --children is enabled by default

The fact that the --children option is enabled by default is buried deep at the end of the help page, in the overhead calculation section. This make it explicit right where the option is listed, following the same way other default options are described

---
 tools/perf/Documentation/perf-report.txt | 3 ++-
 tools/perf/Documentation/perf-top.txt    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-report.txt +2 -1
index 2d17462..aaa8011 100644
@@ -239,7 +239,8 @@ OPTIONS
 	Accumulate callchain of children to parent entry so that then can
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires callchains are recorded.
-	See the `overhead calculation' section for more details.
+	See the `overhead calculation' section for more details. Enabled by
+	default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
tools/perf/Documentation/perf-top.txt +1 -0
index 91d638d..e71d638 100644
@@ -170,6 +170,7 @@ Default is to monitor all CPUS.
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires -g/--call-graph option
 	enabled.  See the `overhead calculation' section for more details.
+	Enabled by default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
Signature · 1 line
2.10.2
maintainer Applied
#1 lore raw

Em Fri, Dec 02, 2016 at 11:07:32AM -0500, Yannick Brosseau escreveu:

Quoted 4 lines

The fact that the --children option is enabled by default is buried deep at the end of the help page, in the overhead calculation section. This make it explicit right where the option is listed, following the same way other default options are described

Thanks, applied.

- Arnaldo

Quoted 34 lines
---
 tools/perf/Documentation/perf-report.txt | 3 ++-
 tools/perf/Documentation/perf-top.txt    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-report.txt +2 -1
index 2d17462..aaa8011 100644
@@ -239,7 +239,8 @@ OPTIONS
 	Accumulate callchain of children to parent entry so that then can
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires callchains are recorded.
-	See the `overhead calculation' section for more details.
+	See the `overhead calculation' section for more details. Enabled by
+	default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
tools/perf/Documentation/perf-top.txt +1 -0
index 91d638d..e71d638 100644
@@ -170,6 +170,7 @@ Default is to monitor all CPUS.
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires -g/--call-graph option
 	enabled.  See the `overhead calculation' section for more details.
+	Enabled by default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
Signature · 1 line
2.10.2
#2 lore raw
In reply to Yannick Brosseau
perf tools: Explicitly document that --children is enabled by default
Commit-ID:  108a7c103b761309ccbd997002e8428808cf1e04
Gitweb:     http://git.kernel.org/tip/108a7c103b761309ccbd997002e8428808cf1e04
Author:     Yannick Brosseau <[email protected]>
AuthorDate: Fri, 2 Dec 2016 11:07:32 -0500
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 7 Dec 2016 12:00:35 -0300

perf tools: Explicitly document that --children is enabled by default

The fact that the --children option is enabled by default is buried deep at the end of the help page, in the overhead calculation section. This make it explicit right where the option is listed, following the same way other default options are described

---
 tools/perf/Documentation/perf-report.txt | 3 ++-
 tools/perf/Documentation/perf-top.txt    | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
tools/perf/Documentation/perf-report.txt +2 -1
index 3a166ae..f2914f0 100644
@@ -239,7 +239,8 @@ OPTIONS
 	Accumulate callchain of children to parent entry so that then can
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires callchains are recorded.
-	See the `overhead calculation' section for more details.
+	See the `overhead calculation' section for more details. Enabled by
+	default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything
tools/perf/Documentation/perf-top.txt +1 -0
index 91d638d..e71d638 100644
@@ -170,6 +170,7 @@ Default is to monitor all CPUS.
 	show up in the output.  The output will have a new "Children" column
 	and will be sorted on the data.  It requires -g/--call-graph option
 	enabled.  See the `overhead calculation' section for more details.
+	Enabled by default, disable with --no-children.
 
 --max-stack::
 	Set the stack depth limit when parsing the callchain, anything