pkg-autotools: search in the source directory for ltmain.sh
PATCH 1/1 pkg-autotools: search in the source directory for ltmain.sh
Fixes static linking of berkeleydb package, where ltmain.sh is not in the sub-directory that contains configure. Always search the complete source directory.
Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
--- package/pkg-autotools.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-autotools.mk +1 -1
@@ -59,7 +59,7 @@ endef # define LIBTOOL_PATCH_HOOK @$(call MESSAGE,"Patching libtool") - $(Q)for i in `find $($(PKG)_SRCDIR) -name ltmain.sh`; do \ + $(Q)for i in `find $($(PKG)_DIR) -name ltmain.sh`; do \ ltmain_version=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \ sed -e 's/\([0-9]*\.[0-9]*\).*/\1/' -e 's/\"//'`; \ ltmain_patchlevel=`sed -n '/^[ \t]*VERSION=/{s/^[ \t]*VERSION=//;p;q;}' $$i | \
Signature · 1 line
2.1.4
PATCH 1/1 pkg-autotools: search in the source directory for ltmain.sh
Hello,
Quoted 8 lines · Waldemar Brodkorb
Fixes static linking of berkeleydb package, where
ltmain.shis not in the sub-directory that contains configure. Always search the complete source directory.Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7daSigned-off-by Thomas Petazzoni <[email protected]>
It should be your SoB here, since you appear as the author of this patch, unless you "git format --amend --author=...".
Quoted 1 line
Tested-by Waldema Brodkorb <[email protected]>
Your first name has changed? :-)
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 pkg-autotools: search in the source directory for ltmain.sh
Hi,
Thomas Petazzoni wrote,
Quoted 7 lines
Hello,
Quoted 4 lines · Waldemar Brodkorb
Fixes static linking of berkeleydb package, where
ltmain.shis not in the sub-directory that contains configure. Always search the complete source directory.
Quoted 7 lines
Quoted 4 lines
Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7daSigned-off-by Thomas Petazzoni <[email protected]>It should be your SoB here, since you appear as the author of this patch, unless you "git format --amend --author=...".
So should I resend with my SoB and mention you in the log or what is the correct way in this case, because the analysis was made by me and the patch by you. I really don't care ;)
Quoted 3 lines
Quoted 1 line
Tested-by Waldema Brodkorb <[email protected]>Your first name has changed? :-)
I thought it might be good idea to have a shorter name ;)
Don't sent patches before first coffee ;)
best regards
Waldemar
PATCH 1/1 pkg-autotools: search in the source directory for ltmain.sh
Hello,
Quoted 8 lines · Waldemar Brodkorb
Quoted 8 lines · Waldemar Brodkorb
Quoted 7 lines
Fixes static linking of berkeleydb package, where
ltmain.shis not in the sub-directory that contains configure. Always search the complete source directory.Fixes:
http://autobuild.buildroot.net/results/f0a96f671644d9f9efcf245b354affdc84f7d7da
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Thomas Petazzoni <[email protected]>It should be your SoB here, since you appear as the author of this patch, unless you "git format --amend --author=...".
So should I resend with my SoB and mention you in the log or what is the correct way in this case, because the analysis was made by me and the patch by you. I really don't care ;)
Actually, the change itself was proposed by Arnout, and I just tested it quickly.
Just put you as the author, I really don't care for such a simple change.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com