Skip to contentSkip to conversation

drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 7, 2016 – Dec 8, 2016

Subsystems (4)
Networking Network drivers Kernel janitors Applied micro (apm) x-gene SoC Ethernet driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

We never set "slots" in this function.

Fixes a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by Dan Carpenter <[email protected]>

---
I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. Not tested.

drivers/net/ethernet/apm/xgene/xgene_enet_main.c +1 -0
index 6c7eea8b36af..884a334e82d0 100644
@@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
 		return;
 
 	dev = ndev_to_dev(buf_pool->ndev);
+	slots = buf_pool->slots - 1;
 	head = buf_pool->head;
 
 	for (i = 0; i < 4; i++) {
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Dan Carpenter

We never set "slots" in this function.

Fixes a9380b0f7be8 ("drivers: net: xgene: Add support for Jumbo frame")
Signed-off-by Dan Carpenter <[email protected]>

---
I copied how slots gets set in xgene_enet_rx_frame(). Static analysis. Not tested.

drivers/net/ethernet/apm/xgene/xgene_enet_main.c +0 -0
index 6c7eea8b36af..884a334e82d0 100644

drivers/net/ethernet/apm/xgene/xgene_enet_main.c static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool, · line 641

Quoted 7 lines
drivers/net/ethernet/apm/xgene/xgene_enet_main.c +1 -0
@@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct xgene_enet_desc_ring *buf_pool,
                return;
 
        dev = ndev_to_dev(buf_pool->ndev);
+       slots = buf_pool->slots - 1;
        head = buf_pool->head;
 
        for (i = 0; i < 4; i++) {

Thanks.

Acked-by Iyappan Subramanian <[email protected]>