Skip to contentSkip to conversation

Input: drv260x - fix initializing overdrive voltage

PATCH In review Dmitry Torokhov 2 participants 2 messages Dec 11, 2016 – Dec 12, 2016

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: drv260x - fix initializing overdrive voltage

We were accidentally initializing haptics->rated_voltage twice, and did not initialize overdrive voltage.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/input/misc/drv260x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/drv260x.c +1 -1
index 2adfd86c..9789d4f 100644
@@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client,
 	if (!haptics)
 		return -ENOMEM;
 
-	haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
+	haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
 	haptics->rated_voltage = DRV260X_DEF_RATED_VOLT;
 
 	if (pdata) {
Signature · 5 lines
2.8.0.rc3.226.g39d4020


-- 
Dmitry
Acked-by on v1 1/1
#1 lore raw

Dmitry

Quoted 13 lines · Dmitry Torokhov

We were accidentally initializing haptics->rated_voltage twice, and did not initialize overdrive voltage.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/input/misc/drv260x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/misc/drv260x.c +0 -0
index 2adfd86c..9789d4f 100644

drivers/input/misc/drv260x.c static int drv260x_probe(struct i2c_client *client, · line 527

Quoted 8 lines
drivers/input/misc/drv260x.c +1 -1
@@ -521,7 +521,7 @@ static int drv260x_probe(struct i2c_client *client,
 	if (!haptics)
 		return -ENOMEM;
 
-	haptics->rated_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
+	haptics->overdrive_voltage = DRV260X_DEF_OD_CLAMP_VOLT;
 	haptics->rated_voltage = DRV260X_DEF_RATED_VOLT;
 
 	if (pdata) {

Thanks for the fix

Acked-by Dan Murphy <[email protected]>
Signature · 2 lines
------------------
Dan Murphy