Skip to contentSkip to conversation

madplay: workaround not needed anymore

PATCH New Waldemar Brodkorb 2 participants 3 messages Dec 11, 2016 – Feb 20, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 madplay: workaround not needed anymore

The patches for uClibc-ng are upstream and added to buildroot.

---
 package/madplay/madplay.mk | 8 --------
 1 file changed, 8 deletions(-)
package/madplay/madplay.mk +0 -8
index 6b13819..2606ac8 100644
@@ -11,14 +11,6 @@ MADPLAY_LICENSE_FILES = COPYING COPYRIGHT
 MADPLAY_LIBTOOL_PATCH = NO
 MADPLAY_DEPENDENCIES = libmad libid3tag $(if $(BR2_PACKAGE_GETTEXT),gettext)
 
-# Workaround a bug in uClibc-ng, which exposes madvise() but doesn't
-# provide the corresponding MADV_* definitions. Bug reported at
-# http://mailman.uclibc-ng.org/pipermail/devel/2016-December/001306.html. madvise()
-# is anyway useless on noMMU.
-ifeq ($(BR2_USE_MMU),)
-MADPLAY_CONF_ENV += ac_cv_func_madvise=no
-endif
-
 # Check if ALSA is built, then we should configure after alsa-lib so
 # ./configure can find alsa-lib.
 ifeq ($(BR2_PACKAGE_MADPLAY_ALSA),y)
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 madplay: workaround not needed anymore

Hello,

Quoted 6 lines · Waldemar Brodkorb

The patches for uClibc-ng are upstream and added to buildroot.

---
 package/madplay/madplay.mk | 8 --------
 1 file changed, 8 deletions(-)

Thanks. However I'll hold off on applying this one until a new uClibc-ng version is released, and we have rebuilt the pre-built toolchains used in the autobuilders with this new uClibc-ng version.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 madplay: workaround not needed anymore

In reply to Waldemar Brodkorb

Hello,

Quoted 6 lines · Waldemar Brodkorb

The patches for uClibc-ng are upstream and added to buildroot.

---
 package/madplay/madplay.mk | 8 --------
 1 file changed, 8 deletions(-)

Applied to next, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com