Skip to contentSkip to conversation

davinci: omapl138_lcdk: fix unreliable NAND accesses

PATCH New Fabien Parent 2 participants 7 messages Dec 5, 2016 – Dec 12, 2016

lore
Share & tools
lore

Fabien Parent

author
#0 lore raw

cover davinci: omapl138_lcdk: fix unreliable NAND accesses

A couple of issue made the NAND accesses unreliable. This patchset aims to fix all the NAND issues with the OMAP-L138-LCDK.

Fabien Parent (2):
davinci: omapl138_lcdk: increase u-boot load size
davinci: omapl138_lcdk: fix bad NAND ECC config

 include/configs/omapl138_lcdk.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/2 davinci: omapl138_lcdk: increase u-boot load size

A size of 0x200 seems way too short for u-boot. Increase the size to 512k.

Signed-off-by Fabien Parent <[email protected]>
---
 include/configs/omapl138_lcdk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/omapl138_lcdk.h +1 -1
index 9e11f7dc95..2101086d59 100644
@@ -176,7 +176,7 @@
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_SIZE	(2 << 10)
 #define CONFIG_SYS_NAND_BLOCK_SIZE	(128 << 10)
-#define CONFIG_SYS_NAND_U_BOOT_SIZE	0x200 /*0x60000*/
+#define CONFIG_SYS_NAND_U_BOOT_SIZE	SZ_512K
 #define CONFIG_SYS_NAND_U_BOOT_DST	0xc1080000
 #define CONFIG_SYS_NAND_U_BOOT_START	CONFIG_SYS_NAND_U_BOOT_DST
 #define CONFIG_SYS_NAND_U_BOOT_RELOC_SP	(CONFIG_SYS_NAND_U_BOOT_DST - \
Signature · 1 line
2.11.0
#2 lore raw

PATCH 1/2 davinci: omapl138_lcdk: increase u-boot load size

Quoted 4 lines · Fabien Parent

A size of 0x200 seems way too short for u-boot. Increase the size to 512k.

Signed-off-by Fabien Parent <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/26ca0516/attachment.sig>
#3 lore raw

PATCH 1/2 davinci: omapl138_lcdk: increase u-boot load size

In reply to Fabien Parent
Quoted 5 lines · Fabien Parent

A size of 0x200 seems way too short for u-boot. Increase the size to 512k.

Signed-off-by Fabien Parent <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161212/a3fb0d46/attachment.sig>
author
#4 lore raw

PATCH 2/2 davinci: omapl138_lcdk: fix bad NAND ECC config

In reply to Fabien Parent

The configuration used to error correction was not in line with what linux and the ROM code is using. Fix it by using the correct configuration. Now u-boot and the SPL are able to read correctly anything written by them.

Signed-off-by Fabien Parent <[email protected]>
---
 include/configs/omapl138_lcdk.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
include/configs/omapl138_lcdk.h +5 -5
index 2101086d59..a1e5f4481f 100644
@@ -173,6 +173,7 @@
 #undef CONFIG_SYS_NAND_HW_ECC
 #define CONFIG_SYS_MAX_NAND_DEVICE	1 /* Max number of NAND devices */
 #define CONFIG_SYS_NAND_HW_ECC_OOBFIRST
+#define CONFIG_NAND_6BYTES_OOB_FREE_10BYTES_ECC
 #define CONFIG_SYS_NAND_5_ADDR_CYCLE
 #define CONFIG_SYS_NAND_PAGE_SIZE	(2 << 10)
 #define CONFIG_SYS_NAND_BLOCK_SIZE	(128 << 10)

@@ -184,11 +185,10 @@
 					CONFIG_SYS_MALLOC_LEN -       \
 					GENERATED_GBL_DATA_SIZE)
 #define CONFIG_SYS_NAND_ECCPOS		{				\
-				24, 25, 26, 27, 28, \
-				29, 30, 31, 32, 33, 34, 35, 36, 37, 38, \
-				39, 40, 41, 42, 43, 44, 45, 46, 47, 48, \
-				49, 50, 51, 52, 53, 54, 55, 56, 57, 58, \
-				59, 60, 61, 62, 63 }
+				6, 7, 8, 9, 10, 11, 12, 13, 14, 15,	\
+				22, 23, 24, 25, 26, 27, 28, 29, 30, 31, \
+				38, 39, 40, 41, 42, 43, 44, 45, 46, 47, \
+				54, 55, 56, 57, 58, 59, 60, 61, 62, 63 }
 #define CONFIG_SYS_NAND_PAGE_COUNT	64
 #define CONFIG_SYS_NAND_BAD_BLOCK_POS	0
 #define CONFIG_SYS_NAND_ECCSIZE		512
Signature · 1 line
2.11.0
#5 lore raw

PATCH 2/2 davinci: omapl138_lcdk: fix bad NAND ECC config

Quoted 6 lines · Fabien Parent

The configuration used to error correction was not in line with what linux and the ROM code is using. Fix it by using the correct configuration. Now u-boot and the SPL are able to read correctly anything written by them.

Signed-off-by Fabien Parent <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161205/9bd40302/attachment.sig>
#6 lore raw

PATCH 2/2 davinci: omapl138_lcdk: fix bad NAND ECC config

In reply to Fabien Parent
Quoted 7 lines · Fabien Parent

The configuration used to error correction was not in line with what linux and the ROM code is using. Fix it by using the correct configuration. Now u-boot and the SPL are able to read correctly anything written by them.

Signed-off-by Fabien Parent <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161212/e3d399e0/attachment.sig>