HID: usbhid: fix more Mayflash adapters (HID_QUIRK_MULTI_INPUT)

PATCH In review Dmitry Torokhov 4 participants 6 messages Dec 13, 2016 – Dec 20, 2016 1 message not in the archive

Subsystems (2)

HID USB HID/hidbp drivers (USB keyboards, mice, remote controls, ...)

lore

Share & tools

lore

Dmitry Torokhov

author

2016-12-13 00:23 UTC #0 lore raw

PATCH 1/1 HID: usbhid: fix more Mayflash adapters (HID_QUIRK_MULTI_INPUT)

From: Andrew Rodland <[email protected]>

Add "Mayflash GameCube Controller Adapter for Wii U and PC USB" and "Mayflash PS3 Game Controller Adapter" to the list of devices needing HID_QUIRK_MULTI_INPUT. These devices have 4 controller ports, and without the quirk they all become one very large joystock device. With the quirk they're recognized as 4 separate joysticks.

Signed-off-by Andrew Rodland <[email protected]>

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=115841
[dtor: picked up Andrew's patch, added the PS3 controller data from
bugzilla info]

Signed-off-by Dmitry Torokhov <[email protected]>

---
 drivers/hid/hid-ids.h           | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 2 ++
 2 files changed, 4 insertions(+)

drivers/hid/hid-ids.h +2 -0

index 575aa65..63824f1 100644
@@ -317,6 +317,8 @@
 
 #define USB_VENDOR_ID_DRAGONRISE	0x0079
 #define USB_DEVICE_ID_DRAGONRISE_WIIU	0x1800
+#define USB_DEVICE_ID_DRAGONRISE_PS3	0x1801
+#define USB_DEVICE_ID_DRAGONRISE_GAMECUBE	0x1843
 
 #define USB_VENDOR_ID_DWAV		0x0eef
 #define USB_DEVICE_ID_EGALAX_TOUCHCONTROLLER	0x0001

drivers/hid/usbhid/hid-quirks.c +2 -0

index e6cfd32..6f8736a 100644
@@ -81,6 +81,8 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_CORSAIR, USB_DEVICE_ID_CORSAIR_STRAFE, HID_QUIRK_NO_INIT_REPORTS | HID_QUIRK_ALWAYS_POLL },
 	{ USB_VENDOR_ID_CREATIVELABS, USB_DEVICE_ID_CREATIVE_SB_OMNI_SURROUND_51, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_GAMECUBE, HID_QUIRK_MULTI_INPUT },
+	{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_PS3, HID_QUIRK_MULTI_INPUT },
 	{ USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_WIIU, HID_QUIRK_MULTI_INPUT },
 	{ USB_VENDOR_ID_ELAN, HID_ANY_ID, HID_QUIRK_ALWAYS_POLL },
 	{ USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },

Signature · 5 lines

2.8.0.rc3.226.g39d4020


-- 
Dmitry

Benjamin Tissoires

Reviewed-by on v1 1/1

2016-12-13 08:05 UTC #1 lore raw

Quoted 8 lines · Dmitry Torokhov

From: Andrew Rodland <[email protected]>
Add "Mayflash GameCube Controller Adapter for Wii U and PC USB" and "Mayflash PS3 Game Controller Adapter" to the list of devices needing HID_QUIRK_MULTI_INPUT. These devices have 4 controller ports, and without the quirk they all become one very large joystock device. With the quirk they're recognized as 4 separate joysticks.

Quoted 6 lines

Signed-off-by Andrew Rodland <[email protected]>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=115841
[dtor: picked up Andrew's patch, added the PS3 controller data from
bugzilla info]
Signed-off-by Dmitry Torokhov <[email protected]>
---

Reviewed-by Benjamin Tissoires <[email protected]>

Cheers,
Benjamin

Jiri Kosina

maintainer

2016-12-19 10:19 UTC #2 lore raw

In reply to Dmitry Torokhov

Quoted 8 lines · Dmitry Torokhov

From: Andrew Rodland <[email protected]>
Add "Mayflash GameCube Controller Adapter for Wii U and PC USB" and "Mayflash PS3 Game Controller Adapter" to the list of devices needing HID_QUIRK_MULTI_INPUT. These devices have 4 controller ports, and without the quirk they all become one very large joystock device. With the quirk they're recognized as 4 separate joysticks.

Quoted 5 lines

Signed-off-by Andrew Rodland <[email protected]>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=115841
[dtor: picked up Andrew's patch, added the PS3 controller data from
bugzilla info]
Signed-off-by Dmitry Torokhov <[email protected]>

This is already in as b2554000f5b ("HID: usbhid: Add quirks for Mayflash/Dragonrise GameCube and PS3 adapters").

Thanks,

Signature · 2 lines

Jiri Kosina
SUSE Labs

Marcel Hasler

2016-12-19 10:29 UTC #3 lore raw

Hello

2016-12-19 11:19 GMT+01:00 Jiri Kosina <[email protected]>:

Quoted 16 lines · Dmitry Torokhov

Quoted 9 lines
From: Andrew Rodland <[email protected]>
Add "Mayflash GameCube Controller Adapter for Wii U and PC USB" and "Mayflash PS3 Game Controller Adapter" to the list of devices needing HID_QUIRK_MULTI_INPUT. These devices have 4 controller ports, and without the quirk they all become one very large joystock device. With the quirk they're recognized as 4 separate joysticks.
Quoted 5 lines
Signed-off-by Andrew Rodland <[email protected]>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=115841
[dtor: picked up Andrew's patch, added the PS3 controller data from
bugzilla info]
Signed-off-by Dmitry Torokhov <[email protected]>

Quoted 9 lines

This is already in as b2554000f5b ("HID: usbhid: Add quirks for Mayflash/Dragonrise GameCube and PS3 adapters").
Thanks,
--
Jiri Kosina
SUSE Labs

What maybe still should be added, is the "Mayflash Dolphin-bar" (PID 0x1803, see the Bugzilla entry mentioned above).

Best regards
Marcel

2016-12-19 11:19 GMT+01:00 Jiri Kosina <[email protected]>:

Quoted 25 lines · Dmitry Torokhov

Quoted 9 lines
From: Andrew Rodland <[email protected]>
Add "Mayflash GameCube Controller Adapter for Wii U and PC USB" and "Mayflash PS3 Game Controller Adapter" to the list of devices needing HID_QUIRK_MULTI_INPUT. These devices have 4 controller ports, and without the quirk they all become one very large joystock device. With the quirk they're recognized as 4 separate joysticks.
Quoted 5 lines
Signed-off-by Andrew Rodland <[email protected]>
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=115841
[dtor: picked up Andrew's patch, added the PS3 controller data from
bugzilla info]
Signed-off-by Dmitry Torokhov <[email protected]>
This is already in as b2554000f5b ("HID: usbhid: Add quirks for Mayflash/Dragonrise GameCube and PS3 adapters").
Thanks,
--
Jiri Kosina
SUSE Labs

A message that is not in the archive (sent off-list or not yet received): CAGNp=Nxi7-_dKar3SOUUvGksxQvuy0AfzqtM8Szpq9P7deEwZw@mail.gmail.com

Jiri Kosina

maintainer

2016-12-19 10:38 UTC #5 lore raw

Quoted 2 lines · Marcel Hasler

What maybe still should be added, is the "Mayflash Dolphin-bar" (PID 0x1803, see the Bugzilla entry mentioned above).

Quoted 7 lines · Robert de Rooy

Thanks for this,
Any chance we can also get the same quirk added for the Mayflash Dolphinbar? It has four different operating modes, when set to "mode 3", it emulates 4 PC USB joysticks and has the same problem and needs the HID_QUIRK_MULTI_INPUT.

Quoted 7 lines

When set to mode 3, the USB id is: 0079:1803
I tested it locally by booting with usbhid.quirks=0x79:0x1803:0x40
Regarding the other modes, mode 1 and 2 already work as it just emulates a USB keyboard/mouse. mode 4 is special, and supposedly now works with the latest versions of the Dolphin emulator for Linux.

Could either of you please submit a proper patch on top of b255400, so that I could queue it?

Thanks,

Signature · 2 lines

Jiri Kosina
SUSE Labs

Marcel Hasler

2016-12-20 21:22 UTC #6 lore raw

2016-12-19 11:38 GMT+01:00 Jiri Kosina <[email protected]>:

Quoted 22 lines · Marcel Hasler

Quoted 3 lines
What maybe still should be added, is the "Mayflash Dolphin-bar" (PID 0x1803, see the Bugzilla entry mentioned above).
Quoted 7 lines · Robert de Rooy
Thanks for this,
Any chance we can also get the same quirk added for the Mayflash Dolphinbar? It has four different operating modes, when set to "mode 3", it emulates 4 PC USB joysticks and has the same problem and needs the HID_QUIRK_MULTI_INPUT.
Quoted 7 lines
When set to mode 3, the USB id is: 0079:1803
I tested it locally by booting with usbhid.quirks=0x79:0x1803:0x40
Regarding the other modes, mode 1 and 2 already work as it just emulates a USB keyboard/mouse. mode 4 is special, and supposedly now works with the latest versions of the Dolphin emulator for Linux.

Quoted 9 lines

Could either of you please submit a proper patch on top of b255400, so that I could queue it?
Thanks,
--
Jiri Kosina
SUSE Labs

I just submitted a patch against the latest git.

Best regards
Marcel