Skip to contentSkip to conversation

drm: mxsfb: drm_dev_alloc() returns error pointers

PATCH In review Dan Carpenter 3 participants 3 messages Dec 13, 2016

Subsystems (5)
DRM drivers DRM misc Arm i.MX and Layerscape Kernel janitors +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 drm: mxsfb: drm_dev_alloc() returns error pointers

We should be checking for IS_ERR() instead of NULL because drm_dev_alloc() returns error pointers.

Fixes 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/mxsfb/mxsfb_drv.c +2 -2
index 79a18bf48b54..955441f71500 100644
@@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
 		pdev->id_entry = of_id->data;
 
 	drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
-	if (!drm)
-		return -ENOMEM;
+	if (IS_ERR(drm))
+		return PTR_ERR(drm);
 
 	ret = mxsfb_load(drm, 0);
 	if (ret)
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dan Carpenter

We should be checking for IS_ERR() instead of NULL because drm_dev_alloc() returns error pointers.

Fixes 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by Dan Carpenter <[email protected]>

Thanks,

Reviewed-by Marek Vasut <[email protected]>
Quoted 16 lines
drivers/gpu/drm/mxsfb/mxsfb_drv.c +2 -2
index 79a18bf48b54..955441f71500 100644
@@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
 		pdev->id_entry = of_id->data;
 
 	drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
-	if (!drm)
-		return -ENOMEM;
+	if (IS_ERR(drm))
+		return PTR_ERR(drm);
 
 	ret = mxsfb_load(drm, 0);
 	if (ret)
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw
In reply to Dan Carpenter
Quoted 5 lines · Dan Carpenter

We should be checking for IS_ERR() instead of NULL because drm_dev_alloc() returns error pointers.

Fixes 45d59d704080 ("drm: Add new driver for MXSFB controller")
Signed-off-by Dan Carpenter <[email protected]>

Queued up in drm-misc for 4.11 (since drm_dev_alloc doesn't fail due to the small allocs guarantee anyway), will show up in linux-next as soon as -rc1 hits the door.

Thanks, Daniel

Quoted 20 lines
drivers/gpu/drm/mxsfb/mxsfb_drv.c +2 -2
index 79a18bf48b54..955441f71500 100644
@@ -395,8 +395,8 @@ static int mxsfb_probe(struct platform_device *pdev)
 		pdev->id_entry = of_id->data;
 
 	drm = drm_dev_alloc(&mxsfb_driver, &pdev->dev);
-	if (!drm)
-		return -ENOMEM;
+	if (IS_ERR(drm))
+		return PTR_ERR(drm);
 
 	ret = mxsfb_load(drm, 0);
 	if (ret)

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch