vxlan: fix unused variable warning
Subsystems (2)
PATCH 1/1 vxlan: fix unused variable warning
Fixes commit 4528520d315ac1 ("vxlan: add ipv6 proxy support") which added code that caused this warning:
drivers/net/vxlan.c: In function ‘neigh_reduce’:drivers/net/vxlan.c:1556:25: warning: variable ‘saddr’ set but not used
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/vxlan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/vxlan.c +1 -2
@@ -1553,7 +1553,7 @@ static int neigh_reduce(struct net_device *dev, struct sk_buff *skb)struct vxlan_dev *vxlan =netdev_priv (dev);struct nd_msg *msg;const struct ipv6hdr *iphdr; -const struct in6_addr *saddr, *daddr; +const struct in6_addr *daddr;struct neighbour *n;struct inet6_dev *in6_dev;
@@ -1562,7 +1562,6 @@ static int neigh_reduce(struct net_device *dev, struct sk_buff *skb) goto out; iphdr =ipv6_hdr (skb); - saddr = &iphdr->saddr; daddr = &iphdr->daddr; msg = (struct nd_msg *)skb_transport_header (skb);
Signature · 1 line
2.10.2
Quoted 1 line · Stephen Hemminger
Fixes commit
4528520d315ac1("vxlan: add ipv6 proxy support")
Wrong hash, it was commit f564f45c4518. And that commit actually did use saddr, the actual commit that is being fixed is 4b29dba9c085 ("vxlan: fix nonfunctional neigh_reduce()"). Also, please use the standard Fixes: line when resubmitting this.
The patch itself looks good.
Thanks,
Jiri