Skip to contentSkip to conversation

drivers: staging: comedi: fix function prototypes

PATCH In review Piotr Gregor 3 participants 6 messages Dec 14, 2016 – Dec 15, 2016 Staging

lore
Share & tools
lore

Piotr Gregor

author
#0 lore raw

PATCH 1/1 drivers: staging: comedi: fix function prototypes

Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors.

Signed-off-by Piotr Gregor <[email protected]>
---
 drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/staging/comedi/comedi_pci.h +10 -8
index 4005cc9..7dfd892 100644
@@ -34,18 +34,20 @@
 #define PCI_VENDOR_ID_RTD		0x1435
 #define PCI_VENDOR_ID_HUMUSOFT		0x186c
 
-struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
+struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);
 
-int comedi_pci_enable(struct comedi_device *);
-void comedi_pci_disable(struct comedi_device *);
-void comedi_pci_detach(struct comedi_device *);
+int comedi_pci_enable(struct comedi_device *dev);
+void comedi_pci_disable(struct comedi_device *dev);
+void comedi_pci_detach(struct comedi_device *dev);
 
-int comedi_pci_auto_config(struct pci_dev *, struct comedi_driver *,
+int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
 			   unsigned long context);
-void comedi_pci_auto_unconfig(struct pci_dev *);
+void comedi_pci_auto_unconfig(struct pci_dev *pcidev);
 
-int comedi_pci_driver_register(struct comedi_driver *, struct pci_driver *);
-void comedi_pci_driver_unregister(struct comedi_driver *, struct pci_driver *);
+int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
+			       struct pci_driver *pci_driver);
+void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
+				  struct pci_driver *pci_driver);
 
 /**
  * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver
Signature · 1 line
2.1.4
#1 lore raw
Quoted 13 lines · Piotr Gregor

Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors.

Signed-off-by Piotr Gregor <[email protected]>
---
 drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/staging/comedi/comedi_pci.h +0 -0
index 4005cc9..7dfd892 100644

drivers/staging/comedi/comedi_pci.h line 37

Quoted 5 lines
drivers/staging/comedi/comedi_pci.h +1 -1
@@ -34,18 +34,20 @@
 #define PCI_VENDOR_ID_RTD		0x1435
 #define PCI_VENDOR_ID_HUMUSOFT		0x186c
 
-struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
+struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);

For the function prototypes I prefer no names for the "pointer" parameters.

The "struct foo *" declaration is just as clear as "struct foo *bar".

Thanks,
Hartley

#2 lore raw
Quoted 17 lines · Hartley Sweeten
Quoted 16 lines · Piotr Gregor

Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors.

Signed-off-by Piotr Gregor <[email protected]>
---
 drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/staging/comedi/comedi_pci.h +0 -0
index 4005cc9..7dfd892 100644
@@ -34,18 +34,20 @@
 #define PCI_VENDOR_ID_RTD		0x1435
 #define PCI_VENDOR_ID_HUMUSOFT		0x186c
Quoted 6 lines

drivers/staging/comedi/comedi_pci.h line 37

Quoted 2 lines
drivers/staging/comedi/comedi_pci.h +1 -1
-struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
+struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);

For the function prototypes I prefer no names for the "pointer" parameters.

The "struct foo *" declaration is just as clear as "struct foo *bar".

Maybe, but checkpatch.pl doesn't agree (not since commit ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)!

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#3 lore raw
Quoted 11 lines · Ian Abbott
Quoted 7 lines · Hartley Sweeten

drivers/staging/comedi/comedi_pci.h line 37

Quoted 2 lines · Piotr Gregor
drivers/staging/comedi/comedi_pci.h +1 -1
-struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
+struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);

For the function prototypes I prefer no names for the "pointer" parameters.

The "struct foo *" declaration is just as clear as "struct foo *bar".

Maybe, but checkpatch.pl doesn't agree (not since commit ca0d8929e75ab1f860f61208d46955f280a1b05e anyway)!

Hmm.. Missed seeing that one go in.

I still think it's silly to name struct pointers in function arguments. Especially since that normally leads to stuff like 'struct foo *foo' where the parameter name is the same as the struct name.

Void pointers and generic types are a different matter. Naming those makes sense for clarity.

Oh well... Just my 2 cents...

Hartley

Reviewed-by on v1 1/1
#4 lore raw
In reply to Piotr Gregor
Quoted 32 lines · Piotr Gregor

Add names of parameters to function prototypes in comedi PCI. Checkpatch reports now no errors.

Signed-off-by Piotr Gregor <[email protected]>
---
 drivers/staging/comedi/comedi_pci.h | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/staging/comedi/comedi_pci.h +6 -6
index 4005cc9..7dfd892 100644
@@ -34,18 +34,20 @@
 #define PCI_VENDOR_ID_RTD		0x1435
 #define PCI_VENDOR_ID_HUMUSOFT		0x186c
 
-struct pci_dev *comedi_to_pci_dev(struct comedi_device *);
+struct pci_dev *comedi_to_pci_dev(struct comedi_device *dev);
 
-int comedi_pci_enable(struct comedi_device *);
-void comedi_pci_disable(struct comedi_device *);
-void comedi_pci_detach(struct comedi_device *);
+int comedi_pci_enable(struct comedi_device *dev);
+void comedi_pci_disable(struct comedi_device *dev);
+void comedi_pci_detach(struct comedi_device *dev);
 
-int comedi_pci_auto_config(struct pci_dev *, struct comedi_driver *,
+int comedi_pci_auto_config(struct pci_dev *pcidev, struct comedi_driver *driver,
 			   unsigned long context);
-void comedi_pci_auto_unconfig(struct pci_dev *);
+void comedi_pci_auto_unconfig(struct pci_dev *pcidev);

drivers/staging/comedi/comedi_pci.h line 53

Quoted 10 lines
drivers/staging/comedi/comedi_pci.h +4 -2
 
-int comedi_pci_driver_register(struct comedi_driver *, struct pci_driver *);
-void comedi_pci_driver_unregister(struct comedi_driver *, struct pci_driver *);
+int comedi_pci_driver_register(struct comedi_driver *comedi_driver,
+			       struct pci_driver *pci_driver);
+void comedi_pci_driver_unregister(struct comedi_driver *comedi_driver,
+				  struct pci_driver *pci_driver);
 
 /**
  * module_comedi_pci_driver() - Helper macro for registering a comedi PCI driver

Looks good, thanks!

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-