Skip to contentSkip to conversation

amdgpu/display: remove link/stream functions abstraction.

PATCH In review Dave Airlie 1 participant 2 messages Dec 15, 2016 – Dec 16, 2016 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdgpu/display: remove link/stream functions abstraction.

From: Dave Airlie <[email protected]>

Most of these weren't used in the driver, but I can't see why you need this table instead of just providing direct API, it's not hiding anything.

---
 .../drm/amd/display/amdgpu_dm/amdgpu_dm_types.c    |   2 +-
 drivers/gpu/drm/amd/display/dc/core/dc.c           | 232 +--------------------
 drivers/gpu/drm/amd/display/dc/dc.h                |  54 +----
 .../drm/amd/display/modules/freesync/freesync.c    |  48 ++---
 4 files changed, 31 insertions(+), 305 deletions(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c +1 -1
index e73c658..59a6bef 100644
@@ -630,7 +630,7 @@ static void update_stream_scaling_settings(
 		dst.height -= dm_state->underscan_vborder;
 	}
 
-	adev->dm.dc->stream_funcs.stream_update_scaling(adev->dm.dc, stream, &src, &dst);
+	dc_stream_update_scaling(adev->dm.dc, stream, &src, &dst);
 
 	DRM_DEBUG_KMS("Destination Rectangle x:%d  y:%d  width:%d  height:%d\n",
 			dst.x, dst.y, dst.width, dst.height);
drivers/gpu/drm/amd/display/dc/core/dc.c +7 -225

260 lines not on this page · raw message

drivers/gpu/drm/amd/display/dc/dc.h +8 -46

74 lines not on this page · raw message

drivers/gpu/drm/amd/display/modules/freesync/freesync.c +15 -33

102 lines not on this page · raw message

Signature · 6 lines
2.9.3

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20161215234950.17422-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 4 lines · Dave Airlie

From: Dave Airlie <[email protected]>

Most of these weren't used in the driver, but I can't see why you need this table instead of just providing direct API, it's not hiding anything.

I realised the power module uses some of these, but since that module isn't in the build.

I'd still think direct calls makes sense for all of this instead of callbacks.

Dave.
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx