Skip to contentSkip to conversation

spi: armada-3700: Set mode bits correctly

PATCH In review Dan Carpenter 3 participants 3 messages Dec 16, 2016 1 message not in the archive

Subsystems (2)
Kernel janitors SPI
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/3 spi: armada-3700: Set mode bits correctly

We set SPI_RX_DUAL twice instead of setting SPI_TX_DUAL.

Fixes 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-armada-3700.c +1 -1
index 5c7508dc6f0b..40491be3365f 100644
@@ -825,7 +825,7 @@ static int a3700_spi_probe(struct platform_device *pdev)
 	master->unprepare_message = a3700_spi_unprepare_message;
 	master->set_cs = a3700_spi_set_cs;
 	master->flags = SPI_MASTER_HALF_DUPLEX;
-	master->mode_bits |= (SPI_RX_DUAL | SPI_RX_DUAL |
+	master->mode_bits |= (SPI_RX_DUAL | SPI_TX_DUAL |
 			      SPI_RX_QUAD | SPI_TX_QUAD);
 
 	platform_set_drvdata(pdev, master);

A message that is not in the archive (sent off-list or not yet received): [email protected]

Acked-by
#2 lore raw

Hello,

Quoted 11 lines · Dan Carpenter

We set SPI_RX_DUAL twice instead of setting SPI_TX_DUAL.

Fixes 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by Dan Carpenter <[email protected]>
drivers/spi/spi-armada-3700.c +0 -0
index 5c7508dc6f0b..40491be3365f 100644

drivers/spi/spi-armada-3700.c static int a3700_spi_probe(struct platform_device *pdev) · line 831

Quoted 8 lines
drivers/spi/spi-armada-3700.c +1 -1
@@ -825,7 +825,7 @@ static int a3700_spi_probe(struct platform_device *pdev)
 	master->unprepare_message = a3700_spi_unprepare_message;
 	master->set_cs = a3700_spi_set_cs;
 	master->flags = SPI_MASTER_HALF_DUPLEX;
-	master->mode_bits |= (SPI_RX_DUAL | SPI_RX_DUAL |
+	master->mode_bits |= (SPI_RX_DUAL | SPI_TX_DUAL |
 			      SPI_RX_QUAD | SPI_TX_QUAD);
 
 	platform_set_drvdata(pdev, master);

Good catch,

Acked-by Romain Perier <[email protected]>

Thanks,
Romain
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw

Applied "spi: armada-3700: Set mode bits correctly" to the spi tree

In reply to Dan Carpenter

The patch

spi: armada-3700: Set mode bits correctly

has been applied to the spi tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From 42cd4ed888393b2bc8ddfd277aa2d0ec0c7e0259 Mon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Fri, 16 Dec 2016 12:33:25 +0300
Subject: [PATCH] spi: armada-3700: Set mode bits correctly

We set SPI_RX_DUAL twice instead of setting SPI_TX_DUAL.

Fixes 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Romain Perier <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 drivers/spi/spi-armada-3700.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-armada-3700.c +1 -1
index 4e921782652f..0314c6b9e044 100644
@@ -825,7 +825,7 @@ static int a3700_spi_probe(struct platform_device *pdev)
 	master->unprepare_message = a3700_spi_unprepare_message;
 	master->set_cs = a3700_spi_set_cs;
 	master->flags = SPI_MASTER_HALF_DUPLEX;
-	master->mode_bits |= (SPI_RX_DUAL | SPI_RX_DUAL |
+	master->mode_bits |= (SPI_RX_DUAL | SPI_TX_DUAL |
 			      SPI_RX_QUAD | SPI_TX_QUAD);
 
 	platform_set_drvdata(pdev, master);
Signature · 1 line
2.11.0