HuC Loading Patches
Subsystems (3)
cover HuC Loading Patches
These patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at:
https://lists.freedesktop.org/archives/libva/2016-September/004554.html
https://lists.freedesktop.org/archives/libva/2016-September/004555.html
More information regarding the HuC, batch commands that configure the HuC etc can be found at-
https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf
https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf
v2: rebased.
v3: rebased. Changed the code following the review comments.
v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general.
v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek-
https://patchwork.freedesktop.org/series/15896/
v6:rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev.
v7: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used.
Anusha Srivatsa (3):
drm/i915/huc: Add HuC fw loading support
drm/i915/huc: Add BXT HuC Loading Support
drm/i915/HuC: Add KBL huC loading Support
Peter Antoine (5):
drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c | 43 ++++- drivers/gpu/drm/i915/i915_drv.c | 8 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_guc_reg.h | 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 ++- drivers/gpu/drm/i915/intel_guc_loader.c | 201 +++++++++++--------- drivers/gpu/drm/i915/intel_huc_loader.c | 290 +++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.c | 62 ++++++ drivers/gpu/drm/i915/intel_uc.h | 63 +++++-- include/uapi/drm/i915_drm.h | 1 + 12 files changed, 579 insertions(+), 124 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/8 drm/i915/guc: Make the GuC fw loading helper functions general
From: Peter Antoine <[email protected]>
Rename some of the GuC fw loading code to make them more general. We will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g s/GUC_FIRMWARE/UC_FIRMWARE/g
Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members, such as 'guc' or 'guc_fw' either is renamed to 'uc' or removed for same purpose.
v2: rebased on top of nightly.
reapplied the search/replace as upstream code as changed.
v3: rebased again on drm-nightly.
v4: removed G from messages in shared fw fetch function.
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased.Updated dev to dev_priv in intel_guc_setup(), guc_fw_getch() and intel_guc_init().
v14: rebased. Remove uint32_t fw_type to patch 2. Add INTEL_ prefix for fields in enum intel_uc_fw_status. Remove uc_dev field since its never used.Rename uc_fw to just fw and guc_fw to fw to avoid redundency.
--- drivers/gpu/drm/i915/i915_debugfs.c | 12 +-- drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_loader.c | 157 +++++++++++++++-------------- drivers/gpu/drm/i915/intel_uc.h | 36 +++---- 4 files changed, 105 insertions(+), 104 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +6 -6
@@ -2328,7 +2328,7 @@ static int i915_llc(struct seq_file *m, void *data)static int i915_guc_load_status_info (struct seq_file *m,void *data) {struct drm_i915_private *dev_priv =node_to_i915 (m->private); -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;u32 tmp, i;if (!HAS_GUC_UCODE (dev_priv))
@@ -2336,15 +2336,15 @@ static int i915_guc_load_status_info(struct seq_file *m, void *data)seq_printf (m,"GuC firmware status:\n" );seq_printf (m,"\tpath: %s\n" , - guc_fw->guc_fw_path); + guc_fw->uc_fw_path);seq_printf (m,"\tfetch: %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status)); +intel_uc_fw_status_repr (guc_fw->fetch_status));seq_printf (m,"\tload: %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_load_status)); +intel_uc_fw_status_repr (guc_fw->load_status));seq_printf (m,"\tversion wanted: %d.%d\n" , - guc_fw->guc_fw_major_wanted, guc_fw->guc_fw_minor_wanted); + guc_fw->major_ver_wanted, guc_fw->minor_ver_wanted);seq_printf (m,"\tversion found: %d.%d\n" , - guc_fw->guc_fw_major_found, guc_fw->guc_fw_minor_found); + guc_fw->major_ver_found, guc_fw->minor_ver_found);seq_printf (m,"\theader: offset is %d; size = %d\n" , guc_fw->header_offset, guc_fw->header_size); seq_printf(m, "\tuCode: offset is %d; size = %d\n",
drivers/gpu/drm/i915/i915_guc_submission.c +2 -2
@@ -1493,7 +1493,7 @@ int intel_guc_suspend(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->guc_fw.guc_fw_load_status !=GUC_FIRMWARE_SUCCESS ) +if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS )return 0 ;gen9_disable_guc_interrupts (dev_priv);
@@ -1520,7 +1520,7 @@ int intel_guc_resume(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->guc_fw.guc_fw_load_status !=GUC_FIRMWARE_SUCCESS ) +if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS )return 0 ;if (i915.guc_log_level >=0 )
drivers/gpu/drm/i915/intel_guc_loader.c +79 -78
342 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uc.h +18 -18
@@ -91,28 +91,28 @@ struct i915_guc_client {uint64_t submissions[I915_NUM_ENGINES ]; }; -enum intel_guc_fw_status { -GUC_FIRMWARE_FAIL =-1 , -GUC_FIRMWARE_NONE =0 , -GUC_FIRMWARE_PENDING , -GUC_FIRMWARE_SUCCESS +enum intel_uc_fw_status { +INTEL_UC_FIRMWARE_FAIL =-1 , +INTEL_UC_FIRMWARE_NONE =0 , +INTEL_UC_FIRMWARE_PENDING , +INTEL_UC_FIRMWARE_SUCCESS };/* * This structure encapsulates all the data needed during the process * of fetching, caching, and loading the firmware image into the GuC. */ -struct intel_guc_fw { -const char * guc_fw_path; -size_t guc_fw_size; -struct drm_i915_gem_object * guc_fw_obj; -enum intel_guc_fw_status guc_fw_fetch_status; -enum intel_guc_fw_status guc_fw_load_status; - -uint16_t guc_fw_major_wanted; -uint16_t guc_fw_minor_wanted; -uint16_t guc_fw_major_found; -uint16_t guc_fw_minor_found; +struct intel_uc_fw { +const char *uc_fw_path; +size_t size; +struct drm_i915_gem_object *uc_fw_obj; +enum intel_uc_fw_status fetch_status; +enum intel_uc_fw_status load_status; + +uint16_t major_ver_wanted; +uint16_t minor_ver_wanted; +uint16_t major_ver_found; +uint16_t minor_ver_found;uint32_t header_size;uint32_t header_offset;
@@ -139,7 +139,7 @@ struct intel_guc_log { };struct intel_guc { -struct intel_guc_fw guc_fw; +struct intel_uc_fw fw;struct intel_guc_log log;/* intel_guc_recv interrupt related state */
@@ -181,7 +181,7 @@ int intel_guc_log_control(struct intel_guc *guc, u32 control_val);extern void intel_guc_init (struct drm_i915_private *dev_priv);extern int intel_guc_setup (struct drm_i915_private *dev_priv);extern void intel_guc_fini (struct drm_i915_private *dev_priv); -extern const char *intel_guc_fw_status_repr (enum intel_guc_fw_status status); +extern const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status);extern int intel_guc_suspend (struct drm_i915_private *dev_priv);extern int intel_guc_resume (struct drm_i915_private *dev_priv);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 1/8] drm/i915/guc: Make the GuC fw loading helper functions general
Quoted 406 lines · anushasr
From: Peter Antoine <[email protected]>
Rename some of the GuC fw loading code to make them more general. We will utilise them for HuC loading as well.
s/intel_guc_fw/intel_uc_fw/g s/GUC_FIRMWARE/UC_FIRMWARE/gStruct
intel_guc_fwis renamed tointel_uc_fw. Prefix of tts members, such as 'guc' or 'guc_fw' either is renamed to 'uc' or removed for same purpose.v2: rebased on top of nightly.
reapplied the search/replace as upstream code as changed.
v3: rebased again on drm-nightly.
v4: removed G from messages in shared fw fetch function.
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased.Updated dev todev_privinintel_guc_setup(),guc_fw_getch()andintel_guc_init().
v14: rebased. Removeuint32_tfw_typeto patch 2. AddINTEL_prefix for fields in enumintel_uc_fw_status. Removeuc_devfield since its never used.Renameuc_fwto just fw andguc_fwto fw to avoid redundency.Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/i915_debugfs.c | 12 +-- drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_loader.c | 157 +++++++++++++++-------------- drivers/gpu/drm/i915/intel_uc.h | 36 +++---- 4 files changed, 105 insertions(+), 104 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +6
-6@@ -2328,7 +2328,7 @@ static int i915_llc(struct seq_file *m, void *data)static int i915_guc_load_status_info (struct seq_file *m,void *data) {struct drm_i915_private *dev_priv =node_to_i915 (m->private); -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;u32 tmp, i;if (!HAS_GUC_UCODE (dev_priv))@@ -2336,15 +2336,15 @@ static int i915_guc_load_status_info(struct seq_file *m, void *data)seq_printf (m,"GuC firmware status:\n" );seq_printf (m,"\tpath: %s\n" , - guc_fw->guc_fw_path); + guc_fw->uc_fw_path);seq_printf (m,"\tfetch: %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status)); +intel_uc_fw_status_repr (guc_fw->fetch_status));seq_printf (m,"\tload: %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_load_status)); +intel_uc_fw_status_repr (guc_fw->load_status));seq_printf (m,"\tversion wanted: %d.%d\n" , - guc_fw->guc_fw_major_wanted, guc_fw->guc_fw_minor_wanted); + guc_fw->major_ver_wanted, guc_fw->minor_ver_wanted);seq_printf (m,"\tversion found: %d.%d\n" , - guc_fw->guc_fw_major_found, guc_fw->guc_fw_minor_found); + guc_fw->major_ver_found, guc_fw->minor_ver_found);seq_printf (m,"\theader: offset is %d; size = %d\n" , guc_fw->header_offset, guc_fw->header_size); seq_printf(m, "\tuCode: offset is %d; size = %d\n",drivers/gpu/drm/i915/i915_guc_submission.c +2
-2@@ -1493,7 +1493,7 @@ int intel_guc_suspend(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->guc_fw.guc_fw_load_status !=GUC_FIRMWARE_SUCCESS ) +if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS )return 0 ;gen9_disable_guc_interrupts (dev_priv);@@ -1520,7 +1520,7 @@ int intel_guc_resume(struct drm_i915_private *dev_priv)struct i915_gem_context *ctx;u32 data[3 ]; -if (guc->guc_fw.guc_fw_load_status !=GUC_FIRMWARE_SUCCESS ) +if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS )return 0 ;if (i915.guc_log_level >=0 )drivers/gpu/drm/i915/intel_guc_loader.c +66
-68@@ -81,16 +81,16 @@ MODULE_FIRMWARE(I915_BXT_GUC_UCODE);MODULE_FIRMWARE (I915_KBL_GUC_UCODE );/* User-friendly representation of an enum */ -const char *intel_guc_fw_status_repr (enum intel_guc_fw_status status) +const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status) {switch (status) { -case GUC_FIRMWARE_FAIL : +case INTEL_UC_FIRMWARE_FAIL :return "FAIL" ; -case GUC_FIRMWARE_NONE : +case INTEL_UC_FIRMWARE_NONE :return "NONE" ; -case GUC_FIRMWARE_PENDING : +case INTEL_UC_FIRMWARE_PENDING :return "PENDING" ; -case GUC_FIRMWARE_SUCCESS : +case INTEL_UC_FIRMWARE_SUCCESS :return "SUCCESS" ;default :return "UNKNOWN!" ;@@ -278,7 +278,7 @@ static inline bool guc_ucode_response(struct drm_i915_private *dev_priv,static int guc_ucode_xfer_dma (struct drm_i915_private *dev_priv,struct i915_vma *vma) { -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;unsigned long offset;struct sg_table *sg = vma->pages;u32 status, rsa[UOS_RSA_SCRATCH_MAX_COUNT ];@@ -350,17 +350,17 @@ static u32 guc_wopcm_size(struct drm_i915_private *dev_priv)*/ static int guc_ucode_xfer (struct drm_i915_private *dev_priv) { -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;struct i915_vma *vma;int ret; - ret =i915_gem_object_set_to_gtt_domain (guc_fw->guc_fw_obj, false); + ret =i915_gem_object_set_to_gtt_domain (guc_fw->uc_fw_obj, false);if (ret) {DRM_DEBUG_DRIVER ("set-domain failed %d\n" , ret);return ret; } - vma =i915_gem_object_ggtt_pin (guc_fw->guc_fw_obj,NULL ,0 ,0 ,0 ); + vma =i915_gem_object_ggtt_pin (guc_fw->uc_fw_obj,NULL ,0 ,0 ,0 );if (IS_ERR (vma)) {DRM_DEBUG_DRIVER ("pin failed %d\n" , (int )PTR_ERR (vma));return PTR_ERR (vma);@@ -450,14 +450,14 @@ static int guc_hw_reset(struct drm_i915_private *dev_priv)*/ int intel_guc_setup (struct drm_i915_private *dev_priv) { -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; -const char *fw_path = guc_fw->guc_fw_path; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw; +const char *fw_path = guc_fw->uc_fw_path;int retries, ret, err;DRM_DEBUG_DRIVER ("GuC fw status: path %s, fetch %s, load %s\n" , fw_path, -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status), -intel_guc_fw_status_repr (guc_fw->guc_fw_load_status)); +intel_uc_fw_status_repr (guc_fw->fetch_status), +intel_uc_fw_status_repr (guc_fw->load_status));/* Loading forbidden, or no firmware to load? */ if (!i915.enable_guc_loading) {@@ -475,10 +475,10 @@ int intel_guc_setup(struct drm_i915_private *dev_priv) }/* Fetch failed, or already fetched but failed to load? */ -if (guc_fw->guc_fw_fetch_status !=GUC_FIRMWARE_SUCCESS ) { +if (guc_fw->fetch_status !=INTEL_UC_FIRMWARE_SUCCESS ) { err = -EIO ; goto fail; - }else if (guc_fw->guc_fw_load_status ==GUC_FIRMWARE_FAIL ) { + }else if (guc_fw->load_status ==INTEL_UC_FIRMWARE_FAIL ) { err = -ENOEXEC ; goto fail; }@@ -486,11 +486,11 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)guc_interrupts_release (dev_priv);gen9_reset_guc_interrupts (dev_priv); - guc_fw->guc_fw_load_status =GUC_FIRMWARE_PENDING ; + guc_fw->load_status =INTEL_UC_FIRMWARE_PENDING ;DRM_DEBUG_DRIVER ("GuC fw status: fetch %s, load %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status), -intel_guc_fw_status_repr (guc_fw->guc_fw_load_status)); +intel_uc_fw_status_repr (guc_fw->fetch_status), +intel_uc_fw_status_repr (guc_fw->load_status)); err =i915_guc_submission_init (dev_priv);if (err)@@ -522,11 +522,11 @@ int intel_guc_setup(struct drm_i915_private *dev_priv) "retry %d more time(s)\n", err, retries); } - guc_fw->guc_fw_load_status =GUC_FIRMWARE_SUCCESS ; + guc_fw->load_status =INTEL_UC_FIRMWARE_SUCCESS ;DRM_DEBUG_DRIVER ("GuC fw status: fetch %s, load %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status), -intel_guc_fw_status_repr (guc_fw->guc_fw_load_status)); +intel_uc_fw_status_repr (guc_fw->fetch_status), +intel_uc_fw_status_repr (guc_fw->load_status));if (i915.enable_guc_submission) {if (i915.guc_log_level >=0 )@@ -541,8 +541,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)return 0 ; fail: -if (guc_fw->guc_fw_load_status ==GUC_FIRMWARE_PENDING ) - guc_fw->guc_fw_load_status =GUC_FIRMWARE_FAIL ; +if (guc_fw->load_status ==INTEL_UC_FIRMWARE_PENDING ) + guc_fw->load_status =INTEL_UC_FIRMWARE_FAIL ;guc_interrupts_release (dev_priv);i915_guc_submission_disable (dev_priv);@@ -587,8 +587,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)return ret; } -static void guc_fw_fetch (struct drm_i915_private *dev_priv, -struct intel_guc_fw *guc_fw) +void intel_uc_fw_fetch (struct drm_i915_private *dev_priv, +struct intel_uc_fw *uc_fw) {struct pci_dev *pdev = dev_priv->drm.pdev;struct drm_i915_gem_object *obj;@@ -597,17 +597,17 @@ static void guc_fw_fetch(struct drm_i915_private *dev_priv,size_t size;int err; -DRM_DEBUG_DRIVER ("before requesting firmware: GuC fw fetch status %s\n" , -intel_guc_fw_status_repr (guc_fw->guc_fw_fetch_status)); +DRM_DEBUG_DRIVER ("before requesting firmware: uC fw fetch status %s\n" , +intel_uc_fw_status_repr (uc_fw->fetch_status)); - err =request_firmware (&fw, guc_fw->guc_fw_path, &pdev->dev); + err =request_firmware (&fw, uc_fw->uc_fw_path, &pdev->dev);if (err) goto fail;if (!fw) goto fail; -DRM_DEBUG_DRIVER ("fetch GuC fw from %s succeeded, fw %p\n" , - guc_fw->guc_fw_path, fw); +DRM_DEBUG_DRIVER ("fetch uC fw from %s succeeded, fw %p\n" , + uc_fw->uc_fw_path, fw);/* Check the size of the blob before examining buffer contents */ if (fw->size <sizeof (struct guc_css_header )) {@@ -618,36 +618,36 @@ static void guc_fw_fetch(struct drm_i915_private *dev_priv, css = (struct guc_css_header *)fw->data;/* Firmware bits always start from header */ - guc_fw->header_offset =0 ; - guc_fw->header_size = (css->header_size_dw - css->modulus_size_dw - + uc_fw->header_offset =0 ; + uc_fw->header_size = (css->header_size_dw - css->modulus_size_dw - css->key_size_dw - css->exponent_size_dw) *sizeof (u32); -if (guc_fw->header_size !=sizeof (struct guc_css_header )) { +if (uc_fw->header_size !=sizeof (struct guc_css_header )) {DRM_NOTE ("CSS header definition mismatch\n" ); goto fail; }/* then, uCode */ - guc_fw->ucode_offset = guc_fw->header_offset + guc_fw->header_size; - guc_fw->ucode_size = (css->size_dw - css->header_size_dw) *sizeof (u32); + uc_fw->ucode_offset = uc_fw->header_offset + uc_fw->header_size; + uc_fw->ucode_size = (css->size_dw - css->header_size_dw) *sizeof (u32);/* now RSA */ if (css->key_size_dw !=UOS_RSA_SCRATCH_MAX_COUNT ) {DRM_NOTE ("RSA key size is bad\n" ); goto fail; } - guc_fw->rsa_offset = guc_fw->ucode_offset + guc_fw->ucode_size; - guc_fw->rsa_size = css->key_size_dw *sizeof (u32); + uc_fw->rsa_offset = uc_fw->ucode_offset + uc_fw->ucode_size; + uc_fw->rsa_size = css->key_size_dw *sizeof (u32);/* At least, it should have header, uCode and RSA. Size of all three. */ - size = guc_fw->header_size + guc_fw->ucode_size + guc_fw->rsa_size; + size = uc_fw->header_size + uc_fw->ucode_size + uc_fw->rsa_size;if (fw->size < size) {DRM_NOTE ("Missing firmware components\n" ); goto fail; }/* Header and uCode will be loaded to WOPCM. Size of the two. */ - size = guc_fw->header_size + guc_fw->ucode_size; + size = uc_fw->header_size + uc_fw->ucode_size;if (size >guc_wopcm_size (dev_priv)) {DRM_NOTE ("Firmware is too large to fit in WOPCM\n" ); goto fail;@@ -659,21 +659,21 @@ static void guc_fw_fetch(struct drm_i915_private *dev_priv,* TWO bytes each (i.e. u16), although all pointers and offsets are defined * in terms of bytes (u8). */ - guc_fw->guc_fw_major_found = css->guc_sw_version >>16 ; - guc_fw->guc_fw_minor_found = css->guc_sw_version &0xFFFF ; - -if (guc_fw->guc_fw_major_found != guc_fw->guc_fw_major_wanted || - guc_fw->guc_fw_minor_found < guc_fw->guc_fw_minor_wanted) { -DRM_NOTE ("GuC firmware version %d.%d, required %d.%d\n" , - guc_fw->guc_fw_major_found, guc_fw->guc_fw_minor_found, - guc_fw->guc_fw_major_wanted, guc_fw->guc_fw_minor_wanted); + uc_fw->major_ver_found = css->guc_sw_version >>16 ; + uc_fw->minor_ver_found = css->guc_sw_version &0xFFFF ; + +if (uc_fw->major_ver_found != uc_fw->major_ver_wanted || + uc_fw->minor_ver_found < uc_fw->minor_ver_wanted) { +DRM_NOTE ("uC firmware version %d.%d, required %d.%d\n" , + uc_fw->major_ver_found, uc_fw->minor_ver_found, + uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted); err = -ENOEXEC ; goto fail; }DRM_DEBUG_DRIVER ("firmware version %d.%d OK (minimum %d.%d)\n" , - guc_fw->guc_fw_major_found, guc_fw->guc_fw_minor_found, - guc_fw->guc_fw_major_wanted, guc_fw->guc_fw_minor_wanted); + uc_fw->major_ver_found, uc_fw->minor_ver_found, + uc_fw->major_ver_wanted, uc_fw->minor_ver_wanted);mutex_lock (&dev_priv->drm.struct_mutex); obj =i915_gem_object_create_from_data (dev_priv, fw->data, fw->size);@@ -683,31 +683,31 @@ static void guc_fw_fetch(struct drm_i915_private *dev_priv, goto fail; } - guc_fw->guc_fw_obj = obj; - guc_fw->guc_fw_size = fw->size; + uc_fw->uc_fw_obj = obj; + uc_fw->size = fw->size; -DRM_DEBUG_DRIVER ("GuC fw fetch status SUCCESS, obj %p\n" , - guc_fw->guc_fw_obj); +DRM_DEBUG_DRIVER ("uC fw fetch status SUCCESS, obj %p\n" , + uc_fw->uc_fw_obj);release_firmware (fw); - guc_fw->guc_fw_fetch_status =GUC_FIRMWARE_SUCCESS ; + uc_fw->fetch_status =INTEL_UC_FIRMWARE_SUCCESS ;return ; fail: -DRM_WARN ("Failed to fetch valid GuC firmware from %s (error %d)\n" , - guc_fw->guc_fw_path, err); -DRM_DEBUG_DRIVER ("GuC fw fetch status FAIL; err %d, fw %p, obj %p\n" , - err, fw, guc_fw->guc_fw_obj); +DRM_WARN ("Failed to fetch valid uC firmware from %s (error %d)\n" , + uc_fw->uc_fw_path, err); +DRM_DEBUG_DRIVER ("uC fw fetch status FAIL; err %d, fw %p, obj %p\n" , + err, fw, uc_fw->uc_fw_obj);mutex_lock (&dev_priv->drm.struct_mutex); - obj = guc_fw->guc_fw_obj; + obj = uc_fw->uc_fw_obj;if (obj)i915_gem_object_put (obj); - guc_fw->guc_fw_obj =NULL ; + uc_fw->uc_fw_obj =NULL ;mutex_unlock (&dev_priv->drm.struct_mutex);release_firmware (fw);/* OK even if fw is NULL */ - guc_fw->guc_fw_fetch_status =GUC_FIRMWARE_FAIL ; + uc_fw->fetch_status =INTEL_UC_FIRMWARE_FAIL ; }/** @@ -721,7 +721,7 @@ static void guc_fw_fetch(struct drm_i915_private *dev_priv,*/ void intel_guc_init (struct drm_i915_private *dev_priv) { -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;const char *fw_path;if (!HAS_GUC (dev_priv)) {@@ -739,23 +739,24 @@ void intel_guc_init(struct drm_i915_private *dev_priv) fw_path =NULL ; }else if (IS_SKYLAKE (dev_priv)) { fw_path =I915_SKL_GUC_UCODE ; - guc_fw->guc_fw_major_wanted =SKL_FW_MAJOR ; - guc_fw->guc_fw_minor_wanted =SKL_FW_MINOR ; + guc_fw->major_ver_wanted =SKL_FW_MAJOR ; + guc_fw->minor_ver_wanted =SKL_FW_MINOR ; }else if (IS_BROXTON (dev_priv)) { fw_path =I915_BXT_GUC_UCODE ; - guc_fw->guc_fw_major_wanted =BXT_FW_MAJOR ; - guc_fw->guc_fw_minor_wanted =BXT_FW_MINOR ; + guc_fw->major_ver_wanted =BXT_FW_MAJOR ; + guc_fw->minor_ver_wanted =BXT_FW_MINOR ; }else if (IS_KABYLAKE (dev_priv)) { fw_path =I915_KBL_GUC_UCODE ; - guc_fw->guc_fw_major_wanted =KBL_FW_MAJOR ; - guc_fw->guc_fw_minor_wanted =KBL_FW_MINOR ;
drivers/gpu/drm/i915/intel_guc_loader.c void intel_guc_init(struct drm_i915_private *dev_priv) · line 756
Quoted 10 lines
drivers/gpu/drm/i915/intel_guc_loader.c +3
-3+ guc_fw->major_ver_wanted =KBL_FW_MAJOR ; + guc_fw->minor_ver_wanted =KBL_FW_MINOR ; }else { fw_path ="" ;/* unknown device */ } - guc_fw->guc_fw_path = fw_path; - guc_fw->guc_fw_fetch_status =GUC_FIRMWARE_NONE ; - guc_fw->guc_fw_load_status =GUC_FIRMWARE_NONE ; +//guc_fw->uc_dev = &dev_priv->drm;
A slight oversight here.
Regards,
Tvrtko
Quoted 101 lines
drivers/gpu/drm/i915/intel_guc_loader.c +10
-7+ guc_fw->uc_fw_path = fw_path; + guc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; + guc_fw->load_status =INTEL_UC_FIRMWARE_NONE ;/* Early (and silent) return if GuC loading is disabled */ if (!i915.enable_guc_loading)@@ -765,9 +766,9 @@ void intel_guc_init(struct drm_i915_private *dev_priv)if (*fw_path =='\0' )return ; - guc_fw->guc_fw_fetch_status =GUC_FIRMWARE_PENDING ; + guc_fw->fetch_status =INTEL_UC_FIRMWARE_PENDING ;DRM_DEBUG_DRIVER ("GuC firmware pending, path %s\n" , fw_path); -guc_fw_fetch (dev_priv, guc_fw); +intel_uc_fw_fetch (dev_priv, guc_fw);/* status must now be FAIL or SUCCESS */ }@@ -777,17 +778,17 @@ void intel_guc_init(struct drm_i915_private *dev_priv)*/ void intel_guc_fini (struct drm_i915_private *dev_priv) { -struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; +struct intel_uc_fw *guc_fw = &dev_priv->guc.fw;mutex_lock (&dev_priv->drm.struct_mutex);guc_interrupts_release (dev_priv);i915_guc_submission_disable (dev_priv);i915_guc_submission_fini (dev_priv); -if (guc_fw->guc_fw_obj) -i915_gem_object_put (guc_fw->guc_fw_obj); - guc_fw->guc_fw_obj =NULL ; +if (guc_fw->uc_fw_obj) +i915_gem_object_put (guc_fw->uc_fw_obj); + guc_fw->uc_fw_obj =NULL ;mutex_unlock (&dev_priv->drm.struct_mutex); - guc_fw->guc_fw_fetch_status =GUC_FIRMWARE_NONE ; + guc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; }drivers/gpu/drm/i915/intel_uc.h +17
-17@@ -91,28 +91,28 @@ struct i915_guc_client {uint64_t submissions[I915_NUM_ENGINES ]; }; -enum intel_guc_fw_status { -GUC_FIRMWARE_FAIL =-1 , -GUC_FIRMWARE_NONE =0 , -GUC_FIRMWARE_PENDING , -GUC_FIRMWARE_SUCCESS +enum intel_uc_fw_status { +INTEL_UC_FIRMWARE_FAIL =-1 , +INTEL_UC_FIRMWARE_NONE =0 , +INTEL_UC_FIRMWARE_PENDING , +INTEL_UC_FIRMWARE_SUCCESS };/* * This structure encapsulates all the data needed during the process * of fetching, caching, and loading the firmware image into the GuC. */ -struct intel_guc_fw { -const char * guc_fw_path; -size_t guc_fw_size; -struct drm_i915_gem_object * guc_fw_obj; -enum intel_guc_fw_status guc_fw_fetch_status; -enum intel_guc_fw_status guc_fw_load_status; - -uint16_t guc_fw_major_wanted; -uint16_t guc_fw_minor_wanted; -uint16_t guc_fw_major_found; -uint16_t guc_fw_minor_found; +struct intel_uc_fw { +const char *uc_fw_path; +size_t size; +struct drm_i915_gem_object *uc_fw_obj; +enum intel_uc_fw_status fetch_status; +enum intel_uc_fw_status load_status; + +uint16_t major_ver_wanted; +uint16_t minor_ver_wanted; +uint16_t major_ver_found; +uint16_t minor_ver_found;uint32_t header_size;uint32_t header_offset;@@ -139,7 +139,7 @@ struct intel_guc_log { };struct intel_guc { -struct intel_guc_fw guc_fw; +struct intel_uc_fw fw;struct intel_guc_log log;/* intel_guc_recv interrupt related state */
drivers/gpu/drm/i915/intel_uc.h int intel_guc_log_control(struct intel_guc *guc, u32 control_val); · line 187
Quoted 8 lines
drivers/gpu/drm/i915/intel_uc.h +1
-1@@ -181,7 +181,7 @@ int intel_guc_log_control(struct intel_guc *guc, u32 control_val);extern void intel_guc_init (struct drm_i915_private *dev_priv);extern int intel_guc_setup (struct drm_i915_private *dev_priv);extern void intel_guc_fini (struct drm_i915_private *dev_priv); -extern const char *intel_guc_fw_status_repr (enum intel_guc_fw_status status); +extern const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status);extern int intel_guc_suspend (struct drm_i915_private *dev_priv);extern int intel_guc_resume (struct drm_i915_private *dev_priv);
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/8 drm/i915/huc: Unified css_header struct for GuC and HuC
In reply to anushasrFrom: Peter Antoine <[email protected]>
HuC firmware css header has almost exactly same definition as GuC firmware except for the sw_version. Also, add a new member fw_type into intel_uc_fw to indicate what kind of fw it is. So, the loader will pull right sw_version from header.
v2: rebased on-top of drm-intel-nightly
v3: rebased on-top of drm-intel-nightly (again).
v4: rebased + spaces.
v7: rebased.
v8: rebased.
v9: rebased. Rename device_id to guc_branch_client_version, make guc_sw_version a union. <Jeff Mcgee>. Put UC_FW_TYPE_GUC and UC_FW_TYPE_HUC into an enum.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip.
v13: rebased.Update dev to dev_priv in intel_uc_fw_fetch
v14: rebased. Add INTEL_ prefix to an enum. Add fw_type declaration from patch 1.Combine two different unions for huc and guc version, reserved etc into one union with two structs.
--- drivers/gpu/drm/i915/intel_guc_fwif.h | 23 ++++++++++++++---- drivers/gpu/drm/i915/intel_guc_loader.c | 41 ++++++++++++++++++++++----------- drivers/gpu/drm/i915/intel_uc.h | 6 +++++ 3 files changed, 53 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/intel_guc_fwif.h +19 -4
@@ -145,7 +145,7 @@* The GuC firmware layout looks like this: * * +-------------------------------+ -* | guc_css_header | +* | uc_css_header | * | | * | contains major/minor version | * +-------------------------------+
@@ -172,9 +172,16 @@* 3. Length info of each component can be found in header, in dwords. * 4. Modulus and exponent key are not required by driver. They may not appear * in fw. So driver will load a truncated firmware in this case. +* +* HuC firmware layout is same as GuC firmware. +* +* HuC firmware css header is different. However, the only difference is where +* the version information is saved. The uc_css_header is unified to support +* both. Driver should get HuC version from uc_css_header.huc_sw_version, while +* uc_css_header.guc_sw_version for GuC. */ -struct guc_css_header { +struct uc_css_header {uint32_t module_type;/* header_size includes all non-uCode bits, including css_header, rsa * key, modulus key and exponent data. */
@@ -205,8 +212,16 @@ struct guc_css_header {char username[8 ];char buildnumber[12 ]; -uint32_t device_id; -uint32_t guc_sw_version; +union { +struct { +uint32_t branch_client_version; +uint32_t sw_version; + } guc; +struct { +uint32_t sw_version; +uint32_t reserved; + } huc; + };uint32_t prod_preprod_fw;uint32_t reserved[12 ];uint32_t header_info;
drivers/gpu/drm/i915/intel_guc_loader.c +28 -13
75 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uc.h +6 -0
@@ -98,6 +98,11 @@ enum intel_uc_fw_status { INTEL_UC_FIRMWARE_SUCCESS }; +enum { +INTEL_UC_FW_TYPE_GUC , +INTEL_UC_FW_TYPE_HUC +}; +/* * This structure encapsulates all the data needed during the process * of fetching, caching, and loading the firmware image into the GuC.
@@ -114,6 +119,7 @@ struct intel_uc_fw {uint16_t major_ver_found;uint16_t minor_ver_found; +uint32_t fw_type;uint32_t header_size;uint32_t header_offset;uint32_t rsa_size;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/8 drm/i915/huc: Add HuC fw loading support
In reply to anushasrFrom: Anusha Srivatsa <[email protected]>
The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases.
HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon) update huc_version number of format.
v3: rebased to drm-intel-nightly, changed the file name format to
match the one in the huc package.
Changed dev->dev_private to to_i915()
v4: moved function back to where it was.
change wait_for_atomic to wait_for.
v5: rebased + comment changes.
v7: rebased.
v8: rebased.
v9: rebased. Changed the year in the copyright message to reflect the right year.Correct the comments,remove the unwanted WARN message, replace drm_gem_object_unreference() with i915_gem_object_put().Make the prototypes in intel_huc.h non-extern.
v10: rebased. Update the file construction done by HuC. It is similar to GuC.Adopted the approach used in-
https://patchwork.freedesktop.org/patch/104355/ <Tvrtko Ursulin>
v11: Fix warnings remove old declaration
v12: Change dev to dev_priv in macro definition.
Corrected comments.
v13: rebased.
v14: rebased on top of drm-tip
v15: rebased. Updated functions intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. Moved contents of intel_huc.h to intel_uc.h
v16: change SKL_FW_ to SKL_HUC_FW_. Add intel_ prefix to guc_wopcm_size(). Remove unwanted checks in intel_uc.h. Rename huc_fw in struct intel_huc to simply fw to avoid redundency.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_guc_reg.h | 3 + drivers/gpu/drm/i915/intel_guc_loader.c | 11 +- drivers/gpu/drm/i915/intel_huc_loader.c | 264 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 18 +++ 7 files changed, 297 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c
drivers/gpu/drm/i915/Makefile +1 -0
@@ -57,6 +57,7 @@ i915-y += i915_cmd_parser.o \ # general-purpose microcontroller (GuC) support i915-y += intel_uc.o \ intel_guc_loader.o \ + intel_huc_loader.o \ i915_guc_submission.o # autogenerated null render state
drivers/gpu/drm/i915/i915_drv.c +3 -1
@@ -600,6 +600,7 @@ static int i915_load_modeset_init(struct drm_device *dev)if (ret) goto cleanup_irq; +intel_huc_init (dev_priv);intel_guc_init (dev_priv); ret =i915_gem_init (dev_priv);
@@ -627,6 +628,7 @@ static int i915_load_modeset_init(struct drm_device *dev)DRM_ERROR ("failed to idle hardware; continuing to unload!\n" );i915_gem_fini (dev_priv); cleanup_irq: +intel_huc_fini (dev);intel_guc_fini (dev_priv);drm_irq_uninstall (dev);intel_teardown_gmbus (dev_priv);
@@ -1313,7 +1315,7 @@ void i915_driver_unload(struct drm_device *dev)/* Flush any outstanding unpin_work. */ drain_workqueue (dev_priv->wq); - +intel_huc_fini (dev);intel_guc_fini (dev_priv);i915_gem_fini (dev_priv);intel_fbc_cleanup_cfb (dev_priv);
drivers/gpu/drm/i915/i915_drv.h +2 -1
@@ -2134,6 +2134,7 @@ struct drm_i915_private {struct intel_gvt *gvt; +struct intel_huc huc;struct intel_guc guc;struct intel_csr csr;
@@ -2908,7 +2909,7 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_GUC (dev_priv) ((dev_priv)->info.has_guc)#define HAS_GUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_GUC_SCHED (dev_priv) (HAS_GUC(dev_priv)) - +#define HAS_HUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_RESOURCE_STREAMER (dev_priv) ((dev_priv)->info.has_resource_streamer)#define HAS_POOLED_EU (dev_priv) ((dev_priv)->info.has_pooled_eu)
drivers/gpu/drm/i915/i915_guc_reg.h +3 -0
@@ -61,9 +61,12 @@#define DMA_ADDRESS_SPACE_GTT (8 << 16)#define DMA_COPY_SIZE _MMIO(0xc310)#define DMA_CTRL _MMIO(0xc314) +#define HUC_UKERNEL (1<<9)#define UOS_MOVE (1<<4)#define START_DMA (1<<0)#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340) +#define HUC_LOADING_AGENT_VCR (0<<1) +#define HUC_LOADING_AGENT_GUC (1<<1)#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ #define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)
drivers/gpu/drm/i915/intel_guc_loader.c +6 -5
@@ -309,8 +309,8 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM );/* Finally start the DMA */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA )); - +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA ) | +_MASKED_BIT_DISABLE (HUC_UKERNEL ));/* * Wait for the DMA to complete & the GuC to start up. * NB: Docs recommend not using the interrupt for completion.
@@ -334,7 +334,7 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,return ret; } -static u32 guc_wopcm_size (struct drm_i915_private *dev_priv) +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv) {u32 wopcm_size =GUC_WOPCM_TOP ;
@@ -372,7 +372,7 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL );/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,guc_wopcm_size (dev_priv)); +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv));I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE );/* Enable MIA caching. GuC clock gating is disabled. */
@@ -511,6 +511,7 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)if (err) goto fail; +intel_huc_load (dev_priv); err =guc_ucode_xfer (dev_priv);if (!err)break ;
@@ -658,7 +659,7 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, size = uc_fw->header_size + uc_fw->ucode_size;/* Top 32k of WOPCM is reserved (8K stack + 24k RC6 context). */ -if (size >guc_wopcm_size (dev_priv)) { +if (size >intel_guc_wopcm_size (dev_priv)) {DRM_ERROR ("Firmware is too large to fit in WOPCM\n" ); goto fail; }
drivers/gpu/drm/i915/intel_huc_loader.c new file +264 -0
264 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uc.h +18 -0
@@ -24,6 +24,9 @@#ifndef _INTEL_UC_H_#define _INTEL_UC_H_ +#define HUC_STATUS2 _MMIO(0xD3B0) +#define HUC_FW_VERIFIED (1<<7) +#include "intel_guc_fwif.h" #include "i915_guc_reg.h" #include "intel_ringbuffer.h"
@@ -174,6 +177,13 @@ struct intel_guc {struct mutex send_mutex; }; +struct intel_huc { +/* Generic uC firmware management */ +struct intel_uc_fw fw; + +/* HuC-specific additions */ +}; +/* intel_uc.c */ void intel_uc_init_early (struct drm_i915_private *dev_priv);bool intel_guc_recv (struct drm_i915_private *dev_priv,u32 *status);
@@ -190,6 +200,9 @@ extern void intel_guc_fini(struct drm_i915_private *dev_priv);extern const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status);extern int intel_guc_suspend (struct drm_i915_private *dev_priv);extern int intel_guc_resume (struct drm_i915_private *dev_priv); +void intel_uc_fw_fetch (struct drm_i915_private *dev_priv, +struct intel_uc_fw *uc_fw); +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv);/* i915_guc_submission.c */ int i915_guc_submission_init (struct drm_i915_private *dev_priv);
@@ -204,4 +217,9 @@ void i915_guc_register(struct drm_i915_private *dev_priv);void i915_guc_unregister (struct drm_i915_private *dev_priv);int i915_guc_log_control (struct drm_i915_private *dev_priv,u64 control_val); +/* intel_huc_loader.c */ +void intel_huc_init (struct drm_i915_private *dev_priv); +void intel_huc_fini (struct drm_device *dev); +int intel_huc_load (struct drm_i915_private *dev_priv); +#endif
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/huc: Add HuC fw loading support
Quoted 167 lines · anushasr
From: Anusha Srivatsa <[email protected]>
The HuC loading process is similar to GuC. The
intel_uc_fw_fetch()is used for both cases.HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon) updatehuc_versionnumber of format.
v3: rebased to drm-intel-nightly, changed the file name format to
match the one in the huc package.
Changeddev->dev_privatetoto_i915()
v4: moved function back to where it was.
changewait_for_atomictowait_for.
v5: rebased + comment changes.
v7: rebased.
v8: rebased.
v9: rebased. Changed the year in the copyright message to reflect the right year.Correct the comments,remove the unwanted WARN message, replacedrm_gem_object_unreference()with i915_gem_object_put().Make the prototypes inintel_huc.hnon-extern.
v10: rebased. Update the file construction done by HuC. It is similar to GuC.Adopted the approach used in-
https://patchwork.freedesktop.org/patch/104355/ <Tvrtko Ursulin>
v11: Fix warnings remove old declaration
v12: Change dev todev_privin macro definition.
Corrected comments.
v13: rebased.
v14: rebased on top of drm-tip
v15: rebased. Updated functions intel_huc_load(),intel_huc_init() andintel_uc_fw_fetch()to acceptdev_privinstead of dev. Moved contents ofintel_huc.htointel_uc.h
v16: changeSKL_FW_toSKL_HUC_FW_. Addintel_prefix toguc_wopcm_size(). Remove unwanted checks inintel_uc.h. Renamehuc_fwin structintel_hucto simply fw to avoid redundency.Cc Tvrtko Ursulin <[email protected]>Tested-by Xiang Haihao <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_guc_reg.h | 3 + drivers/gpu/drm/i915/intel_guc_loader.c | 11 +- drivers/gpu/drm/i915/intel_huc_loader.c | 264 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 18 +++ 7 files changed, 297 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.cdrivers/gpu/drm/i915/Makefile +1
-0@@ -57,6 +57,7 @@ i915-y += i915_cmd_parser.o \ # general-purpose microcontroller (GuC) support i915-y += intel_uc.o \ intel_guc_loader.o \ + intel_huc_loader.o \ i915_guc_submission.o # autogenerated null render statedrivers/gpu/drm/i915/i915_drv.c +3
-1@@ -600,6 +600,7 @@ static int i915_load_modeset_init(struct drm_device *dev)if (ret) goto cleanup_irq; +intel_huc_init (dev_priv);intel_guc_init (dev_priv); ret =i915_gem_init (dev_priv);@@ -627,6 +628,7 @@ static int i915_load_modeset_init(struct drm_device *dev)DRM_ERROR ("failed to idle hardware; continuing to unload!\n" );i915_gem_fini (dev_priv); cleanup_irq: +intel_huc_fini (dev);intel_guc_fini (dev_priv);drm_irq_uninstall (dev);intel_teardown_gmbus (dev_priv);@@ -1313,7 +1315,7 @@ void i915_driver_unload(struct drm_device *dev)/* Flush any outstanding unpin_work. */ drain_workqueue (dev_priv->wq); - +intel_huc_fini (dev);intel_guc_fini (dev_priv);i915_gem_fini (dev_priv);intel_fbc_cleanup_cfb (dev_priv);drivers/gpu/drm/i915/i915_drv.h +2
-1@@ -2134,6 +2134,7 @@ struct drm_i915_private {struct intel_gvt *gvt; +struct intel_huc huc;struct intel_guc guc;struct intel_csr csr;@@ -2908,7 +2909,7 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_GUC (dev_priv) ((dev_priv)->info.has_guc)#define HAS_GUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_GUC_SCHED (dev_priv) (HAS_GUC(dev_priv)) - +#define HAS_HUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_RESOURCE_STREAMER (dev_priv) ((dev_priv)->info.has_resource_streamer)#define HAS_POOLED_EU (dev_priv) ((dev_priv)->info.has_pooled_eu)drivers/gpu/drm/i915/i915_guc_reg.h +3
-0@@ -61,9 +61,12 @@#define DMA_ADDRESS_SPACE_GTT (8 << 16)#define DMA_COPY_SIZE _MMIO(0xc310)#define DMA_CTRL _MMIO(0xc314) +#define HUC_UKERNEL (1<<9)#define UOS_MOVE (1<<4)#define START_DMA (1<<0)#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340) +#define HUC_LOADING_AGENT_VCR (0<<1) +#define HUC_LOADING_AGENT_GUC (1<<1)#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ #define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)drivers/gpu/drm/i915/intel_guc_loader.c +4
-4@@ -309,8 +309,8 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM );/* Finally start the DMA */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA )); - +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA ) | +_MASKED_BIT_DISABLE (HUC_UKERNEL ));/* * Wait for the DMA to complete & the GuC to start up. * NB: Docs recommend not using the interrupt for completion. @@ -334,7 +334,7 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,return ret; } -static u32 guc_wopcm_size (struct drm_i915_private *dev_priv) +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv) {u32 wopcm_size =GUC_WOPCM_TOP ;@@ -372,7 +372,7 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL );/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,guc_wopcm_size (dev_priv)); +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv));I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE );/* Enable MIA caching. GuC clock gating is disabled. */
drivers/gpu/drm/i915/intel_guc_loader.c int intel_guc_setup(struct drm_i915_private *dev_priv) · line 515
Quoted 5 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1
-0@@ -511,6 +511,7 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)if (err) goto fail; +intel_huc_load (dev_priv); err =guc_ucode_xfer (dev_priv);
Out of curiosity - how come it is OK to load HuC before the GuC, if the HuC needs the GuC?
Regards,
Tvrtko
Quoted 321 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1
-1if (!err)break ;@@ -658,7 +659,7 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, size = uc_fw->header_size + uc_fw->ucode_size;/* Top 32k of WOPCM is reserved (8K stack + 24k RC6 context). */ -if (size >guc_wopcm_size (dev_priv)) { +if (size >intel_guc_wopcm_size (dev_priv)) {DRM_ERROR ("Firmware is too large to fit in WOPCM\n" ); goto fail; }drivers/gpu/drm/i915/intel_huc_loader.c new file +264
-0@@ -0,0 +1,264 @@ +/* +* Copyright © 2016 Intel Corporation +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice (including the next +* paragraph) shall be included in all copies or substantial portions of the +* Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +* IN THE SOFTWARE. +* +*/ +#include <linux/firmware.h> +#include "i915_drv.h" +#include "intel_uc.h" + +/** +* DOC: HuC Firmware +* +* Motivation: +* GEN9 introduces a new dedicated firmware for usage in media HEVC (High +* Efficiency Video Coding) operations. Userspace can use the firmware +* capabilities by adding HuC specific commands to batch buffers. +* +* Implementation: +* The same firmware loader is used as the GuC. However, the actual +* loading to HW is deferred until GEM initialization is done. +* +* Note that HuC firmware loading must be done before GuC loading. +*/ + +#define SKL_HUC_FW_MAJOR 01 +#define SKL_HUC_FW_MINOR 07 +#define SKL_BLD_NUM 1398 + +#define HUC_FW_PATH (platform, major, minor, bld_num) \ + "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ + __stringify(minor) "_" __stringify(bld_num) ".bin" + +#define I915_SKL_HUC_UCODE HUC_FW_PATH(skl, SKL_HUC_FW_MAJOR, \ + SKL_HUC_FW_MINOR, SKL_BLD_NUM) +MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); + +/** +* huc_ucode_xfer() - DMA's the firmware +* @dev_priv: the drm device +* +* This function takes the gem object containing the firmware, sets up the DMA +* engine MMIO, triggers the DMA operation and waits for it to finish. +* +* Transfer the firmware image to RAM for execution by the microcontroller. +* +* Return: 0 on success, non-zero on failure +*/ + +static int huc_ucode_xfer (struct drm_i915_private *dev_priv) +{ +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; +struct i915_vma *vma; +unsigned long offset =0 ; +u32 size; +int ret; + + ret =i915_gem_object_set_to_gtt_domain (huc_fw->uc_fw_obj, false); +if (ret) { +DRM_DEBUG_DRIVER ("set-domain failed %d\n" , ret); +return ret; + } + + vma =i915_gem_object_ggtt_pin (huc_fw->uc_fw_obj,NULL ,0 ,0 ,0 ); +if (IS_ERR (vma)) { +DRM_DEBUG_DRIVER ("pin failed %d\n" , (int )PTR_ERR (vma)); +return PTR_ERR (vma); + } + +/* Invalidate GuC TLB to let GuC take the latest updates to GTT. */ +I915_WRITE (GEN8_GTCR ,GEN8_GTCR_INVALIDATE ); + +intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL ); + +/* init WOPCM */ +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv)); +I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE | +HUC_LOADING_AGENT_GUC ); + +/* Set the source address for the uCode */ + offset =i915_ggtt_offset (vma) + huc_fw->header_offset; +I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset)); +I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF ); + +/* Hardware doesn't look at destination address for HuC. Set it to 0, +* but still program the correct address space. +*/ +I915_WRITE (DMA_ADDR_1_LOW ,0 ); +I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM ); + + size = huc_fw->header_size + huc_fw->ucode_size; +I915_WRITE (DMA_COPY_SIZE , size); + +/* Start the DMA */ +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (HUC_UKERNEL |START_DMA )); + +/* Wait for DMA to finish */ + ret =wait_for ((I915_READ (DMA_CTRL ) &START_DMA ) ==0 ,100 ); + +DRM_DEBUG_DRIVER ("HuC DMA transfer wait over with ret %d\n" , ret); + +intel_uncore_forcewake_put (dev_priv,FORCEWAKE_ALL ); + +/* +* We keep the object pages for reuse during resume. But we can unpin it +* now that DMA has completed, so it doesn't continue to take up space. +*/ +i915_vma_unpin (vma); + +return ret; +} + +/** +* intel_huc_init() - initiate HuC firmware loading request +* @dev_priv: the drm_i915_private device +* +* Called early during driver load, but after GEM is initialised. The loading +* will continue only when driver explicitly specify firmware name and version. +* All other cases are considered as INTEL_UC_FIRMWARE_NONE either because HW +* is not capable or driver yet support it. And there will be no error message +* for INTEL_UC_FIRMWARE_NONE cases. +* +* The DMA-copying to HW is done later when intel_huc_load() is called. +*/ +void intel_huc_init (struct drm_i915_private *dev_priv) +{ +struct intel_huc *huc = &dev_priv->huc; +struct intel_uc_fw *huc_fw = &huc->fw; +const char *fw_path =NULL ; + + huc_fw->uc_fw_path =NULL ; + huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; + huc_fw->load_status =INTEL_UC_FIRMWARE_NONE ; + huc_fw->fw_type =INTEL_UC_FW_TYPE_HUC ; + +if (!HAS_HUC_UCODE (dev_priv)) +return ; + +if (IS_SKYLAKE (dev_priv)) { + fw_path =I915_SKL_HUC_UCODE ; + huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + } + + huc_fw->uc_fw_path = fw_path; + huc_fw->fetch_status =INTEL_UC_FIRMWARE_PENDING ; + +DRM_DEBUG_DRIVER ("HuC firmware pending, path %s\n" , fw_path); + +intel_uc_fw_fetch (dev_priv, huc_fw); +} + +/** +* intel_huc_load() - load HuC uCode to device +* @dev_priv: the drm_i915_private device +* +* Called from gem_init_hw() during driver loading and also after a GPU reset. +* Be note that HuC loading must be done before GuC loading. +* +* The firmware image should have already been fetched into memory by the +* earlier call to intel_huc_init(), so here we need only check that +* is succeeded, and then transfer the image to the h/w. +* +* Return: non-zero code on error +*/ +int intel_huc_load (struct drm_i915_private *dev_priv) +{ +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; +int err; + +if (huc_fw->fetch_status ==INTEL_UC_FIRMWARE_NONE ) +return 0 ; + +DRM_DEBUG_DRIVER ("%s fw status: fetch %s, load %s\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), +intel_uc_fw_status_repr (huc_fw->load_status)); + +if (huc_fw->fetch_status ==INTEL_UC_FIRMWARE_SUCCESS && + huc_fw->load_status ==INTEL_UC_FIRMWARE_FAIL ) +return -ENOEXEC ; + + huc_fw->load_status =INTEL_UC_FIRMWARE_PENDING ; + +switch (huc_fw->fetch_status) { +case INTEL_UC_FIRMWARE_FAIL : +/* something went wrong :( */ + err = -EIO ; + goto fail; + +case INTEL_UC_FIRMWARE_NONE : +case INTEL_UC_FIRMWARE_PENDING : +default : +/* "can't happen" */ +WARN_ONCE (1 ,"HuC fw %s invalid fetch_status %s [%d]\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), + huc_fw->fetch_status); + err = -ENXIO ; + goto fail; + +case INTEL_UC_FIRMWARE_SUCCESS : +break ; + } + + err =huc_ucode_xfer (dev_priv); +if (err) + goto fail; + + huc_fw->load_status =INTEL_UC_FIRMWARE_SUCCESS ; + +DRM_DEBUG_DRIVER ("%s fw status: fetch %s, load %s\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), +intel_uc_fw_status_repr (huc_fw->load_status)); + +return 0 ; + +fail: +if (huc_fw->load_status ==INTEL_UC_FIRMWARE_PENDING ) + huc_fw->load_status =INTEL_UC_FIRMWARE_FAIL ; + +DRM_ERROR ("Failed to complete HuC uCode load with ret %d\n" , err); + +return err; +} + +/** +* intel_huc_fini() - clean up resources allocated for HuC +* @dev: the drm device +* +* Cleans up by releasing the huc firmware GEM obj. +*/ +void intel_huc_fini (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; + +mutex_lock (&dev->struct_mutex); +if (huc_fw->uc_fw_obj) +i915_gem_object_put (huc_fw->uc_fw_obj); + huc_fw->uc_fw_obj =NULL ; +mutex_unlock (&dev->struct_mutex); + + huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; +} +drivers/gpu/drm/i915/intel_uc.h +13
-0@@ -24,6 +24,9 @@#ifndef _INTEL_UC_H_#define _INTEL_UC_H_ +#define HUC_STATUS2 _MMIO(0xD3B0) +#define HUC_FW_VERIFIED (1<<7) +#include "intel_guc_fwif.h" #include "i915_guc_reg.h" #include "intel_ringbuffer.h" @@ -174,6 +177,13 @@ struct intel_guc {struct mutex send_mutex; }; +struct intel_huc { +/* Generic uC firmware management */ +struct intel_uc_fw fw; + +/* HuC-specific additions */ +}; +/* intel_uc.c */ void intel_uc_init_early (struct drm_i915_private *dev_priv);bool intel_guc_recv (struct drm_i915_private *dev_priv,u32 *status);@@ -190,6 +200,9 @@ extern void intel_guc_fini(struct drm_i915_private *dev_priv);extern const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status);extern int intel_guc_suspend (struct drm_i915_private *dev_priv);extern int intel_guc_resume (struct drm_i915_private *dev_priv); +void intel_uc_fw_fetch (struct drm_i915_private *dev_priv, +struct intel_uc_fw *uc_fw); +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv);/* i915_guc_submission.c */ int i915_guc_submission_init (struct drm_i915_private *dev_priv);
drivers/gpu/drm/i915/intel_uc.h void i915_guc_register(struct drm_i915_private *dev_priv); · line 225
Quoted 9 lines
drivers/gpu/drm/i915/intel_uc.h +5
-0@@ -204,4 +217,9 @@ void i915_guc_register(struct drm_i915_private *dev_priv);void i915_guc_unregister (struct drm_i915_private *dev_priv);int i915_guc_log_control (struct drm_i915_private *dev_priv,u64 control_val); +/* intel_huc_loader.c */ +void intel_huc_init (struct drm_i915_private *dev_priv); +void intel_huc_fini (struct drm_device *dev); +int intel_huc_load (struct drm_i915_private *dev_priv); +#endif
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/huc: Add HuC fw loading support
Quoted 172 lines · Tvrtko Ursulin
Quoted 170 lines · anushasr
From: Anusha Srivatsa <[email protected]>
The HuC loading process is similar to GuC. The
intel_uc_fw_fetch()is used for both cases.HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon) updatehuc_versionnumber of format.
v3: rebased to drm-intel-nightly, changed the file name format to
match the one in the huc package.
Changeddev->dev_privatetoto_i915()
v4: moved function back to where it was.
changewait_for_atomictowait_for.
v5: rebased + comment changes.
v7: rebased.
v8: rebased.
v9: rebased. Changed the year in the copyright message to reflect the right year.Correct the comments,remove the unwanted WARN message, replacedrm_gem_object_unreference()with i915_gem_object_put().Make the prototypes inintel_huc.hnon-extern.
v10: rebased. Update the file construction done by HuC. It is similar to GuC.Adopted the approach used in-
https://patchwork.freedesktop.org/patch/104355/ <Tvrtko Ursulin>
v11: Fix warnings remove old declaration
v12: Change dev todev_privin macro definition.
Corrected comments.
v13: rebased.
v14: rebased on top of drm-tip
v15: rebased. Updated functions intel_huc_load(),intel_huc_init() andintel_uc_fw_fetch()to acceptdev_privinstead of dev. Moved contents ofintel_huc.htointel_uc.h
v16: changeSKL_FW_toSKL_HUC_FW_. Addintel_prefix toguc_wopcm_size(). Remove unwanted checks inintel_uc.h. Renamehuc_fwin structintel_hucto simply fw to avoid redundency.Cc Tvrtko Ursulin <[email protected]>Tested-by Xiang Haihao <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_guc_reg.h | 3 + drivers/gpu/drm/i915/intel_guc_loader.c | 11 +- drivers/gpu/drm/i915/intel_huc_loader.c | 264 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 18 +++ 7 files changed, 297 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.cdrivers/gpu/drm/i915/Makefile +1
-0@@ -57,6 +57,7 @@ i915-y += i915_cmd_parser.o \ # general-purpose microcontroller (GuC) support i915-y += intel_uc.o \ intel_guc_loader.o \ + intel_huc_loader.o \ i915_guc_submission.o # autogenerated null render statedrivers/gpu/drm/i915/i915_drv.c +3
-1@@ -600,6 +600,7 @@ static int i915_load_modeset_init(struct drm_device *dev)if (ret) goto cleanup_irq; +intel_huc_init (dev_priv);intel_guc_init (dev_priv); ret =i915_gem_init (dev_priv);@@ -627,6 +628,7 @@ static int i915_load_modeset_init(struct drm_device *dev)DRM_ERROR ("failed to idle hardware; continuing to unload!\n" );i915_gem_fini (dev_priv); cleanup_irq: +intel_huc_fini (dev);intel_guc_fini (dev_priv);drm_irq_uninstall (dev);intel_teardown_gmbus (dev_priv);@@ -1313,7 +1315,7 @@ void i915_driver_unload(struct drm_device *dev)/* Flush any outstanding unpin_work. */ drain_workqueue (dev_priv->wq); - +intel_huc_fini (dev);intel_guc_fini (dev_priv);i915_gem_fini (dev_priv);intel_fbc_cleanup_cfb (dev_priv);drivers/gpu/drm/i915/i915_drv.h +2
-1@@ -2134,6 +2134,7 @@ struct drm_i915_private {struct intel_gvt *gvt; +struct intel_huc huc;struct intel_guc guc;struct intel_csr csr;@@ -2908,7 +2909,7 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_GUC (dev_priv) ((dev_priv)->info.has_guc)#define HAS_GUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_GUC_SCHED (dev_priv) (HAS_GUC(dev_priv)) - +#define HAS_HUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_RESOURCE_STREAMER (dev_priv) ((dev_priv)->info.has_resource_streamer)#define HAS_POOLED_EU (dev_priv) ((dev_priv)->info.has_pooled_eu)drivers/gpu/drm/i915/i915_guc_reg.h +3
-0@@ -61,9 +61,12 @@#define DMA_ADDRESS_SPACE_GTT (8 << 16)#define DMA_COPY_SIZE _MMIO(0xc310)#define DMA_CTRL _MMIO(0xc314) +#define HUC_UKERNEL (1<<9)#define UOS_MOVE (1<<4)#define START_DMA (1<<0)#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340) +#define HUC_LOADING_AGENT_VCR (0<<1) +#define HUC_LOADING_AGENT_GUC (1<<1)#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ #define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)drivers/gpu/drm/i915/intel_guc_loader.c +4
-4@@ -309,8 +309,8 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM );/* Finally start the DMA */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA )); - +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA ) | +_MASKED_BIT_DISABLE (HUC_UKERNEL ));/* * Wait for the DMA to complete & the GuC to start up. * NB: Docs recommend not using the interrupt for completion. @@ -334,7 +334,7 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,return ret; } -static u32 guc_wopcm_size (struct drm_i915_private *dev_priv) +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv) {u32 wopcm_size =GUC_WOPCM_TOP ;@@ -372,7 +372,7 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL );/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,guc_wopcm_size (dev_priv)); +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv));I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE );/* Enable MIA caching. GuC clock gating is disabled. */ @@ -511,6 +511,7 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)if (err) goto fail;
Quoted 5 lines
drivers/gpu/drm/i915/intel_guc_loader.c int intel_guc_setup(struct drm_i915_private *dev_priv) · line 515
Quoted 2 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1
-0+intel_huc_load (dev_priv); err =guc_ucode_xfer (dev_priv);Out of curiosity - how come it is OK to load HuC before the GuC, if the HuC needs the GuC?
You just do the DMA transfer of the code to the memory and some initial setup, by any means it's not ready yet.
Then, you have to load GuC, which picks up that HuC is there and handles it presence internally (has to do with the checksums and signing verification).
From what I've seen this must be the exact ordering.
Then, when you have both in place, you can trigger authentication of HuC. Only after GuC has authed HuC successfully it's ready - you can start issuing HUC_* CS instructions.
Quoted 330 lines
Quoted 330 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1
-1if (!err)break ;@@ -658,7 +659,7 @@ void intel_uc_fw_fetch(struct drm_i915_private *dev_priv, size = uc_fw->header_size + uc_fw->ucode_size;/* Top 32k of WOPCM is reserved (8K stack + 24k RC6 context). */ -if (size >guc_wopcm_size (dev_priv)) { +if (size >intel_guc_wopcm_size (dev_priv)) {DRM_ERROR ("Firmware is too large to fit in WOPCM\n" ); goto fail; }drivers/gpu/drm/i915/intel_huc_loader.c new file +264
-0@@ -0,0 +1,264 @@ +/* +* Copyright © 2016 Intel Corporation +* +* Permission is hereby granted, free of charge, to any person obtaining a +* copy of this software and associated documentation files (the "Software"), +* to deal in the Software without restriction, including without limitation +* the rights to use, copy, modify, merge, publish, distribute, sublicense, +* and/or sell copies of the Software, and to permit persons to whom the +* Software is furnished to do so, subject to the following conditions: +* +* The above copyright notice and this permission notice (including the next +* paragraph) shall be included in all copies or substantial portions of the +* Software. +* +* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL +* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING +* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS +* IN THE SOFTWARE. +* +*/ +#include <linux/firmware.h> +#include "i915_drv.h" +#include "intel_uc.h" + +/** +* DOC: HuC Firmware +* +* Motivation: +* GEN9 introduces a new dedicated firmware for usage in media HEVC (High +* Efficiency Video Coding) operations. Userspace can use the firmware +* capabilities by adding HuC specific commands to batch buffers. +* +* Implementation: +* The same firmware loader is used as the GuC. However, the actual +* loading to HW is deferred until GEM initialization is done. +* +* Note that HuC firmware loading must be done before GuC loading. +*/ + +#define SKL_HUC_FW_MAJOR 01 +#define SKL_HUC_FW_MINOR 07 +#define SKL_BLD_NUM 1398 + +#define HUC_FW_PATH (platform, major, minor, bld_num) \ + "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ + __stringify(minor) "_" __stringify(bld_num) ".bin" + +#define I915_SKL_HUC_UCODE HUC_FW_PATH(skl, SKL_HUC_FW_MAJOR, \ + SKL_HUC_FW_MINOR, SKL_BLD_NUM) +MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); + +/** +* huc_ucode_xfer() - DMA's the firmware +* @dev_priv: the drm device +* +* This function takes the gem object containing the firmware, sets up the DMA +* engine MMIO, triggers the DMA operation and waits for it to finish. +* +* Transfer the firmware image to RAM for execution by the microcontroller. +* +* Return: 0 on success, non-zero on failure +*/ + +static int huc_ucode_xfer (struct drm_i915_private *dev_priv) +{ +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; +struct i915_vma *vma; +unsigned long offset =0 ; +u32 size; +int ret; + + ret =i915_gem_object_set_to_gtt_domain (huc_fw->uc_fw_obj, false); +if (ret) { +DRM_DEBUG_DRIVER ("set-domain failed %d\n" , ret); +return ret; + } + + vma =i915_gem_object_ggtt_pin (huc_fw->uc_fw_obj,NULL ,0 ,0 ,0 ); +if (IS_ERR (vma)) { +DRM_DEBUG_DRIVER ("pin failed %d\n" , (int )PTR_ERR (vma)); +return PTR_ERR (vma); + } + +/* Invalidate GuC TLB to let GuC take the latest updates to GTT. */ +I915_WRITE (GEN8_GTCR ,GEN8_GTCR_INVALIDATE ); + +intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL ); + +/* init WOPCM */ +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv)); +I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE | +HUC_LOADING_AGENT_GUC ); + +/* Set the source address for the uCode */ + offset =i915_ggtt_offset (vma) + huc_fw->header_offset; +I915_WRITE (DMA_ADDR_0_LOW ,lower_32_bits (offset)); +I915_WRITE (DMA_ADDR_0_HIGH ,upper_32_bits (offset) &0xFFFF ); + +/* Hardware doesn't look at destination address for HuC. Set it to 0, +* but still program the correct address space. +*/ +I915_WRITE (DMA_ADDR_1_LOW ,0 ); +I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM ); + + size = huc_fw->header_size + huc_fw->ucode_size; +I915_WRITE (DMA_COPY_SIZE , size); + +/* Start the DMA */ +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (HUC_UKERNEL |START_DMA )); + +/* Wait for DMA to finish */ + ret =wait_for ((I915_READ (DMA_CTRL ) &START_DMA ) ==0 ,100 ); + +DRM_DEBUG_DRIVER ("HuC DMA transfer wait over with ret %d\n" , ret); + +intel_uncore_forcewake_put (dev_priv,FORCEWAKE_ALL ); + +/* +* We keep the object pages for reuse during resume. But we can unpin it +* now that DMA has completed, so it doesn't continue to take up space. +*/ +i915_vma_unpin (vma); + +return ret; +} + +/** +* intel_huc_init() - initiate HuC firmware loading request +* @dev_priv: the drm_i915_private device +* +* Called early during driver load, but after GEM is initialised. The loading +* will continue only when driver explicitly specify firmware name and version. +* All other cases are considered as INTEL_UC_FIRMWARE_NONE either because HW +* is not capable or driver yet support it. And there will be no error message +* for INTEL_UC_FIRMWARE_NONE cases. +* +* The DMA-copying to HW is done later when intel_huc_load() is called. +*/ +void intel_huc_init (struct drm_i915_private *dev_priv) +{ +struct intel_huc *huc = &dev_priv->huc; +struct intel_uc_fw *huc_fw = &huc->fw; +const char *fw_path =NULL ; + + huc_fw->uc_fw_path =NULL ; + huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; + huc_fw->load_status =INTEL_UC_FIRMWARE_NONE ; + huc_fw->fw_type =INTEL_UC_FW_TYPE_HUC ; + +if (!HAS_HUC_UCODE (dev_priv)) +return ; + +if (IS_SKYLAKE (dev_priv)) { + fw_path =I915_SKL_HUC_UCODE ; + huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + } + + huc_fw->uc_fw_path = fw_path; + huc_fw->fetch_status =INTEL_UC_FIRMWARE_PENDING ; + +DRM_DEBUG_DRIVER ("HuC firmware pending, path %s\n" , fw_path); + +intel_uc_fw_fetch (dev_priv, huc_fw); +} + +/** +* intel_huc_load() - load HuC uCode to device +* @dev_priv: the drm_i915_private device +* +* Called from gem_init_hw() during driver loading and also after a GPU reset. +* Be note that HuC loading must be done before GuC loading. +* +* The firmware image should have already been fetched into memory by the +* earlier call to intel_huc_init(), so here we need only check that +* is succeeded, and then transfer the image to the h/w. +* +* Return: non-zero code on error +*/ +int intel_huc_load (struct drm_i915_private *dev_priv) +{ +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; +int err; + +if (huc_fw->fetch_status ==INTEL_UC_FIRMWARE_NONE ) +return 0 ; + +DRM_DEBUG_DRIVER ("%s fw status: fetch %s, load %s\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), +intel_uc_fw_status_repr (huc_fw->load_status)); + +if (huc_fw->fetch_status ==INTEL_UC_FIRMWARE_SUCCESS && + huc_fw->load_status ==INTEL_UC_FIRMWARE_FAIL ) +return -ENOEXEC ; + + huc_fw->load_status =INTEL_UC_FIRMWARE_PENDING ; + +switch (huc_fw->fetch_status) { +case INTEL_UC_FIRMWARE_FAIL : +/* something went wrong :( */ + err = -EIO ; + goto fail; + +case INTEL_UC_FIRMWARE_NONE : +case INTEL_UC_FIRMWARE_PENDING : +default : +/* "can't happen" */ +WARN_ONCE (1 ,"HuC fw %s invalid fetch_status %s [%d]\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), + huc_fw->fetch_status); + err = -ENXIO ; + goto fail; + +case INTEL_UC_FIRMWARE_SUCCESS : +break ; + } + + err =huc_ucode_xfer (dev_priv); +if (err) + goto fail; + + huc_fw->load_status =INTEL_UC_FIRMWARE_SUCCESS ; + +DRM_DEBUG_DRIVER ("%s fw status: fetch %s, load %s\n" , + huc_fw->uc_fw_path, +intel_uc_fw_status_repr (huc_fw->fetch_status), +intel_uc_fw_status_repr (huc_fw->load_status)); + +return 0 ; + +fail: +if (huc_fw->load_status ==INTEL_UC_FIRMWARE_PENDING ) + huc_fw->load_status =INTEL_UC_FIRMWARE_FAIL ; + +DRM_ERROR ("Failed to complete HuC uCode load with ret %d\n" , err); + +return err; +} + +/** +* intel_huc_fini() - clean up resources allocated for HuC +* @dev: the drm device +* +* Cleans up by releasing the huc firmware GEM obj. +*/ +void intel_huc_fini (struct drm_device *dev) +{ +struct drm_i915_private *dev_priv =to_i915 (dev); +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; + +mutex_lock (&dev->struct_mutex); +if (huc_fw->uc_fw_obj) +i915_gem_object_put (huc_fw->uc_fw_obj); + huc_fw->uc_fw_obj =NULL ; +mutex_unlock (&dev->struct_mutex); + + huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; +} +drivers/gpu/drm/i915/intel_uc.h +18
-0@@ -24,6 +24,9 @@#ifndef _INTEL_UC_H_#define _INTEL_UC_H_ +#define HUC_STATUS2 _MMIO(0xD3B0) +#define HUC_FW_VERIFIED (1<<7) +#include "intel_guc_fwif.h" #include "i915_guc_reg.h" #include "intel_ringbuffer.h" @@ -174,6 +177,13 @@ struct intel_guc {struct mutex send_mutex; }; +struct intel_huc { +/* Generic uC firmware management */ +struct intel_uc_fw fw; + +/* HuC-specific additions */ +}; +/* intel_uc.c */ void intel_uc_init_early (struct drm_i915_private *dev_priv);bool intel_guc_recv (struct drm_i915_private *dev_priv,u32 *status);@@ -190,6 +200,9 @@ extern void intel_guc_fini(struct drm_i915_private *dev_priv);extern const char *intel_uc_fw_status_repr (enum intel_uc_fw_status status);extern int intel_guc_suspend (struct drm_i915_private *dev_priv);extern int intel_guc_resume (struct drm_i915_private *dev_priv); +void intel_uc_fw_fetch (struct drm_i915_private *dev_priv, +struct intel_uc_fw *uc_fw); +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv);/* i915_guc_submission.c */ int i915_guc_submission_init (struct drm_i915_private *dev_priv);@@ -204,4 +217,9 @@ void i915_guc_register(struct drm_i915_private *dev_priv);void i915_guc_unregister (struct drm_i915_private *dev_priv);int i915_guc_log_control (struct drm_i915_private *dev_priv,u64 control_val); +/* intel_huc_loader.c */ +void intel_huc_init (struct drm_i915_private *dev_priv); +void intel_huc_fini (struct drm_device *dev); +int intel_huc_load (struct drm_i915_private *dev_priv); +#endif
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/8] drm/i915/huc: Add HuC fw loading support
Quoted 186 lines · Arkadiusz Hiler
Quoted 172 lines · Tvrtko Ursulin
Quoted 170 lines · anushasr
From: Anusha Srivatsa <[email protected]>
The HuC loading process is similar to GuC. The
intel_uc_fw_fetch()is used for both cases.HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them.
v2: rebased on-top of drm-intel-nightly.
removed if(HAS_GUC()) before the guc call. (D.Gordon) updatehuc_versionnumber of format.
v3: rebased to drm-intel-nightly, changed the file name format to
match the one in the huc package.
Changeddev->dev_privatetoto_i915()
v4: moved function back to where it was.
changewait_for_atomictowait_for.
v5: rebased + comment changes.
v7: rebased.
v8: rebased.
v9: rebased. Changed the year in the copyright message to reflect the right year.Correct the comments,remove the unwanted WARN message, replacedrm_gem_object_unreference()with i915_gem_object_put().Make the prototypes inintel_huc.hnon-extern.
v10: rebased. Update the file construction done by HuC. It is similar to GuC.Adopted the approach used in-
https://patchwork.freedesktop.org/patch/104355/ <Tvrtko Ursulin>
v11: Fix warnings remove old declaration
v12: Change dev todev_privin macro definition.
Corrected comments.
v13: rebased.
v14: rebased on top of drm-tip
v15: rebased. Updated functions intel_huc_load(),intel_huc_init() andintel_uc_fw_fetch()to acceptdev_privinstead of dev. Moved contents ofintel_huc.htointel_uc.h
v16: changeSKL_FW_toSKL_HUC_FW_. Addintel_prefix toguc_wopcm_size(). Remove unwanted checks inintel_uc.h. Renamehuc_fwin structintel_hucto simply fw to avoid redundency.Cc Tvrtko Ursulin <[email protected]>Tested-by Xiang Haihao <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 3 +- drivers/gpu/drm/i915/i915_guc_reg.h | 3 + drivers/gpu/drm/i915/intel_guc_loader.c | 11 +- drivers/gpu/drm/i915/intel_huc_loader.c | 264 ++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 18 +++ 7 files changed, 297 insertions(+), 7 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.cdrivers/gpu/drm/i915/Makefile +1
-0@@ -57,6 +57,7 @@ i915-y += i915_cmd_parser.o \ # general-purpose microcontroller (GuC) support i915-y += intel_uc.o \ intel_guc_loader.o \ + intel_huc_loader.o \ i915_guc_submission.o # autogenerated null render statedrivers/gpu/drm/i915/i915_drv.c +3
-1@@ -600,6 +600,7 @@ static int i915_load_modeset_init(struct drm_device *dev)if (ret) goto cleanup_irq; +intel_huc_init (dev_priv);intel_guc_init (dev_priv); ret =i915_gem_init (dev_priv);@@ -627,6 +628,7 @@ static int i915_load_modeset_init(struct drm_device *dev)DRM_ERROR ("failed to idle hardware; continuing to unload!\n" );i915_gem_fini (dev_priv); cleanup_irq: +intel_huc_fini (dev);intel_guc_fini (dev_priv);drm_irq_uninstall (dev);intel_teardown_gmbus (dev_priv);@@ -1313,7 +1315,7 @@ void i915_driver_unload(struct drm_device *dev)/* Flush any outstanding unpin_work. */ drain_workqueue (dev_priv->wq); - +intel_huc_fini (dev);intel_guc_fini (dev_priv);i915_gem_fini (dev_priv);intel_fbc_cleanup_cfb (dev_priv);drivers/gpu/drm/i915/i915_drv.h +2
-1@@ -2134,6 +2134,7 @@ struct drm_i915_private {struct intel_gvt *gvt; +struct intel_huc huc;struct intel_guc guc;struct intel_csr csr;@@ -2908,7 +2909,7 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_GUC (dev_priv) ((dev_priv)->info.has_guc)#define HAS_GUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_GUC_SCHED (dev_priv) (HAS_GUC(dev_priv)) - +#define HAS_HUC_UCODE (dev_priv) (HAS_GUC(dev_priv))#define HAS_RESOURCE_STREAMER (dev_priv) ((dev_priv)->info.has_resource_streamer)#define HAS_POOLED_EU (dev_priv) ((dev_priv)->info.has_pooled_eu)drivers/gpu/drm/i915/i915_guc_reg.h +3
-0@@ -61,9 +61,12 @@#define DMA_ADDRESS_SPACE_GTT (8 << 16)#define DMA_COPY_SIZE _MMIO(0xc310)#define DMA_CTRL _MMIO(0xc314) +#define HUC_UKERNEL (1<<9)#define UOS_MOVE (1<<4)#define START_DMA (1<<0)#define DMA_GUC_WOPCM_OFFSET _MMIO(0xc340) +#define HUC_LOADING_AGENT_VCR (0<<1) +#define HUC_LOADING_AGENT_GUC (1<<1)#define GUC_WOPCM_OFFSET_VALUE 0x80000/* 512KB */ #define GUC_MAX_IDLE_COUNT _MMIO(0xC3E4)drivers/gpu/drm/i915/intel_guc_loader.c +4
-4@@ -309,8 +309,8 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,I915_WRITE (DMA_ADDR_1_HIGH ,DMA_ADDRESS_SPACE_WOPCM );/* Finally start the DMA */ -I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA )); - +I915_WRITE (DMA_CTRL ,_MASKED_BIT_ENABLE (UOS_MOVE |START_DMA ) | +_MASKED_BIT_DISABLE (HUC_UKERNEL ));/* * Wait for the DMA to complete & the GuC to start up. * NB: Docs recommend not using the interrupt for completion. @@ -334,7 +334,7 @@ static int guc_ucode_xfer_dma(struct drm_i915_private *dev_priv,return ret; } -static u32 guc_wopcm_size (struct drm_i915_private *dev_priv) +u32 intel_guc_wopcm_size (struct drm_i915_private *dev_priv) {u32 wopcm_size =GUC_WOPCM_TOP ;@@ -372,7 +372,7 @@ static int guc_ucode_xfer(struct drm_i915_private *dev_priv)intel_uncore_forcewake_get (dev_priv,FORCEWAKE_ALL );/* init WOPCM */ -I915_WRITE (GUC_WOPCM_SIZE ,guc_wopcm_size (dev_priv)); +I915_WRITE (GUC_WOPCM_SIZE ,intel_guc_wopcm_size (dev_priv));I915_WRITE (DMA_GUC_WOPCM_OFFSET ,GUC_WOPCM_OFFSET_VALUE );/* Enable MIA caching. GuC clock gating is disabled. */ @@ -511,6 +511,7 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)if (err) goto fail;Quoted 5 lines
drivers/gpu/drm/i915/intel_guc_loader.c int intel_guc_setup(struct drm_i915_private *dev_priv) · line 515
Quoted 2 lines
drivers/gpu/drm/i915/intel_guc_loader.c +1
-0+intel_huc_load (dev_priv); err =guc_ucode_xfer (dev_priv);Out of curiosity - how come it is OK to load HuC before the GuC, if the HuC needs the GuC?
You just do the DMA transfer of the code to the memory and some initial setup, by any means it's not ready yet.
Then, you have to load GuC, which picks up that HuC is there and handles it presence internally (has to do with the checksums and signing verification).
Quoted 5 lines
From what I've seen this must be the exact ordering.
Then, when you have both in place, you can trigger authentication of HuC. Only after GuC has authed HuC successfully it's ready - you can start issuing HUC_* CS instructions.
Cool, thanks for explaining it.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/8 drm/i915/huc: Add BXT HuC Loading Support
In reply to anushasrFrom: Anusha Srivatsa <[email protected]>
This patch adds the HuC Loading for the BXT by using the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased.
v3: rebased on top of drm-tip
v4: rebased.
v5: rebased. Rename BXT_FW_MAJOR to BXT_HUC_FW_
--- drivers/gpu/drm/i915/intel_huc_loader.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/i915/intel_huc_loader.c +11 -0
@@ -40,6 +40,10 @@* Note that HuC firmware loading must be done before GuC loading. */ +#define BXT_HUC_FW_MAJOR 01 +#define BXT_HUC_FW_MINOR 07 +#define BXT_BLD_NUM 1398 +#define SKL_HUC_FW_MAJOR 01#define SKL_HUC_FW_MINOR 07#define SKL_BLD_NUM 1398
@@ -52,6 +56,9 @@ SKL_HUC_FW_MINOR, SKL_BLD_NUM)MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); +#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ + BXT_HUC_FW_MINOR, BXT_BLD_NUM) +MODULE_FIRMWARE (I915_BXT_HUC_UCODE );/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm device
@@ -157,6 +164,10 @@ void intel_huc_init(struct drm_i915_private *dev_priv) fw_path =I915_SKL_HUC_UCODE ; huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + }else if (IS_BROXTON (dev_priv)) { + fw_path =I915_BXT_HUC_UCODE ; + huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; } huc_fw->uc_fw_path = fw_path;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading Support
Quoted 35 lines · anushasr
From: Anusha Srivatsa <[email protected]>
This patch adds the HuC Loading for the BXT by using the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased.
v3: rebased on top of drm-tip
v4: rebased.
v5: rebased. RenameBXT_FW_MAJORtoBXT_HUC_FW_Cc Jeff Mcgee <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Jeff McGee <[email protected]>--- drivers/gpu/drm/i915/intel_huc_loader.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/gpu/drm/i915/intel_huc_loader.c +4
-0@@ -40,6 +40,10 @@* Note that HuC firmware loading must be done before GuC loading. */ +#define BXT_HUC_FW_MAJOR 01 +#define BXT_HUC_FW_MINOR 07 +#define BXT_BLD_NUM 1398 +#define SKL_HUC_FW_MAJOR 01#define SKL_HUC_FW_MINOR 07#define SKL_BLD_NUM 1398
drivers/gpu/drm/i915/intel_huc_loader.c line 61
Quoted 6 lines
drivers/gpu/drm/i915/intel_huc_loader.c +3
-0@@ -52,6 +56,9 @@ SKL_HUC_FW_MINOR, SKL_BLD_NUM)MODULE_FIRMWARE (I915_SKL_HUC_UCODE ); +#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ + BXT_HUC_FW_MINOR, BXT_BLD_NUM) +MODULE_FIRMWARE (I915_BXT_HUC_UCODE );
More curiosity - given the versions between SKL and BXT are identical - is it actually the same binary file in both cases?
Regards,
Tvrtko
Quoted 5 lines
drivers/gpu/drm/i915/intel_huc_loader.c +0
-0/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm device
drivers/gpu/drm/i915/intel_huc_loader.c void intel_huc_init(struct drm_i915_private *dev_priv) · line 173
Quoted 10 lines
drivers/gpu/drm/i915/intel_huc_loader.c +4
-0@@ -157,6 +164,10 @@ void intel_huc_init(struct drm_i915_private *dev_priv) fw_path =I915_SKL_HUC_UCODE ; huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + }else if (IS_BROXTON (dev_priv)) { + fw_path =I915_BXT_HUC_UCODE ; + huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; } huc_fw->uc_fw_path = fw_path;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading Support
Quoted 50 lines
-----Original Message-----
From: Tvrtko Ursulin [mailto:[email protected]]
Sent: Friday, December 16, 2016 8:16 AM
To: Srivatsa, Anusha <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 4/8] drm/i915/huc: Add BXT HuC Loading SupportQuoted 39 lines · anushasr
From: Anusha Srivatsa <[email protected]>
This patch adds the HuC Loading for the BXT by using the updated file construction.
Version 1.7 of the HuC firmware.
v2: rebased.
v3: rebased on top of drm-tip
v4: rebased.
v5: rebased. RenameBXT_FW_MAJORtoBXT_HUC_FW_Cc Jeff Mcgee <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Jeff McGee <[email protected]>--- drivers/gpu/drm/i915/intel_huc_loader.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/gpu/drm/i915/intel_huc_loader.c +4
-0@@ -40,6 +40,10 @@* Note that HuC firmware loading must be done before GuC loading. */ +#define BXT_HUC_FW_MAJOR 01 +#define BXT_HUC_FW_MINOR 07 +#define BXT_BLD_NUM 1398 +#define SKL_HUC_FW_MAJOR 01#define SKL_HUC_FW_MINOR 07#define SKL_BLD_NUM 1398@@ -52,6 +56,9 @@ SKL_HUC_FW_MINOR, SKL_BLD_NUM)MODULE_FIRMWARE (I915_SKL_HUC_UCODE );
Quoted 6 lines
drivers/gpu/drm/i915/intel_huc_loader.c line 61
Quoted 3 lines
drivers/gpu/drm/i915/intel_huc_loader.c +3
-0+#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ + BXT_HUC_FW_MINOR, BXT_BLD_NUM) +MODULE_FIRMWARE (I915_BXT_HUC_UCODE );More curiosity - given the versions between SKL and BXT are identical - is it actually the same binary file in both cases?
Hi Tvrtko its different binary file.
Cheers,
Anusha
Quoted 16 lines
Regards,
TvrtkoQuoted 13 lines
drivers/gpu/drm/i915/intel_huc_loader.c +4
-0/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm device @@ -157,6 +164,10 @@ void intel_huc_init(struct drm_i915_private *dev_priv) fw_path =I915_SKL_HUC_UCODE ; huc_fw->major_ver_wanted =SKL_HUC_FW_MAJOR ; huc_fw->minor_ver_wanted =SKL_HUC_FW_MINOR ; + }else if (IS_BROXTON (dev_priv)) { + fw_path =I915_BXT_HUC_UCODE ; + huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; }
Quoted 2 lines
drivers/gpu/drm/i915/intel_huc_loader.c void intel_huc_init(struct drm_i915_private *dev_priv) · line 173
Quoted 2 lines
drivers/gpu/drm/i915/intel_huc_loader.c +0
-0huc_fw->uc_fw_path = fw_path;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/8 drm/i915/HuC: Add KBL huC loading Support
In reply to anushasrFrom: Anusha Srivatsa <[email protected]>
This patch adds the support to load HuC on KBL
Version 2.0
v2: rebased.
v3: rebased on top of drm-tip
v4: rebased.
v5: rebased. Rename KBL_FW_ to KBL_HUC_FW_
--- drivers/gpu/drm/i915/intel_huc_loader.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)
drivers/gpu/drm/i915/intel_huc_loader.c +16 -0
@@ -48,6 +48,10 @@#define SKL_HUC_FW_MINOR 07#define SKL_BLD_NUM 1398 +#define KBL_HUC_FW_MAJOR 02 +#define KBL_HUC_FW_MINOR 00 +#define KBL_BLD_NUM 1810 +#define HUC_FW_PATH (platform, major, minor, bld_num) \ "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ __stringify(minor) "_" __stringify(bld_num) ".bin"
@@ -59,6 +63,11 @@ MODULE_FIRMWARE(I915_SKL_HUC_UCODE);#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ BXT_HUC_FW_MINOR, BXT_BLD_NUM)MODULE_FIRMWARE (I915_BXT_HUC_UCODE ); + +#define I915_KBL_HUC_UCODE HUC_FW_PATH(kbl, KBL_HUC_FW_MAJOR, \ + KBL_HUC_FW_MINOR, KBL_BLD_NUM) +MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); +/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm device
@@ -168,8 +177,15 @@ void intel_huc_init(struct drm_i915_private *dev_priv) fw_path =I915_BXT_HUC_UCODE ; huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ; huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; + }else if (IS_KABYLAKE (dev_priv)) { + fw_path =I915_KBL_HUC_UCODE ; + huc_fw->major_ver_wanted =KBL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =KBL_HUC_FW_MINOR ; } +if (fw_path ==NULL ) +return ; + huc_fw->uc_fw_path = fw_path; huc_fw->fetch_status =INTEL_UC_FIRMWARE_PENDING ;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 5/8] drm/i915/HuC: Add KBL huC loading Support
Quoted 47 lines · anushasr
From: Anusha Srivatsa <[email protected]>
This patch adds the support to load HuC on KBL
Version 2.0v2: rebased.
v3: rebased on top of drm-tip
v4: rebased.
v5: rebased. RenameKBL_FW_toKBL_HUC_FW_Cc Jeff Mcgee <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Jeff McGee <[email protected]>--- drivers/gpu/drm/i915/intel_huc_loader.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)drivers/gpu/drm/i915/intel_huc_loader.c +9
-0@@ -48,6 +48,10 @@#define SKL_HUC_FW_MINOR 07#define SKL_BLD_NUM 1398 +#define KBL_HUC_FW_MAJOR 02 +#define KBL_HUC_FW_MINOR 00 +#define KBL_BLD_NUM 1810 +#define HUC_FW_PATH (platform, major, minor, bld_num) \ "i915/" __stringify(platform) "_huc_ver" __stringify(major) "_" \ __stringify(minor) "_" __stringify(bld_num) ".bin"@@ -59,6 +63,11 @@ MODULE_FIRMWARE(I915_SKL_HUC_UCODE);#define I915_BXT_HUC_UCODE HUC_FW_PATH(bxt, BXT_HUC_FW_MAJOR, \ BXT_HUC_FW_MINOR, BXT_BLD_NUM)MODULE_FIRMWARE (I915_BXT_HUC_UCODE ); + +#define I915_KBL_HUC_UCODE HUC_FW_PATH(kbl, KBL_HUC_FW_MAJOR, \ + KBL_HUC_FW_MINOR, KBL_BLD_NUM) +MODULE_FIRMWARE (I915_KBL_HUC_UCODE ); +/** * huc_ucode_xfer() - DMA's the firmware * @dev_priv: the drm device @@ -168,8 +177,15 @@ void intel_huc_init(struct drm_i915_private *dev_priv) fw_path =I915_BXT_HUC_UCODE ; huc_fw->major_ver_wanted =BXT_HUC_FW_MAJOR ;
drivers/gpu/drm/i915/intel_huc_loader.c void intel_huc_init(struct drm_i915_private *dev_priv) · line 188
Quoted 10 lines
drivers/gpu/drm/i915/intel_huc_loader.c +7
-0huc_fw->minor_ver_wanted =BXT_HUC_FW_MINOR ; + }else if (IS_KABYLAKE (dev_priv)) { + fw_path =I915_KBL_HUC_UCODE ; + huc_fw->major_ver_wanted =KBL_HUC_FW_MAJOR ; + huc_fw->minor_ver_wanted =KBL_HUC_FW_MINOR ; } +if (fw_path ==NULL ) +return ; +
This looks suspiciously out of place in this patch. What's the reason for it?
Regards,
Tvrtko
drivers/gpu/drm/i915/intel_huc_loader.c void intel_huc_init(struct drm_i915_private *dev_priv) · line 191
Quoted 4 lines
drivers/gpu/drm/i915/intel_huc_loader.c +0
-0huc_fw->uc_fw_path = fw_path; huc_fw->fetch_status =INTEL_UC_FIRMWARE_PENDING ;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/8 drm/i915/huc: Add debugfs for HuC loading status check
In reply to anushasrFrom: Peter Antoine <[email protected]>
Add debugfs entry for HuC loading status check.
v2: rebase on-top of drm-intel-nightly.
v3: rebased again.
v7: rebased.
v8: rebased.
v9: rebased.
v10: rebased.
v11: rebased on top of drm-tip
v12: rebased.
--- drivers/gpu/drm/i915/i915_debugfs.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
drivers/gpu/drm/i915/i915_debugfs.c +31 -0
@@ -2325,6 +2325,36 @@ static int i915_llc(struct seq_file *m, void *data)return 0 ; } +static int i915_huc_load_status_info (struct seq_file *m,void *data) +{ +struct drm_i915_private *dev_priv =node_to_i915 (m->private); +struct intel_uc_fw *huc_fw = &dev_priv->huc.fw; + +if (!HAS_HUC_UCODE (dev_priv)) +return 0 ; + +seq_puts (m,"HuC firmware status:\n" ); +seq_printf (m,"\tpath: %s\n" , huc_fw->uc_fw_path); +seq_printf (m,"\tfetch: %s\n" , +intel_uc_fw_status_repr (huc_fw->fetch_status)); +seq_printf (m,"\tload: %s\n" , +intel_uc_fw_status_repr (huc_fw->load_status)); +seq_printf (m,"\tversion wanted: %d.%d\n" , + huc_fw->major_ver_wanted, huc_fw->minor_ver_wanted); +seq_printf (m,"\tversion found: %d.%d\n" , + huc_fw->major_ver_found, huc_fw->minor_ver_found); +seq_printf (m,"\theader: offset is %d; size = %d\n" , + huc_fw->header_offset, huc_fw->header_size); +seq_printf (m,"\tuCode: offset is %d; size = %d\n" , + huc_fw->ucode_offset, huc_fw->ucode_size); +seq_printf (m,"\tRSA: offset is %d; size = %d\n" , + huc_fw->rsa_offset, huc_fw->rsa_size); + +seq_printf (m,"\nHuC status 0x%08x:\n" ,I915_READ (HUC_STATUS2 )); + +return 0 ; +} +static int i915_guc_load_status_info (struct seq_file *m,void *data) {struct drm_i915_private *dev_priv =node_to_i915 (m->private);
@@ -4553,6 +4583,7 @@ static const struct drm_info_list i915_debugfs_list[] = { {"i915_guc_info", i915_guc_info, 0}, {"i915_guc_load_status", i915_guc_load_status_info, 0}, {"i915_guc_log_dump", i915_guc_log_dump, 0}, + {"i915_huc_load_status", i915_huc_load_status_info, 0}, {"i915_frequency_info", i915_frequency_info, 0}, {"i915_hangcheck_info", i915_hangcheck_info, 0}, {"i915_drpc_info", i915_drpc_info, 0},
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/8 drm/i915/huc: Support HuC authentication
In reply to anushasrFrom: Peter Antoine <[email protected]>
The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication.
v2: rebased on top of drm-intel-nightly.
changed name format and upped version 1.7.
v3: rebased on top of drm-intel-nightly.
v4: changed wait_for_automic to wait_for
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased. Rename intel_huc_auh() to intel_guc_auth_huc() and place the prototype in intel_guc.h,correct the comments.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased. Moved intel_guc_auth_huc from i915_guc_submission.c to intel_uc.c.Update dev to dev_priv in intel_guc_auth_huc(). Renamed HOST2GUC_ACTION_AUTHENTICATE_HUC TO INTEL_GUC_ACTION_ AUTHENTICATE_HUC
v14: rebased.
--- drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_guc_loader.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 62 +++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 1 + 4 files changed, 66 insertions(+)
drivers/gpu/drm/i915/intel_guc_fwif.h +1 -0
@@ -506,6 +506,7 @@ enum intel_guc_action {INTEL_GUC_ACTION_EXIT_S_STATE =0x502 ,INTEL_GUC_ACTION_SLPC_REQUEST =0x3003 ,INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING =0x0E000 , +INTEL_GUC_ACTION_AUTHENTICATE_HUC =0x4000 , INTEL_GUC_ACTION_LIMIT };
drivers/gpu/drm/i915/intel_guc_loader.c +2 -0
@@ -529,6 +529,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)intel_uc_fw_status_repr (guc_fw->fetch_status), intel_uc_fw_status_repr(guc_fw->load_status)); +intel_guc_auth_huc (dev_priv); +if (i915.enable_guc_submission) {if (i915.guc_log_level >=0 )gen9_enable_guc_interrupts (dev_priv);
drivers/gpu/drm/i915/intel_uc.c +62 -0
65 lines not on this page · raw message
drivers/gpu/drm/i915/intel_uc.h +1 -0
@@ -192,6 +192,7 @@ int intel_guc_sample_forcewake(struct intel_guc *guc);int intel_guc_log_flush_complete (struct intel_guc *guc);int intel_guc_log_flush (struct intel_guc *guc);int intel_guc_log_control (struct intel_guc *guc,u32 control_val); +void intel_guc_auth_huc (struct drm_i915_private *dev_priv);/* intel_guc_loader.c */ extern void intel_guc_init (struct drm_i915_private *dev_priv);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 7/8] drm/i915/huc: Support HuC authentication
Quoted 81 lines · anushasr
From: Peter Antoine <[email protected]>
The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication.
v2: rebased on top of drm-intel-nightly.
changed name format and upped version 1.7.
v3: rebased on top of drm-intel-nightly.
v4: changedwait_for_automictowait_for
v5: rebased.
v7: rebased.
v8: rebased.
v9: rebased. Renameintel_huc_auh()tointel_guc_auth_huc()and place the prototype in intel_guc.h,correct the comments.
v10: rebased.
v11: rebased.
v12: rebased on top of drm-tip
v13: rebased. Movedintel_guc_auth_hucfromi915_guc_submission.cto intel_uc.c.Update dev todev_privinintel_guc_auth_huc(). RenamedHOST2GUC_ACTION_AUTHENTICATE_HUCTOINTEL_GUC_ACTION_AUTHENTICATE_HUC
v14: rebased.Tested-by Xiang Haihao <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Signed-off-by Alex Dai <[email protected]>Signed-off-by Peter Antoine <[email protected]>--- drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drivers/gpu/drm/i915/intel_guc_loader.c | 2 ++ drivers/gpu/drm/i915/intel_uc.c | 62 +++++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_uc.h | 1 + 4 files changed, 66 insertions(+)drivers/gpu/drm/i915/intel_guc_fwif.h +1
-0@@ -506,6 +506,7 @@ enum intel_guc_action {INTEL_GUC_ACTION_EXIT_S_STATE =0x502 ,INTEL_GUC_ACTION_SLPC_REQUEST =0x3003 ,INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING =0x0E000 , +INTEL_GUC_ACTION_AUTHENTICATE_HUC =0x4000 , INTEL_GUC_ACTION_LIMIT };drivers/gpu/drm/i915/intel_guc_loader.c +2
-0@@ -529,6 +529,8 @@ int intel_guc_setup(struct drm_i915_private *dev_priv)intel_uc_fw_status_repr (guc_fw->fetch_status), intel_uc_fw_status_repr(guc_fw->load_status)); +intel_guc_auth_huc (dev_priv); +if (i915.enable_guc_submission) {if (i915.guc_log_level >=0 )gen9_enable_guc_interrupts (dev_priv);drivers/gpu/drm/i915/intel_uc.c +14
-0@@ -138,3 +138,65 @@ int intel_guc_log_control(struct intel_guc *guc, u32 control_val)return intel_guc_send (guc, action,ARRAY_SIZE (action)); } + +/** +* intel_guc_auth_huc() - authenticate ucode +* @dev_priv: the drm_i915_device +* +* Triggers a HuC fw authentication request to the GuC via intel_guc_action_ +* authenticate_huc interface. +* interface. +*/ +void intel_guc_auth_huc (struct drm_i915_private *dev_priv) +{ +struct intel_guc *guc = &dev_priv->guc; +struct intel_huc *huc = &dev_priv->huc; +struct i915_vma *vma;
drivers/gpu/drm/i915/intel_uc.c int intel_guc_log_control(struct intel_guc *guc, u32 control_val) · line 164
Quoted 10 lines
drivers/gpu/drm/i915/intel_uc.c +10
-0+int ret; +u32 data[2 ]; + +/* Bypass the case where there is no HuC firmware */ +if (huc->fw.fetch_status ==INTEL_UC_FIRMWARE_NONE || + huc->fw.load_status ==INTEL_UC_FIRMWARE_NONE ) +return ; + +if (guc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS ) { +DRM_ERROR ("HuC: GuC fw wasn't loaded. Can't authenticate" );
Why this DRM_ERROR does not have tailing "\n"?
Same goes for couple more in here.
Quoted 57 lines
drivers/gpu/drm/i915/intel_uc.c +38
-0+return ; + } + +if (huc->fw.load_status !=INTEL_UC_FIRMWARE_SUCCESS ) { +DRM_ERROR ("HuC: fw wasn't loaded. Nothing to authenticate" ); +return ; + } + + vma =i915_gem_object_ggtt_pin (huc->fw.uc_fw_obj,NULL ,0 ,0 ,0 ); +if (IS_ERR (vma)) { +DRM_DEBUG_DRIVER ("pin failed %d\n" , (int )PTR_ERR (vma)); +return ; + } + + +/* Invalidate GuC TLB to let GuC take the latest updates to GTT. */ +I915_WRITE (GEN8_GTCR ,GEN8_GTCR_INVALIDATE ); + +/* Specify auth action and where public signature is. */ + data[0 ] =INTEL_GUC_ACTION_AUTHENTICATE_HUC ; + data[1 ] =i915_ggtt_offset (vma) + huc->fw.rsa_offset; + + ret =intel_guc_send (guc, data,ARRAY_SIZE (data)); +if (ret) { +DRM_ERROR ("HuC: GuC did not ack Auth request\n" ); + goto out; + } + +/* Check authentication status, it should be done by now */ + ret =wait_for ((I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ) >0 ,50 ); +if (ret) { +DRM_ERROR ("HuC: Authentication failed\n" ); + goto out; + } + +out: +i915_vma_unpin (vma); +}drivers/gpu/drm/i915/intel_uc.h +1
-0@@ -192,6 +192,7 @@ int intel_guc_sample_forcewake(struct intel_guc *guc);int intel_guc_log_flush_complete (struct intel_guc *guc);int intel_guc_log_flush (struct intel_guc *guc);int intel_guc_log_control (struct intel_guc *guc,u32 control_val); +void intel_guc_auth_huc (struct drm_i915_private *dev_priv);/* intel_guc_loader.c */ extern void intel_guc_init (struct drm_i915_private *dev_priv);Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/8 drm/i915/get_params: Add HuC status to getparams
In reply to anushasrFrom: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)
v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference to intel_huc.h
v7: rebased. Rename I915_PARAM_HAS_HUC to I915_PARAM_HUC_STATUS. Remove intel_is_huc_valid() since it is used only in one place. Put the case of I915_PARAM_HAS_HUC() in the right place.
--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +4 -0
@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;
@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ; +break ;case I915_PARAM_MMAP_GTT_VERSION :/* Though we've started our numbering from 1, and so class all * earlier versions as 0, in effect their value is undefined as
drivers/gpu/drm/i915/intel_huc_loader.c +0 -1
@@ -288,4 +288,3 @@ void intel_huc_fini(struct drm_device *dev) huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; } -
include/uapi/drm/i915_drm.h +1 -0
@@ -395,6 +395,7 @@ typedef struct drm_i915_irq_wait {* priorities and the driver will attempt to execute batches in priority order. */ #define I915_PARAM_HAS_SCHEDULER 41 +#define I915_PARAM_HUC_STATUS 42 typedef struct drm_i915_getparam { __s32 param;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 38 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data, · line 320
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ;
Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 38 lines · Chris Wilson
Quoted 37 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;
Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data, · line 320
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ;Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-Chris
I get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming device
consistently from:
value = I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);
value = I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);
Quoted 6 lines
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 61 lines · Arkadiusz Hiler
Quoted 38 lines · Chris Wilson
Quoted 37 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data, · line 320
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ;Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-ChrisI get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
Quoted 7 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);
Also do the test with i915.mmio_debug=9999
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 66 lines · Chris Wilson
Quoted 65 lines · Arkadiusz Hiler
Quoted 38 lines · Chris Wilson
Quoted 37 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data, · line 320
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ;Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-ChrisI get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);
Quoted 6 lines
Quoted 3 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);Also do the test with i915.mmio_debug=9999
-Chris
Same effect. Works.
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 67 lines · Arkadiusz Hiler
Quoted 66 lines · Chris Wilson
Quoted 65 lines · Arkadiusz Hiler
Quoted 38 lines · Chris Wilson
Quoted 37 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;Quoted 11 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data, · line 320
Quoted 6 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ;Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-ChrisI get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2 POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);Also do the test with i915.mmio_debug=9999
-ChrisSame effect. Works.
Ok, then just mark up that we don't need rpm here so that we don't freak out in future scans for mmio access outside of rpm.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 55 lines
-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Friday, December 16, 2016 8:31 AM
To: Hiler, Arkadiusz <[email protected]>
Cc: Srivatsa, Anusha <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparamsQuoted 12 lines · Arkadiusz Hiler
Quoted 11 lines · Chris Wilson
Quoted 10 lines · Arkadiusz Hiler
Quoted 9 lines · Chris Wilson
Quoted 8 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCto
I915_PARAM_HUC_STATUS.Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Quoted 24 lines
Remove
intel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.cindex 85a47c2..0bc016d 100644drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;
Quoted 36 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device
Quoted 1 line
drivers/gpu/drm/i915/i915_drv.c +0
-0@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device*dev, void *data,
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device *dev, void *data,
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value = I915_READ(HUC_STATUS2) &
HUC_FW_VERIFIED;Quoted 28 lines
Quoted 21 lines
Quoted 21 lines
Quoted 5 lines
Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-ChrisI get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]]
HUC_STATUS2POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);Quoted 5 lines
Quoted 3 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);Also do the test with i915.mmio_debug=9999 -Chris
Same effect. Works.
Thanks Arek for confirming.
Quoted 3 lines
Ok, then just mark up that we don't need rpm here so that we don't freak out in future scans for mmio access outside of rpm.
-Chris
Chris, v2 as changed by Tvrtko suggests that forcewakes are removed since the register is force waken. Are you suggesting that adding that rpm not being required in the commit message will make things much more clearer?
Anusha
Quoted 3 lines
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 90 lines · Anusha
Quoted 90 lines
-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Friday, December 16, 2016 8:31 AM
To: Hiler, Arkadiusz <[email protected]>
Cc: Srivatsa, Anusha <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparamsQuoted 12 lines · Arkadiusz Hiler
Quoted 11 lines · Chris Wilson
Quoted 10 lines · Arkadiusz Hiler
Quoted 9 lines · Chris Wilson
Quoted 8 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCto
I915_PARAM_HUC_STATUS.Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Remove
intel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.cindex 85a47c2..0bc016d 100644drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device
Quoted 3 lines
drivers/gpu/drm/i915/i915_drv.c +0
-0static struct drm_driver driver;@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device*dev, void *data,
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c static int i915_getparam(struct drm_device · line 320
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value = I915_READ(HUC_STATUS2) &
HUC_FW_VERIFIED;Quoted 27 lines
Quoted 26 lines
Quoted 17 lines
Quoted 5 lines
Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register.
-ChrisI get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]] HUC_STATUS2PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]]
HUC_STATUS2POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
Quoted 7 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);Also do the test with i915.mmio_debug=9999 -Chris
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Same effect. Works.
Thanks Arek for confirming.
Quoted 3 lines
Ok, then just mark up that we don't need rpm here so that we don't freak out in future scans for mmio access outside of rpm.
-ChrisChris, v2 as changed by Tvrtko suggests that forcewakes are removed since the register is force waken. Are you suggesting that adding that rpm not being required in the commit message will make things much more clearer?
No, if you are eschewing taking rpm around mmio access, I want that commented upon in the code so that it is visible the next time we do an audit for rpm abuse/misuse.
-Chris
Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
Quoted 110 lines
-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Friday, December 16, 2016 10:47 AM
To: Srivatsa, Anusha <[email protected]>
Cc: Hiler, Arkadiusz <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparamsQuoted 15 lines · Anusha
Quoted 15 lines
-----Original Message-----
From: Chris Wilson [mailto:[email protected]]
Sent: Friday, December 16, 2016 8:31 AM
To: Hiler, Arkadiusz <[email protected]>
Cc: Srivatsa, Anusha <[email protected]>; intel- [email protected]
Subject: Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparamsQuoted 3 lines · Arkadiusz Hiler
Quoted 2 lines · Chris Wilson
Quoted 1 line · Arkadiusz Hiler
On Thu, Dec 15, 2016 at 10:42:53PM +0000, Chris Wilson wrote:
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · anushasr
Quoted 7 lines
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses
the validated status to show when the HuC is loaded and
ready for use. You cannot use the loaded status as with the
GuC as the HuC is verified after it is loaded and is not usable until it isverified.
Quoted 75 lines
Quoted 35 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCto
I915_PARAM_HUC_STATUS.Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Quoted 22 lines
Remove
intel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_drv.cindex 85a47c2..0bc016d 100644drivers/gpu/drm/i915/i915_drv.c +1
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/i915_drv.c +0
-0static struct drm_driver driver;@@ -315,6 +316,9 @@ static int i915_getparam(struct
drm_device*dev, void *data,
Quoted 35 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c
Quoted 5 lines
drivers/gpu/drm/i915/i915_drv.c +2
-0case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value = I915_READ(HUC_STATUS2) &
HUC_FW_VERIFIED;Quoted 29 lines
Quoted 22 lines
Quoted 22 lines
Quoted 5 lines
Same question as last time: does the device need to be awake? We know is one of the GT power wells, so presumably we need an rpm_get/rpm_put as well to access the register. -Chris
I get:
[ 1588.570174] [drm:i915_huc_load_status_info [i915]]
HUC_STATUS2PRE 24704 [ 1588.571285] [drm:intel_runtime_suspend [i915]] Suspending device [ 1588.575768] [drm:intel_runtime_suspend [i915]] Device suspended [ 1588.577156] [drm:i915_huc_load_status_info [i915]]HUC_STATUS2POST 24704 [ 1588.578259] [drm:intel_runtime_resume [i915]] Resuming deviceconsistently from:
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 PRE %d\n", value);i915_pm_ops.runtime_suspend(dev_priv->drm.dev);Quoted 5 lines
Quoted 3 lines
value =
I915_READ(HUC_STATUS2);DRM_DEBUG_DRIVER("HUC_STATUS2 POST %d\n", value);i915_pm_ops.runtime_resume(dev_priv->drm.dev);Also do the test with i915.mmio_debug=9999 -Chris
Same effect. Works.
Thanks Arek for confirming.
Quoted 3 lines
Ok, then just mark up that we don't need rpm here so that we don't freak out in future scans for mmio access outside of rpm. -Chris
Quoted 7 lines
Quoted 1 line
Chris, v2 as changed by Tvrtko suggests that forcewakes are removed since the
register is force waken. Are you suggesting that adding that rpm not being required in the commit message will make things much more clearer?
No, if you are eschewing taking rpm around mmio access, I want that commented upon in the code so that it is visible the next time we do an audit for rpm abuse/misuse.
Ah! Got it. Thanks.
Cheers,
Anusha
Quoted 4 lines
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams
In reply to anushasrQuoted 17 lines · anushasr
From: Peter Antoine <[email protected]>
This patch will allow for getparams to return the status of the HuC. As the HuC has to be validated by the GuC this patch uses the validated status to show when the HuC is loaded and ready for use. You cannot use the loaded status as with the GuC as the HuC is verified after it is loaded and is not usable until it is verified.
v2: removed the forewakes as the registers are already force-woken.
(T.Ursulin)v4: rebased.
v5: rebased on top of drm-tip.
v6: rebased. Removed any reference tointel_huc.h
v7: rebased. RenameI915_PARAM_HAS_HUCtoI915_PARAM_HUC_STATUS. Removeintel_is_huc_valid()since it is used only in one place. Put the case ofI915_PARAM_HAS_HUC()in the right place.
Quoted 2 lines
Signed-off-by Peter Antoine <[email protected]>Reviewed-by Arkadiusz Hiler <[email protected]>
You've retained my rb without asking me.
With the changes you've made and confirmation that MEDIA FW that I915_READ() assumes:
Quoted 56 lines
--- drivers/gpu/drm/i915/i915_drv.c | 4 ++++ drivers/gpu/drm/i915/intel_huc_loader.c | 1 - include/uapi/drm/i915_drm.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.c +4
-0@@ -49,6 +49,7 @@#include "i915_trace.h" #include "i915_vgpu.h" #include "intel_drv.h" +#include "intel_uc.h" static struct drm_driver driver;@@ -315,6 +316,9 @@ static int i915_getparam(struct drm_device *dev, void *data,case I915_PARAM_MIN_EU_IN_POOL : value =INTEL_INFO (dev_priv)->sseu.min_eu_in_pool;break ; +case I915_PARAM_HUC_STATUS : + value =I915_READ (HUC_STATUS2 ) &HUC_FW_VERIFIED ; +break ;case I915_PARAM_MMAP_GTT_VERSION :/* Though we've started our numbering from 1, and so class all * earlier versions as 0, in effect their value is undefined as drivers/gpu/drm/i915/intel_huc_loader.c +0
-1@@ -288,4 +288,3 @@ void intel_huc_fini(struct drm_device *dev) huc_fw->fetch_status =INTEL_UC_FIRMWARE_NONE ; } -include/uapi/drm/i915_drm.h +1
-0@@ -395,6 +395,7 @@ typedef struct drm_i915_irq_wait {* priorities and the driver will attempt to execute batches in priority order. */ #define I915_PARAM_HAS_SCHEDULER 41 +#define I915_PARAM_HUC_STATUS 42 typedef struct drm_i915_getparam { __s32 param;Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for HuC Loading Patches
In reply to anushasr== Series Details ==
== Series Details ==
Series: HuC Loading Patches
URL : https://patchwork.freedesktop.org/series/16878/
State : success
== Summary ==
Series 16878v1 HuC Loading Patches
https://patchwork.freedesktop.org/api/1.0/series/16878/revisions/1/mbox/
fi-bdw-5557u total:247 pass:233 dwarn:0 dfail:0 fail:0 skip:14 fi-bsw-n3050 total:247 pass:208 dwarn:0 dfail:0 fail:0 skip:39 fi-bxt-j4205 total:247 pass:222 dwarn:0 dfail:0 fail:0 skip:25 fi-bxt-t5700 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-j1900 total:247 pass:220 dwarn:0 dfail:0 fail:0 skip:27 fi-byt-n2820 total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31 fi-hsw-4770 total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19 fi-hsw-4770r total:247 pass:228 dwarn:0 dfail:0 fail:0 skip:19 fi-ilk-650 total:247 pass:195 dwarn:0 dfail:0 fail:0 skip:52 fi-ivb-3520m total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21 fi-kbl-7500u total:247 pass:226 dwarn:0 dfail:0 fail:0 skip:21 fi-skl-6260u total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13 fi-skl-6700hq total:247 pass:227 dwarn:0 dfail:0 fail:0 skip:20 fi-skl-6700k total:247 pass:224 dwarn:3 dfail:0 fail:0 skip:20 fi-skl-6770hq total:247 pass:234 dwarn:0 dfail:0 fail:0 skip:13 fi-snb-2520m total:247 pass:216 dwarn:0 dfail:0 fail:0 skip:31 fi-snb-2600 total:247 pass:215 dwarn:0 dfail:0 fail:0 skip:32
639f10d1159e87cac2f85769dcd081520b904f56 drm-tip: 2016y-12m-15d-17h-57m-41s UTC integration manifest 0bbec17 drm/i915/get_params: Add HuC status to getparams
8f0431a drm/i915/huc: Support HuC authentication
b77b638 drm/i915/huc: Add debugfs for HuC loading status check
378c8c0 drm/i915/HuC: Add KBL huC loading Support
561449c drm/i915/huc: Add BXT HuC Loading Support
0b52fc6 drm/i915/huc: Add HuC fw loading support
c850b01 drm/i915/huc: Unified css_header struct for GuC and HuC
5ddedaa drm/i915/guc: Make the GuC fw loading helper functions general
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3302/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx