Skip to contentSkip to conversation

i40e: Support for XDP

PATCH Superseded Björn Töpel 4 participants 17 messages Dec 17, 2016 – Feb 6, 2017

Subsystems (2)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v4 cover i40e: Support for XDP

From: Bj?rn T?pel <[email protected]>

This series adds XDP support for i40e-based NICs.

The first patch prepares i40e_fetch_rx_buffer() for upcoming changes, followed by XDP_RX support, the third adds XDP_TX support and the last patch validates bpf_xdp_adjust_head() support.

Thanks to Alex, Daniel, John and Scott for all the feedback!

v4:
* Removed unused i40e_page_is_reserved function
* Prior running the XDP program, set the struct xdp_buff data_hard_start member

v3:
* Rebased patch set on Jeff's dev-queue branch
* MSI-X is no longer a prerequisite for XDP
* RCU locking for the XDP program and XDP_RX support is introduced in the same patch
* Rx bytes is now bumped for XDP
* Removed pointer-to-pointer clunkiness
* Added comments to XDP preconditions in ndo_xdp
* When a non-EOF is received, log once, and drop the frame

v2:
* Fixed kbuild error for PAGE_SIZE >= 8192.
* Renamed i40e_try_flip_rx_page to i40e_can_reuse_rx_page, which is more in line to the other Intel Ethernet drivers (igb/fm10k).
* Validate xdp_adjust_head support in ndo_xdp/XDP_SETUP_PROG.

Bj?rn

Bj?rn T?pel (4):
i40e: Sync DMA region prior skbuff allocation
i40e: Initial support for XDP
i40e: Add XDP_TX support
i40e: Validate xdp_adjust_head support

 drivers/net/ethernet/intel/i40e/i40e.h         |  18 ++
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |   4 +
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 380 ++++++++++++++++++++----
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 383 ++++++++++++++++++++++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   7 +
 5 files changed, 703 insertions(+), 89 deletions(-)
Signature · 1 line
2.9.3
#1 lore raw

PATCH v4 1/4 i40e: Sync DMA region prior skbuff allocation

From: Bj?rn T?pel <[email protected]>

This patch prepares i40e_fetch_rx_buffer() for upcoming XDP support, where there's a need to access the device buffers prior skbuff allocation.

---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_txrx.c +7 -7
index 9de05a0e8201..8bdc95c9e9b7 100644
@@ -1646,6 +1646,13 @@ struct sk_buff *i40e_fetch_rx_buffer(struct i40e_ring *rx_ring,
 	page = rx_buffer->page;
 	prefetchw(page);
 
+	/* we are reusing so sync this buffer for CPU use */
+	dma_sync_single_range_for_cpu(rx_ring->dev,
+				      rx_buffer->dma,
+				      rx_buffer->page_offset,
+				      size,
+				      DMA_FROM_DEVICE);
+
 	if (likely(!skb)) {
 		void *page_addr = page_address(page) + rx_buffer->page_offset;
 
@@ -1671,13 +1678,6 @@ struct sk_buff *i40e_fetch_rx_buffer(struct i40e_ring *rx_ring,
 		prefetchw(skb->data);
 	}
 
-	/* we are reusing so sync this buffer for CPU use */
-	dma_sync_single_range_for_cpu(rx_ring->dev,
-				      rx_buffer->dma,
-				      rx_buffer->page_offset,
-				      size,
-				      DMA_FROM_DEVICE);
-
 	/* pull page into skb */
 	if (i40e_add_rx_frag(rx_ring, rx_buffer, size, skb)) {
 		/* hand second half of page back to the ring */
Signature · 1 line
2.9.3
#2 lore raw

PATCH v4 1/4 i40e: Sync DMA region prior skbuff allocation

Quoted 13 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bj?rn T?pel
Sent: Saturday, December 17, 2016 5:40 AM
To: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: daniel at iogearbox.net; Topel, Bjorn <[email protected]>; Karlsson, Magnus <[email protected]>
Subject: [Intel-wired-lan] [PATCH v4 1/4] i40e: Sync DMA region prior skbuff allocation

From: Bj?rn T?pel <[email protected]>

Quoted 7 lines

This patch prepares i40e_fetch_rx_buffer() for upcoming XDP support, where there's a need to access the device buffers prior skbuff allocation.

---
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Does not break base driver

#3 lore raw

PATCH v4 2/4 i40e: Initial support for XDP

In reply to Björn Töpel

From: Bj?rn T?pel <[email protected]>

This commit adds basic XDP support for i40e derived NICs. All XDP actions will end up in XDP_DROP.

Only the default/main VSI has support for enabling XDP.

---
 drivers/net/ethernet/intel/i40e/i40e.h         |  13 +++
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |   4 +
 drivers/net/ethernet/intel/i40e/i40e_main.c    |  83 +++++++++++++++++
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 124 +++++++++++++++++++++++--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   2 +
 5 files changed, 220 insertions(+), 6 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +13 -0
index 19a296d46023..5382d4782396 100644
@@ -589,6 +589,8 @@ struct i40e_vsi {
 	struct i40e_ring **rx_rings;
 	struct i40e_ring **tx_rings;
 
+	bool xdp_enabled;
+
 	u32  active_filters;
 	u32  promisc_threshold;
 
@@ -948,4 +950,15 @@ i40e_status i40e_get_npar_bw_setting(struct i40e_pf *pf);
 i40e_status i40e_set_npar_bw_setting(struct i40e_pf *pf);
 i40e_status i40e_commit_npar_bw_setting(struct i40e_pf *pf);
 void i40e_print_link_message(struct i40e_vsi *vsi, bool isup);
+
+/**
+ * i40e_enabled_xdp_vsi - Check if VSI has XDP enabled
+ * @vsi: pointer to a vsi
+ *
+ * Returns true if the VSI has XDP enabled.
+ **/
+static inline bool i40e_enabled_xdp_vsi(const struct i40e_vsi *vsi)
+{
+	return !!vsi->xdp_enabled;
+}
 #endif /* _I40E_H_ */
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +4 -0
index dece0d676482..ccb3b77405d7 100644
@@ -1257,6 +1257,10 @@ static int i40e_set_ringparam(struct net_device *netdev,
 	if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
 		return -EINVAL;
 
+	/* Don't allow any change while XDP is enabled. */
+	if (i40e_enabled_xdp_vsi(vsi))
+		return -EINVAL;
+
 	if (ring->tx_pending > I40E_MAX_NUM_DESCRIPTORS ||
 	    ring->tx_pending < I40E_MIN_NUM_DESCRIPTORS ||
 	    ring->rx_pending > I40E_MAX_NUM_DESCRIPTORS ||
drivers/net/ethernet/intel/i40e/i40e_main.c +83 -0

114 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_txrx.c +118 -6

186 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_txrx.h +2 -0
index f80979025c01..78d0aa0468f1 100644
@@ -361,6 +361,8 @@ struct i40e_ring {
 					 * i40e_clean_rx_ring_irq() is called
 					 * for this ring.
 					 */
+
+	struct bpf_prog __rcu *xdp_prog;
 } ____cacheline_internodealigned_in_smp;
 
 enum i40e_latency_range {
Signature · 1 line
2.9.3
#4 lore raw

PATCH v4 2/4 i40e: Initial support for XDP

Quoted 18 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bj?rn T?pel
Sent: Saturday, December 17, 2016 5:40 AM
To: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: daniel at iogearbox.net; Topel, Bjorn <[email protected]>; Karlsson, Magnus <[email protected]>
Subject: [Intel-wired-lan] [PATCH v4 2/4] i40e: Initial support for XDP

From: Bj?rn T?pel <[email protected]>

This commit adds basic XDP support for i40e derived NICs. All XDP actions will end up in XDP_DROP.

Only the default/main VSI has support for enabling XDP.

Quoted 8 lines
---
 drivers/net/ethernet/intel/i40e/i40e.h         |  13 +++
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |   4 +
 drivers/net/ethernet/intel/i40e/i40e_main.c    |  83 +++++++++++++++++
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 124
+++++++++++++++++++++++--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   2 +
 5 files changed, 220 insertions(+), 6 deletions(-)

Does not break base driver

#5 lore raw

PATCH v4 3/4 i40e: Add XDP_TX support

In reply to Björn Töpel

From: Bj?rn T?pel <[email protected]>

This patch adds proper XDP_TX support.

---
 drivers/net/ethernet/intel/i40e/i40e.h      |   5 +
 drivers/net/ethernet/intel/i40e/i40e_main.c | 294 +++++++++++++++++++++++-----
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 255 +++++++++++++++++++++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.h |   5 +
 4 files changed, 478 insertions(+), 81 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +5 -0
index 5382d4782396..1b0fadaf6fc9 100644
@@ -589,6 +589,10 @@ struct i40e_vsi {
 	struct i40e_ring **rx_rings;
 	struct i40e_ring **tx_rings;
 
+	/* The XDP rings are Tx only, and follows the count of the
+	 * regular rings, i.e. alloc_queue_pairs/num_queue_pairs
+	 */
+	struct i40e_ring **xdp_rings;
 	bool xdp_enabled;
 
 	u32  active_filters;
@@ -666,6 +670,7 @@ struct i40e_q_vector {
 
 	struct i40e_ring_container rx;
 	struct i40e_ring_container tx;
+	struct i40e_ring_container xdp;
 
 	u8 num_ringpairs;	/* total number of ring pairs in vector */
 
drivers/net/ethernet/intel/i40e/i40e_main.c +241 -53

483 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_txrx.c +227 -28

315 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_txrx.h +5 -0
index 78d0aa0468f1..3250be70271d 100644
@@ -233,6 +233,7 @@ static inline unsigned int i40e_txd_use_count(unsigned int size)
 #define I40E_TX_FLAGS_TSYN		BIT(8)
 #define I40E_TX_FLAGS_FD_SB		BIT(9)
 #define I40E_TX_FLAGS_UDP_TUNNEL	BIT(10)
+#define I40E_TX_FLAGS_XDP		BIT(11)
 #define I40E_TX_FLAGS_VLAN_MASK		0xffff0000
 #define I40E_TX_FLAGS_VLAN_PRIO_MASK	0xe0000000
 #define I40E_TX_FLAGS_VLAN_PRIO_SHIFT	29
@@ -243,6 +244,7 @@ struct i40e_tx_buffer {
 	union {
 		struct sk_buff *skb;
 		void *raw_buf;
+		struct page *page;
 	};
 	unsigned int bytecount;
 	unsigned short gso_segs;
@@ -363,6 +365,9 @@ struct i40e_ring {
 					 */
 
 	struct bpf_prog __rcu *xdp_prog;
+	struct i40e_ring *xdp_sibling;  /* rx to xdp, and xdp to rx */
+	bool xdp_needs_tail_bump;
+	u16 curr_in_use;
 } ____cacheline_internodealigned_in_smp;
 
 enum i40e_latency_range {
Signature · 1 line
2.9.3
#6 lore raw

PATCH v4 3/4 i40e: Add XDP_TX support

Quoted 15 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bj?rn T?pel
Sent: Saturday, December 17, 2016 5:40 AM
To: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: daniel at iogearbox.net; Topel, Bjorn <[email protected]>; Karlsson, Magnus <[email protected]>
Subject: [Intel-wired-lan] [PATCH v4 3/4] i40e: Add XDP_TX support

From: Bj?rn T?pel <[email protected]>

This patch adds proper XDP_TX support.

Quoted 8 lines
---
 drivers/net/ethernet/intel/i40e/i40e.h      |   5 +
 drivers/net/ethernet/intel/i40e/i40e_main.c | 294
+++++++++++++++++++++++-----
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 255
+++++++++++++++++++++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.h |   5 +
 4 files changed, 478 insertions(+), 81 deletions(-)

Does not break base driver

#7 lore raw

PATCH v4 4/4 i40e: Validate xdp_adjust_head support

In reply to Björn Töpel

From: Bj?rn T?pel <[email protected]>

This patch will tell the user that bpf_xdp_adjust_head() is currently not supported.

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_main.c +3 -0
index efb95fb851f4..94eed585a01b 100644
@@ -9545,6 +9545,9 @@ static int i40e_xdp_setup(struct i40e_vsi *vsi,
 	bool need_reset;
 	struct bpf_prog *old_prog;
 
+	if (prog && prog->xdp_adjust_head)
+		return -EOPNOTSUPP;
+
 	/* The Rx frame has to fit in 2k */
 	if (frame_size > I40E_RXBUFFER_2048)
 		return -EINVAL;
Signature · 1 line
2.9.3
#8 lore raw

PATCH v4 4/4 i40e: Validate xdp_adjust_head support

Quoted 13 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Bj?rn T?pel
Sent: Saturday, December 17, 2016 5:40 AM
To: Kirsher, Jeffrey T <[email protected]>; intel-wired- lan at lists.osuosl.org
Cc: daniel at iogearbox.net; Topel, Bjorn <[email protected]>; Karlsson, Magnus <[email protected]>
Subject: [Intel-wired-lan] [PATCH v4 4/4] i40e: Validate xdp_adjust_head support

From: Bj?rn T?pel <[email protected]>

Quoted 7 lines

This patch will tell the user that bpf_xdp_adjust_head() is currently not supported.

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++
 1 file changed, 3 insertions(+)

Does not break base driver

#9 lore raw

v4 cover i40e: Support for XDP

In reply to Björn Töpel

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

- Alex

Quoted 55 lines · Bj?rn T?pel

From: Bj?rn T?pel <[email protected]>

This series adds XDP support for i40e-based NICs.

The first patch prepares i40e_fetch_rx_buffer() for upcoming changes, followed by XDP_RX support, the third adds XDP_TX support and the last patch validates bpf_xdp_adjust_head() support.

Thanks to Alex, Daniel, John and Scott for all the feedback!

v4:
* Removed unused i40e_page_is_reserved function
* Prior running the XDP program, set the struct xdp_buff data_hard_start member

v3:
* Rebased patch set on Jeff's dev-queue branch
* MSI-X is no longer a prerequisite for XDP
* RCU locking for the XDP program and XDP_RX support is introduced in the same patch
* Rx bytes is now bumped for XDP
* Removed pointer-to-pointer clunkiness
* Added comments to XDP preconditions in ndo_xdp
* When a non-EOF is received, log once, and drop the frame

v2:
* Fixed kbuild error for PAGE_SIZE >= 8192.
* Renamed i40e_try_flip_rx_page to i40e_can_reuse_rx_page, which is more in line to the other Intel Ethernet drivers (igb/fm10k).
* Validate xdp_adjust_head support in ndo_xdp/XDP_SETUP_PROG.

Bj?rn

Bj?rn T?pel (4):
i40e: Sync DMA region prior skbuff allocation
i40e: Initial support for XDP
i40e: Add XDP_TX support
i40e: Validate xdp_adjust_head support

 drivers/net/ethernet/intel/i40e/i40e.h         |  18 ++
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |   4 +
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 380 ++++++++++++++++++++----
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 383 ++++++++++++++++++++++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   7 +
 5 files changed, 703 insertions(+), 89 deletions(-)

--
2.9.3

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at lists.osuosl.org
http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#10 lore raw

v4 cover i40e: Support for XDP

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Thanks for bringing this up!
Bj?rn

Quoted 59 lines

- Alex

Quoted 55 lines · Bj?rn T?pel

From: Bj?rn T?pel <[email protected]>

This series adds XDP support for i40e-based NICs.

The first patch prepares i40e_fetch_rx_buffer() for upcoming changes, followed by XDP_RX support, the third adds XDP_TX support and the last patch validates bpf_xdp_adjust_head() support.

Thanks to Alex, Daniel, John and Scott for all the feedback!

v4:
* Removed unused i40e_page_is_reserved function
* Prior running the XDP program, set the struct xdp_buff data_hard_start member

v3:
* Rebased patch set on Jeff's dev-queue branch
* MSI-X is no longer a prerequisite for XDP
* RCU locking for the XDP program and XDP_RX support is introduced in the same patch
* Rx bytes is now bumped for XDP
* Removed pointer-to-pointer clunkiness
* Added comments to XDP preconditions in ndo_xdp
* When a non-EOF is received, log once, and drop the frame

v2:
* Fixed kbuild error for PAGE_SIZE >= 8192.
* Renamed i40e_try_flip_rx_page to i40e_can_reuse_rx_page, which is more in line to the other Intel Ethernet drivers (igb/fm10k).
* Validate xdp_adjust_head support in ndo_xdp/XDP_SETUP_PROG.

Bj?rn

Bj?rn T?pel (4):
i40e: Sync DMA region prior skbuff allocation
i40e: Initial support for XDP
i40e: Add XDP_TX support
i40e: Validate xdp_adjust_head support

 drivers/net/ethernet/intel/i40e/i40e.h         |  18 ++
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |   4 +
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 380 ++++++++++++++++++++----
 drivers/net/ethernet/intel/i40e/i40e_txrx.c    | 383 ++++++++++++++++++++++---
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    |   7 +
 5 files changed, 703 insertions(+), 89 deletions(-)

--
2.9.3

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan at lists.osuosl.org
http://lists.osuosl.org/mailman/listinfo/intel-wired-lan

#11 lore raw

v4 cover i40e: Support for XDP

Quoted 10 lines · Bj?rn T?pel

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

It makes the upstreaming process easier for us since we normally work out of tree and then upstream patches after testing in the case of i40e.

Quoted 3 lines

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Yeah, I'll be working on providing headroom in order to support build_skb anyway so I can just combine the efforts. Then it makes the upstreaming effort easier as well as we will have the headroom added before we actually start work on XDP.

Thanks.

- Alex

#12 lore raw

v4 cover i40e: Support for XDP

2017-02-01 22:32 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 8 lines · Bj?rn T?pel
Quoted 7 lines

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Quoted 7 lines
Quoted 3 lines

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

It makes the upstreaming process easier for us since we normally work out of tree and then upstream patches after testing in the case of i40e.

Makes sense. So, I guess Jeff needs to pull out the XDP patches from the dev-queue branch then.

Jeff, please remove the XDP patch set from the dev-queue.

Cheers,
Bj?rn

Quoted 13 lines
Quoted 4 lines

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Yeah, I'll be working on providing headroom in order to support build_skb anyway so I can just combine the efforts. Then it makes the upstreaming effort easier as well as we will have the headroom added before we actually start work on XDP.

Thanks.

- Alex

#13 lore raw

v4 cover i40e: Support for XDP

In reply to Alexander Duyck
Quoted 8 lines · Alexander Duyck
Quoted 7 lines · Bj?rn T?pel

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Quoted 8 lines
Quoted 3 lines

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

It makes the upstreaming process easier for us since we normally work out of tree and then upstream patches after testing in the case of i40e.

Any hints on when we can expect a v5 to show up? I have a few folks pulling these outside Intel that are waiting to get these patches.

Quoted 13 lines
Quoted 3 lines

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Yeah, I'll be working on providing headroom in order to support build_skb anyway so I can just combine the efforts. Then it makes the upstreaming effort easier as well as we will have the headroom added before we actually start work on XDP.

Thanks.

- Alex

#14 lore raw

v4 cover i40e: Support for XDP

It would likely be several weeks. I am still trying to finish up the out-of-tree build_skb changes for i40e. Once I have that then I can start working on the XDP bits.

My guess would be that these would probably end up in the 4.12 kernel when everything is said and done.

- Alex

Quoted 35 lines · John Fastabend
Quoted 8 lines · Alexander Duyck
Quoted 7 lines · Bj?rn T?pel

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Quoted 8 lines
Quoted 3 lines

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

It makes the upstreaming process easier for us since we normally work out of tree and then upstream patches after testing in the case of i40e.

Any hints on when we can expect a v5 to show up? I have a few folks pulling these outside Intel that are waiting to get these patches.

Quoted 13 lines
Quoted 3 lines

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Yeah, I'll be working on providing headroom in order to support build_skb anyway so I can just combine the efforts. Then it makes the upstreaming effort easier as well as we will have the headroom added before we actually start work on XDP.

Thanks.

- Alex

#15 lore raw

v4 cover i40e: Support for XDP

Quoted 6 lines · Alexander Duyck

It would likely be several weeks. I am still trying to finish up the out-of-tree build_skb changes for i40e. Once I have that then I can start working on the XDP bits.

My guess would be that these would probably end up in the 4.12 kernel when everything is said and done.

OK, iirc though ixgbe already has these changes and we can add XDP support without any delays there?

I have a handful of folks wanting to test/use this with adjust_header support so for the time being I'm going to push a fork to my github branch for folks to pull. But the sooner the better for mainline support.

Thanks,
John

Quoted 39 lines

- Alex

Quoted 35 lines · John Fastabend
Quoted 8 lines · Alexander Duyck
Quoted 7 lines · Bj?rn T?pel

2017-01-31 22:37 GMT+01:00 Alexander Duyck <[email protected]>:

Quoted 5 lines

We probably need to respin this and do a v5 of the XDP code so that we can reserve some headroom at the start of the frames. I have patches I already working on to enable build_skb like I have done for igb and ixgbe. I can probably take on respinning this and getting it applied to our out-of-tree driver.

Quoted 8 lines
Quoted 3 lines

Respinning or an additional patch for the xdp_adjust_head() support? Maybe it's better to respin it, so we get proper xdp_adjust_head() support, prior upstreaming.

It makes the upstreaming process easier for us since we normally work out of tree and then upstream patches after testing in the case of i40e.

Any hints on when we can expect a v5 to show up? I have a few folks pulling these outside Intel that are waiting to get these patches.

Quoted 13 lines
Quoted 3 lines

If headroom support for XDP aligns nicely into your build_skb patches for i40e, feel free to do that! If not, let me know, and I'll start working on it.

Yeah, I'll be working on providing headroom in order to support build_skb anyway so I can just combine the efforts. Then it makes the upstreaming effort easier as well as we will have the headroom added before we actually start work on XDP.

Thanks.

- Alex

#16 lore raw

v4 cover i40e: Support for XDP

Quoted 11 lines · John Fastabend
Quoted 6 lines · Alexander Duyck

It would likely be several weeks. I am still trying to finish up the out-of-tree build_skb changes for i40e. Once I have that then I can start working on the XDP bits.

My guess would be that these would probably end up in the 4.12 kernel when everything is said and done.

OK, iirc though ixgbe already has these changes and we can add XDP support without any delays there?

Quoted 7 lines

I have a handful of folks wanting to test/use this with adjust_header support so for the time being I'm going to push a fork to my github branch for folks to pull. But the sooner the better for mainline support.

Thanks,
John

Agreed. I will try to get this completed ASAP, and you can work with the fork in the meantime.

Thanks.

- Alex