Skip to contentSkip to conversation

staging: vc04_services: Fix bracing on single statement blocks

PATCH In review Aaron Moore 2 participants 2 messages Dec 18, 2016 – Dec 19, 2016

Subsystems (2)
Staging Broadcom BCM2711/BCM2835 Arm architecture
lore
Share & tools
lore

Aaron Moore

author
#0 lore raw

PATCH 1/1 staging: vc04_services: Fix bracing on single statement blocks

Fix coding style issue caught by checkpatch.pl relating to braces on single statement blocks. This issue was corrected in 3 locations.

Signed-off-by Aaron Moore <[email protected]>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_util.c +3 -6
index f76f4d7..e0ba0ed 100644
@@ -80,9 +80,8 @@ void vchiu_queue_push(VCHIU_QUEUE_T *queue, VCHIQ_HEADER_T *header)
 		return;
 
 	while (queue->write == queue->read + queue->size) {
-		if (down_interruptible(&queue->pop) != 0) {
+		if (down_interruptible(&queue->pop) != 0)
 			flush_signals(current);
-		}
 	}
 
 	/*

@@ -107,9 +106,8 @@ void vchiu_queue_push(VCHIU_QUEUE_T *queue, VCHIQ_HEADER_T *header)
 VCHIQ_HEADER_T *vchiu_queue_peek(VCHIU_QUEUE_T *queue)
 {
 	while (queue->write == queue->read) {
-		if (down_interruptible(&queue->push) != 0) {
+		if (down_interruptible(&queue->push) != 0)
 			flush_signals(current);
-		}
 	}
 
 	up(&queue->push); // We haven't removed anything from the queue.

@@ -128,9 +126,8 @@ VCHIQ_HEADER_T *vchiu_queue_pop(VCHIU_QUEUE_T *queue)
 	VCHIQ_HEADER_T *header;
 
 	while (queue->write == queue->read) {
-		if (down_interruptible(&queue->push) != 0) {
+		if (down_interruptible(&queue->push) != 0)
 			flush_signals(current);
-		}
 	}
 
 	/*
Signature · 1 line
2.10.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Aaron Moore

Fix coding style issue caught by checkpatch.pl relating to braces on single statement blocks. This issue was corrected in 3 locations.

Signed-off-by Aaron Moore <[email protected]>
Reviewed-by Eric Anholt <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161219/f7d2dc40/attachment.sig>