Skip to contentSkip to conversation

ARM: dts: sun4i: A1000: add axp209 regulator nodes

PATCH Superseded codekipper at gmail.com 2 participants 3 messages Dec 20, 2016

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

codekipper at gmail.com

author
#0 lore raw

PATCH 1/1 ARM: dts: sun4i: A1000: add axp209 regulator nodes

From: Marcus Cooper <[email protected]>

This patch adds the regulator nodes for the axp209 by including the axp209 dtsi.

Signed-off-by Marcus Cooper <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10-a1000.dts | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-a1000.dts +34 -0
index 68c6bdb2cf7c..e7394d701856 100644
@@ -196,6 +196,40 @@
 	};
 };
 
+#include "axp209.dtsi"
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1250000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_ldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2800000>;
+	regulator-max-microvolt = <2800000>;
+	regulator-name = "vcc-wifi";
+};
+
 &reg_usb1_vbus {
 	status = "okay";
 };
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 ARM: dts: sun4i: A1000: add axp209 regulator nodes

Quoted 40 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

This patch adds the regulator nodes for the axp209 by including the axp209 dtsi.

Signed-off-by Marcus Cooper <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10-a1000.dts | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-a1000.dts +22 -0
index 68c6bdb2cf7c..e7394d701856 100644
@@ -196,6 +196,40 @@
 	};
 };
 
+#include "axp209.dtsi"
+
+&reg_dcdc2 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1400000>;
+	regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+	regulator-always-on;
+	regulator-min-microvolt = <1000000>;
+	regulator-max-microvolt = <1250000>;
+	regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+	regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+	regulator-always-on;

arch/arm/boot/dts/sun4i-a10-a1000.dts line 230

Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts +10 -0
+	regulator-min-microvolt = <3000000>;
+	regulator-max-microvolt = <3000000>;
+	regulator-name = "avcc";
+};
+
+&reg_ldo3 {
+	regulator-always-on;
+	regulator-min-microvolt = <2800000>;
+	regulator-max-microvolt = <2800000>;
+	regulator-name = "vcc-wifi";

If this is used only for the wifi, there's no point in keeping it enabled.

Also, taking the chance to enable cpufreq by setting the cpu-suplly property would be a good idea.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161220/6f56d8f4/attachment-0001.sig>
author
#2 lore raw

PATCH 1/1 ARM: dts: sun4i: A1000: add axp209 regulator nodes

Quoted 55 lines · Maxime Ripard
Quoted 40 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

This patch adds the regulator nodes for the axp209 by including the axp209 dtsi.

Signed-off-by Marcus Cooper <[email protected]>
---
 arch/arm/boot/dts/sun4i-a10-a1000.dts | 34 ++++++++++++++++++++++++++++++++++
 1 file changed, 34 insertions(+)
arch/arm/boot/dts/sun4i-a10-a1000.dts +22 -0
index 68c6bdb2cf7c..e7394d701856 100644
@@ -196,6 +196,40 @@
      };
 };
 
+#include "axp209.dtsi"
+
+&reg_dcdc2 {
+     regulator-always-on;
+     regulator-min-microvolt = <1000000>;
+     regulator-max-microvolt = <1400000>;
+     regulator-name = "vdd-cpu";
+};
+
+&reg_dcdc3 {
+     regulator-always-on;
+     regulator-min-microvolt = <1000000>;
+     regulator-max-microvolt = <1250000>;
+     regulator-name = "vdd-int-dll";
+};
+
+&reg_ldo1 {
+     regulator-name = "vdd-rtc";
+};
+
+&reg_ldo2 {
+     regulator-always-on;

arch/arm/boot/dts/sun4i-a10-a1000.dts line 230

Quoted 10 lines
arch/arm/boot/dts/sun4i-a10-a1000.dts +10 -0
+     regulator-min-microvolt = <3000000>;
+     regulator-max-microvolt = <3000000>;
+     regulator-name = "avcc";
+};
+
+&reg_ldo3 {
+     regulator-always-on;
+     regulator-min-microvolt = <2800000>;
+     regulator-max-microvolt = <2800000>;
+     regulator-name = "vcc-wifi";

If this is used only for the wifi, there's no point in keeping it enabled.

Quoted 2 lines

Also, taking the chance to enable cpufreq by setting the cpu-suplly property would be a good idea.

Ack....fortunately my A1000 was out of it's box as I've been looking at the channel reversal issue. I'll respin now.
CK

Quoted 8 lines

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com