Skip to contentSkip to conversation

staging: lustre: selftest: Make brw_inject_one_error() static

PATCH In review Karthik Nayak 3 participants 3 messages Dec 23, 2016 – Jan 13, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: lustre: selftest: Make brw_inject_one_error() static

Since the function brw_inject_one_error() is used only within brw_test.c, make it static. This was reported as a warning by sparse.

---
 drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lnet/selftest/brw_test.c +1 -1
index 67b460f..b9ac34e 100644
@@ -136,7 +136,7 @@ brw_client_init(struct sfw_test_instance *tsi)
 	return 0;
 }
 
-int brw_inject_one_error(void)
+static int brw_inject_one_error(void)
 {
 	struct timespec64 ts;
 
Signature · 1 line
2.10.2
maintainer
#1 lore raw
Quoted 7 lines · Karthik Nayak

Since the function brw_inject_one_error() is used only within brw_test.c, make it static. This was reported as a warning by sparse.

---
 drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Someone else sent this same patch before you did, sorry :(

Reviewed-by on v1 1/1
#2 lore raw
In reply to Karthik Nayak
Quoted 5 lines · Karthik Nayak

Since the function brw_inject_one_error() is used only within brw_test.c, make it static. This was reported as a warning by sparse.

Quoted 24 lines

---
drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lnet/selftest/brw_test.c +1 -1
index 67b460f..b9ac34e 100644
@@ -136,7 +136,7 @@ brw_client_init(struct sfw_test_instance *tsi)
 	return 0;
 }
 
-int brw_inject_one_error(void)
+static int brw_inject_one_error(void)
 {
 	struct timespec64 ts;
 
Signature · 6 lines
2.10.2

_______________________________________________
lustre-devel mailing list
lustre-devel at lists.lustre.org
http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org