Skip to contentSkip to conversation

pci: hotplug: This patch removes unnecessary return statement using spatch tool

PATCH Applied Rahul Krishnan 3 participants 4 messages Dec 24, 2016 – Jan 12, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 pci: hotplug: This patch removes unnecessary return statement using spatch tool

This patch removes unnecessary return statement using spatch tool

---
 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/hotplug/rpadlpar_core.c +1 -3
index dc67f39..78ce2c7 100644
@@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
 
 int __init rpadlpar_io_init(void)
 {
-	int rc = 0;
 
 	if (!is_dlpar_capable()) {
 		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
@@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
 		return -EPERM;
 	}
 
-	rc = dlpar_sysfs_init();
-	return rc;
+	return dlpar_sysfs_init();
 }
 
 void rpadlpar_io_exit(void)
Signature · 1 line
2.7.4
Reviewed-by on v2 1/1
#1 lore raw
Quoted 4 lines · Rahul Krishnan

This patch removes unnecessary return statement using spatch tool

Quoted 27 lines
---
 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/hotplug/rpadlpar_core.c +1 -3
index dc67f39..78ce2c7 100644
@@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
 
 int __init rpadlpar_io_init(void)
 {
-	int rc = 0;
 
 	if (!is_dlpar_capable()) {
 		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
@@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
 		return -EPERM;
 	}
 
-	rc = dlpar_sysfs_init();
-	return rc;
+	return dlpar_sysfs_init();
 }
 
 void rpadlpar_io_exit(void)
#2 lore raw
In reply to Rahul Krishnan
Quoted 4 lines · Rahul Krishnan

This patch removes unnecessary return statement using spatch tool

Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks!

Are there other similar instances elsewhere in drivers/pci? If so, can you fix them all at once?

Quoted 33 lines
---
 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/hotplug/rpadlpar_core.c +1 -3
index dc67f39..78ce2c7 100644
@@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
 
 int __init rpadlpar_io_init(void)
 {
-	int rc = 0;
 
 	if (!is_dlpar_capable()) {
 		printk(KERN_WARNING "%s: partition not DLPAR capable\n",
@@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
 		return -EPERM;
 	}
 
-	rc = dlpar_sysfs_init();
-	return rc;
+	return dlpar_sysfs_init();
 }
 
 void rpadlpar_io_exit(void)
Signature · 6 lines
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 11 lines · Bjorn Helgaas
Quoted 4 lines · Rahul Krishnan

This patch removes unnecessary return statement using spatch tool

Applied to pci/hotplug for v4.11 with Tyrel's Reviewed-by, thanks!

Are there other similar instances elsewhere in drivers/pci? If so, can you fix them all at once?

​
Yes, I will look into it immediately. Thank you​

Quoted 36 lines

drivers/pci/hotplug/

Quoted 6 lines
---
 drivers/pci/hotplug/rpadlpar_core.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/hotplug/ renamed from drivers/pci/hotplug/rpadlpar_core.c +0 -0

rpadlpar_core.c

Quoted 28 lines

index dc67f39..78ce2c7 100644

drivers/pci/hotplug/rpadlpar_core.c +1 -4
@@ -455,7 +455,6 @@ static inline int is_dlpar_capable(void)
 
 int __init rpadlpar_io_init(void)
 {
-     int rc = 0;
 
      if (!is_dlpar_capable()) {
              printk(KERN_WARNING "%s: partition not DLPAR capable\n",
@@ -463,8 +462,7 @@ int __init rpadlpar_io_init(void)
              return -EPERM;
      }
 
-     rc = dlpar_sysfs_init();
-     return rc;
+     return dlpar_sysfs_init();
 }
 
 void rpadlpar_io_exit(void)
--

2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 10 lines
We all know Linux is great... it does infinite loops in 5 seconds.
- Linus Torvald



Regards,

Rahul Krishnan
<https://github.com/rahulkde>Wordpress
<https://rahulkrishnanlive.wordpress.com/>