Skip to contentSkip to conversation

Remove IV_RGI6=1 peer-info signalling.

PATCH In review Gert Doering 3 participants 3 messages Dec 25, 2016 – Dec 26, 2016

lore
Share & tools
lore

Gert Doering

author
#0 lore raw

PATCH 1/1 Remove IV_RGI6=1 peer-info signalling.

This is no longer needed, as anything 2.4 or later is known to have this functionality, and IV_VER can be used to detect this on the server.

Signed-off-by Gert Doering <[email protected]...>
---
 src/openvpn/ssl.c | 3 ---
 1 file changed, 3 deletions(-)
src/openvpn/ssl.c +0 -3
index 15f62f2..cff4052 100644
@@ -2270,9 +2270,6 @@ push_peer_info(struct buffer *buf, struct tls_session *session)
         comp_generate_peer_info_string(&session->opt->comp_options, &out);
 #endif
 
-        /* support for redirecting IPv6 gateway */
-        buf_printf(&out, "IV_RGI6=1\n");
-
         if (session->opt->push_peer_info_detail >= 2)
         {
             /* push mac addr */
Signature · 1 line
2.10.2
#1 lore raw
Quoted 23 lines · Gert Doering

This is no longer needed, as anything 2.4 or later is known to have this functionality, and IV_VER can be used to detect this on the server.

Signed-off-by Gert Doering <[email protected]...>
---
 src/openvpn/ssl.c | 3 ---
 1 file changed, 3 deletions(-)
src/openvpn/ssl.c +0 -4
index 15f62f2..cff4052 100644
@@ -2270,9 +2270,6 @@ push_peer_info(struct buffer *buf, struct tls_session *session)
         comp_generate_peer_info_string(&session->opt->comp_options, &out);
 #endif
 
-        /* support for redirecting IPv6 gateway */
-        buf_printf(&out, "IV_RGI6=1\n");
-
         if (session->opt->push_peer_info_detail >= 2)
         {
             /* push mac addr */
--
Quoted 1 line

2.10.2

ACK

(I even think this should go into 2.4.0, to prevent officially releasing a version that advertises IV_RGI6.)

-Steffan

#2 lore raw
In reply to Gert Doering

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I'm adding an ACK as well. I can confirm that the IV_RGI6 peer-info signalling have only been available git master/v2.4.

The first commit introducing IV_RGI6 is 3ddb56433b1fa0f2. This commit is only present in the following tags:

    $ git tag --contains 3ddb56433b1fa0f2
    v2.4_alpha1
    v2.4_alpha2
    v2.4_beta1
    v2.4_beta2
    v2.4_rc1
    v2.4_rc2

Your patch has been applied to the following branches

commit 392c9e47f6418612bc2a4932faf22bb711e65a54 (master) commit 554504c5e2692c3e6cfd3feae10c9d5c8ec363f8 (release/2.4)

Author: Gert Doering
Date:   Sun Dec 25 11:59:19 2016 +0100
     Remove IV_RGI6=1 peer-info signalling.

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Acked-by: David Sommerseth <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg13706.html
     Signed-off-by: David Sommerseth <[email protected]...>

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJYYQvRAAoJEIbPlEyWcf3yJXkQAJeHh5orvaKC5oPhMvhPIThy T3UsXTYpuBr7siGbYxMRCKvDublXR+89UT7wp3Z49/4evrr+kzykPEItYqlhUiyE 8pxiuKaPtlr1/Ru7RP04DTiUyATAK9prAqj0aXvJGRf3aMHH9zQt344n4r8XBkPP FDWh8lqhrCYmPuX1aVMqvKf6kw268jVX4ODqJTkDWlTgqfKvvBfBAoZXvtqYaEzj 7OEyKAUb4CDXY6ARnvdhLKLdZS58QwPTCvvHOMcQqLOaowIntFcD31qpM9uKJTe8 d+KkEQJ7WCs1Lpmu5BXdA76YxnaaoNzWxa/XQlcIMN+6mOmzbZ46zoHqWM0PE4jA jIG3qSZtQLHWk95EnaFOcxYVOfaRcQMShJVgju1HEs4oe5/FEomaTebgqhxi7n5A NUklyubIehreFwy5JW4787rPX0U9cliMZlYZtGlLNDhF61z/3RQ+G/u6OpMX1d0l 769ZG7HtgnT6TJwpCx6zPCVDuOnYHVHaMqV+UfQQugkFQhfC23fQfTyFK/X/xVg7 0uN1GpxZvPnp1x2v9QxmJuKBj5oqdi9c/ck262HIHcXibLSEIvKXUdzQRnZUt6LQ 4mAFVzsxRn0h/18hFpjraVff/+46sR09tP6mZCvOX94Jnwz4GxY55qxNPX4G4ByE 3KBT19lY6pueJHz9LEyU
=lsLW
-----END PGP SIGNATURE-----