ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss

Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies to this file. But it missed adding voltage supplies to usb_phy, mmc, dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply phandles to these nodes in dra72-evm-tps65917.dtsi

Fixes 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")

Reported-by Carlos Hernandez <[email protected]>

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Lokesh Vutla <[email protected]>

---
Logs:
- DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
- DRA72-evm revB: http://pastebin.ubuntu.com/23627658/

 arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +6 -0

index ee6dac44edf1..e6df676886c0 100644
@@ -132,3 +132,19 @@
 		ti,palmas-long-press-seconds = <6>;
 	};
 };
+
+&usb2_phy1 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {

Lokesh,

Quoted 37 lines · Lokesh Vutla

Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies to this file. But it missed adding voltage supplies to usb_phy, mmc, dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply phandles to these nodes in dra72-evm-tps65917.dtsi

Fixes 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")

Reported-by Carlos Hernandez <[email protected]>

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Lokesh Vutla <[email protected]>

---
Logs:
- DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
- DRA72-evm revB: http://pastebin.ubuntu.com/23627658/

 arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +12 -0

index ee6dac44edf1..e6df676886c0 100644
@@ -132,3 +132,19 @@
 		ti,palmas-long-press-seconds = <6>;
 	};
 };
+
+&usb2_phy1 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&dss {
+	vdda_video-supply = <&ldo5_reg>;
+};

arch/arm/boot/dts/dra72-evm-tps65917.dtsi line 150

Quoted 5 lines

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +4 -0

+
+&mmc1 {
+	vmmc_aux-supply = <&ldo1_reg>;
+};

Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? If not I'd rather put this in the board dts files.

cheers,
-roger

Quoted 40 lines · Roger Quadros

Lokesh,

Quoted 37 lines · Lokesh Vutla

Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies to this file. But it missed adding voltage supplies to usb_phy, mmc, dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply phandles to these nodes in dra72-evm-tps65917.dtsi

Fixes 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")

Reported-by Carlos Hernandez <[email protected]>

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Lokesh Vutla <[email protected]>

---
Logs:
- DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
- DRA72-evm revB: http://pastebin.ubuntu.com/23627658/

 arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +12 -0

index ee6dac44edf1..e6df676886c0 100644
@@ -132,3 +132,19 @@
 		ti,palmas-long-press-seconds = <6>;
 	};
 };
+
+&usb2_phy1 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&dss {
+	vdda_video-supply = <&ldo5_reg>;
+};

Quoted 8 lines

arch/arm/boot/dts/dra72-evm-tps65917.dtsi line 150

Quoted 5 lines

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +4 -0

+
+&mmc1 {
+	vmmc_aux-supply = <&ldo1_reg>;
+};

Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? If not I'd rather put this in the board dts files.

hmm..This debate already happened when creating dra72-evm-tps65917 file and concluded that all the common regulator stuff on dra72 evm revA,B,C should go in this file. Any new board which is not similar to dra72-evm will not be using this file.

Quoted 52 lines · Lokesh Vutla

Quoted 48 lines · Roger Quadros

Lokesh,

Quoted 32 lines · Lokesh Vutla

Commit 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917") added a separate dtsi for dra72-evm-tps65917 moving all the voltage supplies to this file. But it missed adding voltage supplies to usb_phy, mmc, dss and deleted from dra72-evm-common.dtsi. Adding the voltage supply phandles to these nodes in dra72-evm-tps65917.dtsi

Fixes 5d080aa30681 ("ARM: dts: dra72: Add separate dtsi for tps65917")

Reported-by Carlos Hernandez <[email protected]>

Signed-off-by Roger Quadros <[email protected]>

Signed-off-by Lokesh Vutla <[email protected]>

---
Logs:
- DRA72-evm revC: http://pastebin.ubuntu.com/23627665/
- DRA72-evm revB: http://pastebin.ubuntu.com/23627658/

 arch/arm/boot/dts/dra72-evm-tps65917.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +6 -0

index ee6dac44edf1..e6df676886c0 100644
@@ -132,3 +132,19 @@
 		ti,palmas-long-press-seconds = <6>;
 	};
 };
+
+&usb2_phy1 {
+	phy-supply = <&ldo4_reg>;
+};
+
+&usb2_phy2 {

arch/arm/boot/dts/dra72-evm-tps65917.dtsi line 150

Quoted 10 lines

arch/arm/boot/dts/dra72-evm-tps65917.dtsi +10 -0

+	phy-supply = <&ldo4_reg>;
+};
+
+&dss {
+	vdda_video-supply = <&ldo5_reg>;
+};
+
+&mmc1 {
+	vmmc_aux-supply = <&ldo1_reg>;
+};

Are you sure that all future users of dra72-evm-tps65917.dtsi will use this same configuration? If not I'd rather put this in the board dts files.

Quoted 4 lines

hmm..This debate already happened when creating dra72-evm-tps65917 file and concluded that all the common regulator stuff on dra72 evm revA,B,C should go in this file. Any new board which is not similar to dra72-evm will not be using this file.

OK, then it is fine. Thanks for clarifying.