vif queue counters from int to long
Subsystems (3)
PATCH 1/1 vif queue counters from int to long
Hello,
This patch fixes an issue where counters in the queue have type int, while the counters of the vif itself are specified as long. This can cause incorrect reporting of tx/rx values of the vif interface. More extensively reported on xen-devel mailinglist.
drivers/net/xen-netback/common.h 2016-12-23 13:08:18.123080064 +0000 renamed from drivers/net/xen-netback/common.h 2016-12-22 15:41:07.785535748 +0000 +4 -4
@@ -113,10 +113,10 @@ struct xenvif_stats { * A subset of struct net_device_stats that contains only the * fields that are updated in netback.c for each queue. */ - unsigned int rx_bytes; - unsigned int rx_packets; - unsigned int tx_bytes; - unsigned int tx_packets; + unsigned long rx_bytes; + unsigned long rx_packets; + unsigned long tx_bytes; + unsigned long tx_packets; /* Additional stats used by xenvif */ unsigned long rx_gso_checksum_fixup;
Signature · 12 lines
Mart van Santen Greenhost E: [email protected] T: +31 20 4890444 W: https://greenhost.nl A PGP signature can be attached to this e-mail, you need PGP software to verify it. My public key is available in keyserver(s) see: http://tinyurl.com/openpgp-manual PGP Fingerprint: CA85 EB11 2B70 042D AF66 B29A 6437 01A1 10A3 D3A5
David Miller
maintainerRe: [PATCH] vif queue counters from int to long,[PATCH] vif queue counters from int to long
From: Mart van Santen <[email protected]>
Date: Fri, 23 Dec 2016 16:09:23 +0100
Quoted 6 lines
This patch fixes an issue where counters in the queue have type int, while the counters of the vif itself are specified as long. This can cause incorrect reporting of tx/rx values of the vif interface. More extensively reported on xen-devel mailinglist.
Signed-off-by Mart van Santen <[email protected]>
Your subject line lacks a proper subsystem prefix, in this case an appropriate one might be "xen-netback: "
Also, your patch was corrupted by your email client, transforming TAB characters into spaces. This makes the patch unusable.
Please read Documentation/email-clients.txt on how to fix this and how to submit uncorrupted patches properly.
Email a test patch to yourself, and do not attempt to resend this patch to the mailing list until you can successfully apply the test patch you send to yourself.
Thanks.
Quoted 8 lines · Mart van Santen
Hello,
This patch fixes an issue where counters in the queue have type int, while the counters of the vif itself are specified as long. This can cause incorrect reporting of tx/rx values of the vif interface. More extensively reported on xen-devel mailinglist.
Hello,
Please also CC [email protected] for your future patch(es). And please note that the most up to date maintainer information should be used.
Wei.
Quoted 36 lines
Signed-off-by Mart van Santen <[email protected]>drivers/net/xen-netback/common.h 2016-12-23 13:08:18.123080064 +0000 renamed from drivers/net/xen-netback/common.h 2016-12-22 15:41:07.785535748 +0000 +4
-4@@ -113,10 +113,10 @@ struct xenvif_stats { * A subset of struct net_device_stats that contains only the * fields that are updated in netback.c for each queue. */ - unsigned int rx_bytes; - unsigned int rx_packets; - unsigned int tx_bytes; - unsigned int tx_packets; + unsigned long rx_bytes; + unsigned long rx_packets; + unsigned long tx_bytes; + unsigned long tx_packets; /* Additional stats used by xenvif */ unsigned long rx_gso_checksum_fixup;Signature · 13 lines
-- Mart van Santen Greenhost E: [email protected] T: +31 20 4890444 W: https://greenhost.nl A PGP signature can be attached to this e-mail, you need PGP software to verify it. My public key is available in keyserver(s) see: http://tinyurl.com/openpgp-manual PGP Fingerprint: CA85 EB11 2B70 042D AF66 B29A 6437 01A1 10A3 D3A5