Skip to contentSkip to conversation

crypto: testmgr - use kmemdup instead of kmalloc+memcpy

PATCH In review Eric Biggers 2 participants 2 messages Dec 30, 2016 – Jan 12, 2017

Subsystems (2)
Crypto API Arm STM32
lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 crypto: testmgr - use kmemdup instead of kmalloc+memcpy

From: Eric Biggers <[email protected]>

It's recommended to use kmemdup instead of kmalloc followed by memcpy.

Signed-off-by Eric Biggers <[email protected]>
---
 crypto/testmgr.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
crypto/testmgr.c +2 -4
index 44e888b0b041..881176ebd8a8 100644
@@ -1463,13 +1463,12 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate,
 		int ilen = ctemplate[i].inlen;
 		void *input_vec;
 
-		input_vec = kmalloc(ilen, GFP_KERNEL);
+		input_vec = kmemdup(ctemplate[i].input, ilen, GFP_KERNEL);
 		if (!input_vec) {
 			ret = -ENOMEM;
 			goto out;
 		}
 
-		memcpy(input_vec, ctemplate[i].input, ilen);
 		memset(output, 0, dlen);
 		init_completion(&result.completion);
 		sg_init_one(&src, input_vec, ilen);

@@ -1525,13 +1524,12 @@ static int test_acomp(struct crypto_acomp *tfm, struct comp_testvec *ctemplate,
 		int ilen = dtemplate[i].inlen;
 		void *input_vec;
 
-		input_vec = kmalloc(ilen, GFP_KERNEL);
+		input_vec = kmemdup(dtemplate[i].input, ilen, GFP_KERNEL);
 		if (!input_vec) {
 			ret = -ENOMEM;
 			goto out;
 		}
 
-		memcpy(input_vec, dtemplate[i].input, ilen);
 		memset(output, 0, dlen);
 		init_completion(&result.completion);
 		sg_init_one(&src, input_vec, ilen);
Signature · 1 line
2.11.0