dell-wmi, dell-laptop: hide dell-smbios
PATCH v2 1/1 dell-wmi, dell-laptop: hide dell-smbios
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more user-friendly and avoids the confusing transitive dependencies which Pali didn't like.
drivers/platform/x86/Kconfig | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/platform/x86/Kconfig +4 -4
@@ -92,8 +92,8 @@ config ASUS_LAPTOP If you have an ACPI-compatible ASUS laptop, say Y or M here. config DELL_SMBIOS - tristate "Dell SMBIOS Support" - depends on DCDBAS + tristate + select DCDBAS default n ---help--- This module provides common functions for kernel modules using
@@ -103,12 +103,12 @@ config DELL_SMBIOS config DELL_LAPTOP tristate "Dell Laptop Extras" - depends on DELL_SMBIOS depends on DMI depends on BACKLIGHT_CLASS_DEVICE depends on ACPI_VIDEO || ACPI_VIDEO = n depends on RFKILL || RFKILL = n depends on SERIO_I8042 + select DELL_SMBIOS select POWER_SUPPLY select LEDS_CLASS select NEW_LEDS
@@ -123,7 +123,7 @@ config DELL_WMI depends on DMI depends on INPUT depends on ACPI_VIDEO || ACPI_VIDEO = n - depends on DELL_SMBIOS + select DELL_SMBIOS select INPUT_SPARSEKMAP ---help--- Say Y here if you want to support WMI-based hotkeys on Dell laptops.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 4 lines · Jean Delvare
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
Please, use prefix "platform/x86: ".
Perhaps, use just "dell_smbios: " as second one.
drivers/platform/x86/Kconfig config ASUS_LAPTOP · line 97
Quoted 7 lines
config
DELL_SMBIOSdrivers/platform/x86/Kconfig +2
-2- tristate "Dell SMBIOS Support" - depends on DCDBAS + tristate + select DCDBAS default n
Do we need this one?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy,
Thanks for the review.
Quoted 8 lines · Andy Shevchenko
Quoted 4 lines · Jean Delvare
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
Please, use prefix "platform/x86: ".
Perhaps, use just "dell_smbios: " as second one.
OK, will change.
Quoted 9 lines
drivers/platform/x86/Kconfig config ASUS_LAPTOP · line 97
Quoted 7 lines
config
DELL_SMBIOSdrivers/platform/x86/Kconfig +2
-2- tristate "Dell SMBIOS Support" - depends on DCDBAS + tristate + select DCDBAS default nDo we need this one?
Probably not. "n" being the default default, I guess the 844 occurrences of "default n" in the Kconfig tree are pointless ;-)
I'll post v3 of the patch in a minute.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 8 lines · On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
Signed-off-by Jean Delvare <[email protected]>Cc Michał Kępień <[email protected]>Cc Pali Rohár <[email protected]>Cc Darren Hart <[email protected]>
Quoted 5 lines
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more user-friendly and avoids the confusing transitive dependencies which Pali didn't like.
Hi! I see that in previous email you CCed Yann and linux-kbuild, but I do not see any response in my mailbox. Have you got some answer?
Signature · 2 lines
Pali Rohár [email protected]
Hi Pali,
Quoted 15 lines · Pali Rohár
Quoted 8 lines · On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
Signed-off-by Jean Delvare <[email protected]>Cc Michał Kępień <[email protected]>Cc Pali Rohár <[email protected]>Cc Darren Hart <[email protected]>Quoted 5 lines
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more user-friendly and avoids the confusing transitive dependencies which Pali didn't like.
Quoted 1 line
Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
No, I did not. What are you talking about? I'm confused.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 18 lines · On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
Hi Pali,
Quoted 15 lines · Pali Rohár
Quoted 13 lines · On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
Dell-smbios is a helper module, it serves no purpose on its own, so do not present it as an option to the user. Instead, select it automatically whenever a driver which needs it is selected.
Signed-off-by Jean Delvare <[email protected]>Cc Michał Kępień <[email protected]>Cc Pali Rohár <[email protected]>Cc Darren Hart <[email protected]>---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more user-friendly and avoids the confusing transitive dependencies which Pali didn't like.
Quoted 3 lines
Quoted 1 line
Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
No, I did not. What are you talking about? I'm confused.
Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.
Signature · 2 lines
Pali Rohár [email protected]
Quoted 6 lines · Pali Rohár
Quoted 3 lines · On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
Quoted 1 line
Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
No, I did not. What are you talking about? I'm confused.
Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.
I have pushed v3 to testing and it passes kbuild bot tests.
Signature · 2 lines
With Best Regards, Andy Shevchenko