ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

PATCH In review Krzysztof Kozlowski 4 participants 17 messages Jan 7, 2017 – Mar 29, 2017

Subsystems (3)

Device tree bindings Arm (32-bit) Arm Samsung Exynos

lore

Share & tools

lore

Krzysztof Kozlowski

author maintainer

2017-01-07 08:51 UTC #0 lore raw

cover ARM: exynos: Fix Odroid U3 USB/LAN when TFTP booting (power sequence)

Hi,

Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.

My previous attempts for this can be found here [0].

This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].

More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").

Best regards,
Krzysztof

[0] http://www.spinics.net/lists/linux-mmc/msg37386.html
[1] https://lwn.net/Articles/710736/
[2] https://github.com/krzk/linux/commits/for-next/odroid-u3-usb3503-pwrseq

Krzysztof Kozlowski (4):
ARM: dts: exynos: Fix indentation of EHCI and OHCI ports
ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot
ARM: exynos_defconfig: Enable power sequence for Odroid U3
ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

 arch/arm/boot/dts/exynos4.dtsi            | 24 ++++++++++++------------
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 21 +++++++++++++++++++++
 arch/arm/configs/exynos_defconfig         |  2 ++
 arch/arm/configs/multi_v7_defconfig       |  1 +
 4 files changed, 36 insertions(+), 12 deletions(-)

Signature · 1 line

2.9.3

Krzysztof Kozlowski

author maintainer

2017-01-07 08:52 UTC #1 lore raw

PATCH 1/4 ARM: dts: exynos: Fix indentation of EHCI and OHCI ports

Replace spaces with tabs in EHCI and OHCI ports indentation.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/exynos4.dtsi | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

arch/arm/boot/dts/exynos4.dtsi +12 ~~-12~~

index c64737baa45e..3209c60389e2 100644
@@ -370,19 +370,19 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		port at 0 {
-		    reg = <0>;
-		    phys = <&exynos_usbphy 1>;
-		    status = "disabled";
+			reg = <0>;
+			phys = <&exynos_usbphy 1>;
+			status = "disabled";
 		};
 		port at 1 {
-		    reg = <1>;
-		    phys = <&exynos_usbphy 2>;
-		    status = "disabled";
+			reg = <1>;
+			phys = <&exynos_usbphy 2>;
+			status = "disabled";
 		};
 		port at 2 {
-		    reg = <2>;
-		    phys = <&exynos_usbphy 3>;
-		    status = "disabled";
+			reg = <2>;
+			phys = <&exynos_usbphy 3>;
+			status = "disabled";
 		};
 	};

@@ -396,9 +396,9 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 		port at 0 {
-		    reg = <0>;
-		    phys = <&exynos_usbphy 1>;
-		    status = "disabled";
+			reg = <0>;
+			phys = <&exynos_usbphy 1>;
+			status = "disabled";
 		};
 	};

Signature · 1 line

2.9.3

Javier Martinez Canillas

Reviewed-by on v1 1/4

2017-01-09 16:01 UTC #2 lore raw

Re: [PATCH 1/4] ARM: dts: exynos: Fix indentation of EHCI and OHCI ports

Hello Krzysztof,

Quoted 4 lines · Krzysztof Kozlowski

Replace spaces with tabs in EHCI and OHCI ports indentation.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Krzysztof Kozlowski

author maintainer

2017-01-07 08:52 UTC #3 lore raw

PATCH 2/4 ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot

In reply to Krzysztof Kozlowski

The ethernet adapter LAN9730, after enabling in bootloader (e.g. for tftpboot) requires reset during boot. Otherwise it won't come up.

The schematics of Odroid U3 are detailed enough but after grabbing knowledge also from other sources (like U-Boot) the overall design looks like:
1. LAN9730 is connected to HSIC0 and USB3503 to HSIC1 of EHCI controller.
2. USB3503 comes with its own reset pin: gpx3-5.
3. Reset pin of LAN9730 is pulled up to 3.3 V so it cannot be used.
4. The supply of 3.3 V for LAN9730 is delivered from buck8.
5. Buck8 state is a logical OR of registry value (through I2C command) and ENB8 pin. The ENB8, not described in schematics, is in fact gpa1-1.
6. Missing or wrongly timed reset of LAN9730 might result in missing of two devices: LAN9730 and USB3503. Without reset, LAN9730 will not come up, if it was enabled by bootloader.

To fix the issue use the generic power sequence driver and toggle the ENB8 (buck8) pin. Reset duration of 500 us was chosen by experiments (shortest working time was 400 us). This is an easiest way to fix the long standing LAN9730 reset issue.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

arch/arm/boot/dts/exynos4412-odroidu3.dts +21 -0

index 99634c54dca9..aef49007cba0 100644
@@ -84,10 +84,23 @@
 	regulator-max-microvolt = <2800000>;
 };
 
+&max77686 {
+	pinctrl-0 = <&max77686_irq &max77686_enb8>;
+};
+
 &mshc_0 {
 	vqmmc-supply = <&ldo22_reg>;
 };
 
+&pinctrl_0 {
+	max77686_enb8: max77686-enb8 {
+		samsung,pins = "gpa1-1";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+	};
+};
+
 &pwm {
 	pinctrl-0 = <&pwm0_out>;
 	pinctrl-names = "default";

@@ -103,7 +116,15 @@
 
 &ehci {
 	port at 1 {
+		/* HSIC for LAN9730 */
 		status = "okay";
+		/* buck8 enable pin, use it for power sequence */
+		reset-gpios = <&gpa1 1 GPIO_ACTIVE_LOW>;
+		/*
+		 * Reset duration of 500 us was chosen experimentally.
+		 * Minimal working value was 400 us. Add some safe margin.
+		 */
+		reset-duration-us = <500>;
 	};
 	port at 2 {
 		status = "okay";

Signature · 1 line

2.9.3

Javier Martinez Canillas

Reviewed-by on v1 2/4

2017-01-09 16:17 UTC #4 lore raw

Re: [PATCH 2/4] ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot

Hello Krzysztof,

Quoted 17 lines · Krzysztof Kozlowski

The ethernet adapter LAN9730, after enabling in bootloader (e.g. for tftpboot) requires reset during boot. Otherwise it won't come up.
The schematics of Odroid U3 are detailed enough but after grabbing knowledge also from other sources (like U-Boot) the overall design looks like:
1. LAN9730 is connected to HSIC0 and USB3503 to HSIC1 of EHCI controller.
2. USB3503 comes with its own reset pin: gpx3-5.
3. Reset pin of LAN9730 is pulled up to 3.3 V so it cannot be used.
4. The supply of 3.3 V for LAN9730 is delivered from buck8.
5. Buck8 state is a logical OR of registry value (through I2C command) and ENB8 pin. The ENB8, not described in schematics, is in fact gpa1-1.
6. Missing or wrongly timed reset of LAN9730 might result in missing of two devices: LAN9730 and USB3503. Without reset, LAN9730 will not come up, if it was enabled by bootloader.

Quoted 7 lines

To fix the issue use the generic power sequence driver and toggle the ENB8 (buck8) pin. Reset duration of 500 us was chosen by experiments (shortest working time was 400 us). This is an easiest way to fix the long standing LAN9730 reset issue.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---

Thanks for keep pushing a fix for this long standing issue.

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Krzysztof Kozlowski

author maintainer

2017-01-07 08:52 UTC #5 lore raw

PATCH 3/4 ARM: exynos_defconfig: Enable power sequence for Odroid U3

In reply to Krzysztof Kozlowski

Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Enable also GPIO_SYSFS which is useful for playing with GPIO during debug process.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/configs/exynos_defconfig | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/configs/exynos_defconfig +2 -0

index 79c415c33f69..ad1a509c296a 100644
@@ -99,6 +99,7 @@ CONFIG_SPI=y
 CONFIG_SPI_GPIO=y
 CONFIG_SPI_S3C64XX=y
 CONFIG_DEBUG_GPIO=y
+CONFIG_GPIO_SYSFS=y
 CONFIG_GPIO_WM8994=y
 CONFIG_POWER_SUPPLY=y
 CONFIG_BATTERY_SBS=y

@@ -108,6 +109,7 @@ CONFIG_CHARGER_MAX14577=y
 CONFIG_CHARGER_MAX77693=y
 CONFIG_CHARGER_MAX8997=y
 CONFIG_CHARGER_TPS65090=y
+CONFIG_PWRSEQ_GENERIC=y
 CONFIG_SENSORS_LM90=y
 CONFIG_SENSORS_NTC_THERMISTOR=y
 CONFIG_SENSORS_PWM_FAN=y

Signature · 1 line

2.9.3

Javier Martinez Canillas

Reviewed-by on v1 3/4

2017-01-09 16:19 UTC #6 lore raw

Re: [PATCH 3/4] ARM: exynos_defconfig: Enable power sequence for Odroid U3

Hello Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Enable also GPIO_SYSFS which is useful for playing with GPIO during debug process.
Signed-off-by Krzysztof Kozlowski <[email protected]>
---

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Krzysztof Kozlowski

author maintainer

2017-01-07 08:52 UTC #7 lore raw

PATCH 4/4 ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

In reply to Krzysztof Kozlowski

Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader.

Signed-off-by Krzysztof Kozlowski <[email protected]>

---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

arch/arm/configs/multi_v7_defconfig +1 -0

index b01a43851294..1750d99862b9 100644
@@ -443,6 +443,7 @@ CONFIG_POWER_RESET_RMOBILE=y
 CONFIG_POWER_RESET_ST=y
 CONFIG_POWER_AVS=y
 CONFIG_ROCKCHIP_IODOMAIN=y
+CONFIG_PWRSEQ_GENERIC=y
 CONFIG_SENSORS_IIO_HWMON=y
 CONFIG_SENSORS_LM90=y
 CONFIG_SENSORS_LM95245=y

Signature · 1 line

2.9.3

Krzysztof Kozlowski

author maintainer

2017-01-07 09:16 UTC #8 lore raw

PATCH 1/1 ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3).

Signed-off-by Krzysztof Kozlowski <[email protected]>

---

Changes since v1 (v1 -> v1.1):
1. Enable also usb3503 driver.

---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/configs/multi_v7_defconfig +2 -0

index b01a43851294..8cc73e084b25 100644
@@ -443,6 +443,7 @@ CONFIG_POWER_RESET_RMOBILE=y
 CONFIG_POWER_RESET_ST=y
 CONFIG_POWER_AVS=y
 CONFIG_ROCKCHIP_IODOMAIN=y
+CONFIG_PWRSEQ_GENERIC=y
 CONFIG_SENSORS_IIO_HWMON=y
 CONFIG_SENSORS_LM90=y
 CONFIG_SENSORS_LM95245=y

@@ -686,6 +687,7 @@ CONFIG_USB_DWC2=y
 CONFIG_USB_CHIPIDEA=y
 CONFIG_USB_CHIPIDEA_UDC=y
 CONFIG_USB_CHIPIDEA_HOST=y
+CONFIG_USB_HSIC_USB3503=m
 CONFIG_AB8500_USB=y
 CONFIG_KEYSTONE_USB_PHY=y
 CONFIG_OMAP_USB3=y

Signature · 1 line

2.9.3

Javier Martinez Canillas

Reviewed-by on v1 1/1

2017-01-09 16:24 UTC #9 lore raw

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

Hello Krzysztof,

I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :)

Quoted 8 lines · Krzysztof Kozlowski

Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3).
Signed-off-by Krzysztof Kozlowski <[email protected]>
---

Do you think that makes sense to also enable GPIO_SYS for debugging purposes as you do in patch 3/4?

In any case the patch looks good to me:

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Krzysztof Kozlowski

author maintainer

2017-01-09 17:38 UTC #10 lore raw

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

Quoted 3 lines · Javier Martinez Canillas

Hello Krzysztof,
I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :)

Ah, yes.

Quoted 6 lines · Krzysztof Kozlowski

Quoted 4 lines
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3).

Quoted 7 lines

Quoted 4 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
Do you think that makes sense to also enable GPIO_SYS for debugging purposes as you do in patch 3/4?

I like the GPIO_SYSFS interface because it is easy to use. However now, after your question, I found this:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/470154.html
ARM/ARM64: defconfig: drop GPIO_SYSFS on multiplatforms

... so instead I will drop it from exynos_defconfig.

Best regards,
Krzysztof

Javier Martinez Canillas

2017-01-09 17:44 UTC #11 lore raw

Re: [PATCH v1.1] ARM: multi_v7_defconfig: Enable power sequence for Odroid U3

Hello Krzysztof,

Quoted 22 lines · Krzysztof Kozlowski

Quoted 3 lines · Javier Martinez Canillas
Hello Krzysztof,
I think it would had been clearer if the subject prefix was "[PATCH v1.1 4/4]" :)
Ah, yes.
Quoted 6 lines · Krzysztof Kozlowski
Quoted 4 lines
Odroid U3 needs a power sequence for lan9730, if it was enabled by bootloader. Also enable the USB3503 HSCI to USB2.0 driver (device is present on Odroid U3).
Quoted 7 lines
Quoted 4 lines
Signed-off-by Krzysztof Kozlowski <[email protected]>
---
Do you think that makes sense to also enable GPIO_SYS for debugging purposes as you do in patch 3/4?

Quoted 7 lines

I like the GPIO_SYSFS interface because it is easy to use. However now, after your question, I found this:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-November/470154.html
ARM/ARM64: defconfig: drop GPIO_SYSFS on multiplatforms
... so instead I will drop it from exynos_defconfig.

Right, I forgot that using the GPIO sysfs interface is discouraged now and the new chardev/ioctl based should be used instead. So it makes sense to drop it.

Quoted 2 lines

Best regards,
Krzysztof

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Anand Moon

2017-01-09 18:04 UTC #12 lore raw

In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Hi,
Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.

Quoted 9 lines

My previous attempts for this can be found here [0].
This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].
More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").

[snip]

On which u-boot should this be tested.

On HK u-boot tftp boot is not supported.
----------------------------------------------------------
U-Boot 2010.12-00000-g9777ca6-dirty (Nov 26 2015 - 10:10:11) for Exynox4412

CPU: S5PC220 [Samsung SOC on SMP Platform Base on ARM CortexA9] APLL = 1000MHz, MPLL = 800MHz
DRAM: 2 GiB

PMIC VERSION : 0x00, CHIP REV : 2
TrustZone Enabled BSP
BL1 version: 20121128

Checking Boot Mode ... SDMMC
MMC Device 0: 14804 MB
MMC Device 1 not found
*** Warning - using default environment

USB3503 NINT = OUTPUT LOW!
ModeKey Check... run normal_boot
No ethernet found.
Hit any key to stop autoboot: 0
Exynos4412 #
Exynos4412 #
Exynos4412 #
Exynos4412 # usb start
(Re)start USB...
USB0: Exynos4412-ehci: init hccr 12580000 and hcor 12580010 hc_length 16
usb: usb_refclk_enable is active low: NO
ProTIP: If usb doesn't work - try playing with 'usb_invert_clken' environment USB EHCI 1.00
scanning bus 0 for devices... EHCI timed out on TD - token=0x80008c80 EHCI fail timeout STS_ASS set

USB device not accepting new address (error=80000000)
EHCI fail timeout STS_ASS set
1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found
Exynos4412 #

Best Regards
-Anand

Krzysztof Kozlowski

author maintainer

2017-01-09 18:17 UTC #13 lore raw

Quoted 19 lines · Anand Moon

Hi Krzysztof,
Quoted 6 lines · Krzysztof Kozlowski
Hi,
Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.
Quoted 9 lines
My previous attempts for this can be found here [0].
This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].
More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").

Quoted 5 lines

[snip]
On which u-boot should this be tested.
On HK u-boot tftp boot is not supported.

... so you gave an answer: you cannot test it on HK. How many other U-Boot flavors you know? :)

Best regards,
Krzysztof

Quoted 43 lines

----------------------------------------------------------
U-Boot 2010.12-00000-g9777ca6-dirty (Nov 26 2015 - 10:10:11) for Exynox4412
CPU: S5PC220 [Samsung SOC on SMP Platform Base on ARM CortexA9] APLL = 1000MHz, MPLL = 800MHz
DRAM: 2 GiB
PMIC VERSION : 0x00, CHIP REV : 2
TrustZone Enabled BSP
BL1 version: 20121128
Checking Boot Mode ... SDMMC
MMC Device 0: 14804 MB
MMC Device 1 not found
*** Warning - using default environment
USB3503 NINT = OUTPUT LOW!
ModeKey Check... run normal_boot
No ethernet found.
Hit any key to stop autoboot: 0
Exynos4412 #
Exynos4412 #
Exynos4412 #
Exynos4412 # usb start
(Re)start USB...
USB0: Exynos4412-ehci: init hccr 12580000 and hcor 12580010 hc_length 16
usb: usb_refclk_enable is active low: NO
ProTIP: If usb doesn't work - try playing with 'usb_invert_clken' environment USB EHCI 1.00
scanning bus 0 for devices... EHCI timed out on TD - token=0x80008c80 EHCI fail timeout STS_ASS set
USB device not accepting new address (error=80000000)
EHCI fail timeout STS_ASS set
1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found
Exynos4412 #
Best Regards
-Anand

Anand Moon

2017-01-09 18:26 UTC #14 lore raw

Hi Krzysztof,

Quoted 20 lines · Krzysztof Kozlowski

Quoted 19 lines · Anand Moon
Hi Krzysztof,
Quoted 15 lines · Krzysztof Kozlowski
Hi,
Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.
My previous attempts for this can be found here [0].
This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].
More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").

Quoted 9 lines

Quoted 5 lines
[snip]
On which u-boot should this be tested.
On HK u-boot tftp boot is not supported.
... so you gave an answer: you cannot test it on HK. How many other U-Boot flavors you know? :)

u-boot mainline have tftp support enable, so I will try to test on this u-boot.

Best Regards
-Anand

Quoted 47 lines

Best regards,
Krzysztof
Quoted 43 lines
----------------------------------------------------------
U-Boot 2010.12-00000-g9777ca6-dirty (Nov 26 2015 - 10:10:11) for Exynox4412
CPU: S5PC220 [Samsung SOC on SMP Platform Base on ARM CortexA9] APLL = 1000MHz, MPLL = 800MHz
DRAM: 2 GiB
PMIC VERSION : 0x00, CHIP REV : 2
TrustZone Enabled BSP
BL1 version: 20121128
Checking Boot Mode ... SDMMC
MMC Device 0: 14804 MB
MMC Device 1 not found
*** Warning - using default environment
USB3503 NINT = OUTPUT LOW!
ModeKey Check... run normal_boot
No ethernet found.
Hit any key to stop autoboot: 0
Exynos4412 #
Exynos4412 #
Exynos4412 #
Exynos4412 # usb start
(Re)start USB...
USB0: Exynos4412-ehci: init hccr 12580000 and hcor 12580010 hc_length 16
usb: usb_refclk_enable is active low: NO
ProTIP: If usb doesn't work - try playing with 'usb_invert_clken' environment USB EHCI 1.00
scanning bus 0 for devices... EHCI timed out on TD - token=0x80008c80 EHCI fail timeout STS_ASS set
USB device not accepting new address (error=80000000)
EHCI fail timeout STS_ASS set
1 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 Ethernet Device(s) found
Exynos4412 #
Best Regards
-Anand

Krzysztof Kozlowski

author maintainer

2017-01-09 18:35 UTC #15 lore raw

Quoted 27 lines · Anand Moon

Hi Krzysztof,
Quoted 24 lines · Krzysztof Kozlowski
Quoted 23 lines · Anand Moon
Hi Krzysztof,
Quoted 6 lines · Krzysztof Kozlowski
Hi,
Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.
Quoted 9 lines
My previous attempts for this can be found here [0].
This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].
More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").
[snip]
On which u-boot should this be tested.

Quoted 7 lines

Quoted 5 lines
Quoted 1 line
On HK u-boot tftp boot is not supported.
... so you gave an answer: you cannot test it on HK. How many other U-Boot flavors you know? :)
u-boot mainline have tftp support enable, so I will try to test on this u-boot.

Yes, please try it. Some time ago I was using v2016.03-rc3 and now recent (~40 commits after v2017.01-rc2). Both are working fine however the configuration (partitions, default env settings etc) differs from HK so migration was not straightforward.

Best regards,
Krzysztof

Hans Verkuil

Tested-by on the v1 series

2017-03-29 11:12 UTC #16 lore raw

In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 6 lines · Krzysztof Kozlowski

Hi,
Thanks to Markus Reichl, I got an Odroid U3 to work with. Thanks to Peter Chen, we got a power sequence generic library which solves my long standing Odroid U3 problem - no LAN9730 if it was enabled by bootloader.

Quoted 7 lines

My previous attempts for this can be found here [0].
This patchset is based on Peter's v11 of power sequence [1]. Patchset is available also on my Github [2].
More detailed analysis is described in patch 2/4 ("ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot").

It's rather late, but I finally had a chance to test this and it works.

So:

Tested-by Hans Verkuil <[email protected]>

This was with u-boot version v2016.09.01 and kernel 4.11.0-rc1.

Regards,

Hans

Quoted 22 lines

Best regards,
Krzysztof
[0] http://www.spinics.net/lists/linux-mmc/msg37386.html
[1] https://lwn.net/Articles/710736/
[2] https://github.com/krzk/linux/commits/for-next/odroid-u3-usb3503-pwrseq
Krzysztof Kozlowski (4):
ARM: dts: exynos: Fix indentation of EHCI and OHCI ports
ARM: dts: exynos: Fix LAN9730 on Odroid U3 after tftpboot
ARM: exynos_defconfig: Enable power sequence for Odroid U3
ARM: multi_v7_defconfig: Enable power sequence for Odroid U3
 arch/arm/boot/dts/exynos4.dtsi            | 24 ++++++++++++------------
 arch/arm/boot/dts/exynos4412-odroidu3.dts | 21 +++++++++++++++++++++
 arch/arm/configs/exynos_defconfig         |  2 ++
 arch/arm/configs/multi_v7_defconfig       |  1 +
 4 files changed, 36 insertions(+), 12 deletions(-)