Skip to contentSkip to conversation

Stagging :Comedi :Fixed Camel Case Style issue

PATCH In review sumit negi 2 participants 2 messages Jan 7, 2017 Staging

lore
Share & tools
lore

sumit negi

author
#0 lore raw

PATCH 1/1 Stagging :Comedi :Fixed Camel Case Style issue

Fixed a camel style issue.

Signed-off-by sumit negi <[email protected]>
---
 drivers/staging/comedi/comedidev.h       | 6 +++---
 drivers/staging/comedi/drivers/dt2815.c  | 2 +-
 drivers/staging/comedi/drivers/ni_670x.c | 2 +-
 drivers/staging/comedi/drivers/pcl726.c  | 8 ++++----
 4 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/comedi/comedidev.h +3 -3
index dcb6376..1e6c5f3 100644
@@ -593,9 +593,9 @@ extern const struct comedi_lrange range_bipolar2_5;
 extern const struct comedi_lrange range_unipolar10;
 extern const struct comedi_lrange range_unipolar5;
 extern const struct comedi_lrange range_unipolar2_5;
-extern const struct comedi_lrange range_0_20mA;
-extern const struct comedi_lrange range_4_20mA;
-extern const struct comedi_lrange range_0_32mA;
+extern const struct comedi_lrange range_0_20ma;
+extern const struct comedi_lrange range_4_20ma;
+extern const struct comedi_lrange range_0_32ma;
 extern const struct comedi_lrange range_unknown;
 
 #define range_digital		range_unipolar5
drivers/staging/comedi/drivers/dt2815.c +1 -1
index 0be77cc..4d8211a 100644
@@ -174,7 +174,7 @@ static int dt2815_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 	s->range_table_list = devpriv->range_type_list;
 
 	current_range_type = (it->options[3])
-	    ? &range_4_20mA : &range_0_32mA;
+	    ? &range_4_20ma : &range_0_32ma;
 	voltage_range_type = (it->options[2])
 	    ? &range_bipolar5 : &range_unipolar5;
 	for (i = 0; i < 8; i++) {
drivers/staging/comedi/drivers/ni_670x.c +1 -1
index 74911db..6b4a8d6 100644
@@ -216,7 +216,7 @@ static int ni_670x_auto_attach(struct comedi_device *dev,
 		s->range_table_list = range_table_list;
 		for (i = 0; i < 16; i++) {
 			range_table_list[i] = &range_bipolar10;
-			range_table_list[16 + i] = &range_0_20mA;
+			range_table_list[16 + i] = &range_0_20ma;
 		}
 	} else {
 		s->range_table = &range_bipolar10;
drivers/staging/comedi/drivers/pcl726.c +4 -4
index 256850c..6eb58a0 100644
@@ -79,7 +79,7 @@ static const struct comedi_lrange *const rangelist_726[] = {
 	&range_unipolar10,
 	&range_bipolar5,
 	&range_bipolar10,
-	&range_4_20mA,
+	&range_4_20ma,
 	&range_unknown
 };
 

@@ -87,7 +87,7 @@ static const struct comedi_lrange *const rangelist_727[] = {
 	&range_unipolar5,
 	&range_unipolar10,
 	&range_bipolar5,
-	&range_4_20mA
+	&range_4_20ma
 };
 
 static const struct comedi_lrange *const rangelist_728[] = {

@@ -95,8 +95,8 @@ static const struct comedi_lrange *const rangelist_728[] = {
 	&range_unipolar10,
 	&range_bipolar5,
 	&range_bipolar10,
-	&range_4_20mA,
-	&range_0_20mA
+	&range_4_20ma,
+	&range_0_20ma
 };
 
 struct pcl726_board {
Signature · 1 line
2.9.3
maintainer
#1 lore raw
Quoted 1 line · sumit negi

Fixed a camel style issue.

Really? Look at what you changed:

drivers/staging/comedi/comedidev.h extern const struct comedi_lrange range_bipolar2_5; · line 598

Quoted 6 lines
drivers/staging/comedi/comedidev.h +3 -3
-extern const struct comedi_lrange range_0_20mA;
-extern const struct comedi_lrange range_4_20mA;
-extern const struct comedi_lrange range_0_32mA;
+extern const struct comedi_lrange range_0_20ma;
+extern const struct comedi_lrange range_4_20ma;
+extern const struct comedi_lrange range_0_32ma;

mA means something, correct? Why did you change that?

checkpatch is a _hint_, you still always have to use your brain. Don't blindly make changes that make no sense, like this one :(

sorry,

greg k-h