gpio: Remove impossible checks on container_of() result
PATCH 1/1 gpio: Remove impossible checks on container_of() result
container_of() does pointer math on the pointer that's passed in. If it were to return a NULL pointer the value passed in would need to be perfectly offset from 0 to make that so. Remove these checks because they don't make sense.
Signed-off-by Stephen Boyd <[email protected]>
--- drivers/gpio/gpiolib.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/gpiolib.c +1 -3
@@ -982,7 +982,7 @@ static int gpio_chrdev_open(struct inode *inode, struct file *filp) struct gpio_device, chrdev);/* Fail on open if the backing gpiochip is gone */ -if (!gdev || !gdev->chip) +if (!gdev->chip)return -ENODEV ;get_device (&gdev->dev); filp->private_data = gdev;
@@ -1001,8 +1001,6 @@ static int gpio_chrdev_release(struct inode *inode, struct file *filp)struct gpio_device *gdev =container_of (inode->i_cdev, struct gpio_device, chrdev); -if (!gdev) -return -ENODEV ;put_device (&gdev->dev);return 0 ; }
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 6 lines · Stephen Boyd
container_of()does pointer math on the pointer that's passed in. If it were to return a NULL pointer the value passed in would need to be perfectly offset from 0 to make that so. Remove these checks because they don't make sense.Signed-off-by Stephen Boyd <[email protected]>
Good point.
Patch applied.
Yours,
Linus Walleij