i40iw: fix some indenting in i40iw_sc_vsi_init()

PATCH Superseded Dan Carpenter 4 participants 7 messages Jan 7, 2017 – Jan 24, 2017 3 messages not in the archive

Subsystems (2)

Kernel janitors InfiniBand

lore

Share & tools

lore

Dan Carpenter

author

2017-01-07 06:30 UTC #0 lore raw

PATCH 1/1 i40iw: fix some indenting in i40iw_sc_vsi_init()

The debug printk was indented more than it should have been and we can remove an unnecessary line break.

Signed-off-by Dan Carpenter <[email protected]>

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +3 -2

index 98923a8cf86d..b9dc2c540946 100644
@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
 	i40iw_fill_qos_list(info->params->qs_handle_list);
 
 	for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
-		vsi->qos[i].qs_handle -			info->params->qs_handle_list[i];
-			i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+		vsi->qos[i].qs_handle =	info->params->qs_handle_list[i];
+		i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+			    vsi->qos[i].qs_handle);
 		spin_lock_init(&vsi->qos[i].lock);
 		INIT_LIST_HEAD(&vsi->qos[i].qplist);
 	}

A message that is not in the archive (sent off-list or not yet received): [email protected]

Yuval Shaia

Reviewed-by

2017-01-07 17:34 UTC #2 lore raw

Quoted 10 lines · Dan Carpenter

The debug printk was indented more than it should have been and we can remove an unnecessary line break.
Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_ctrl.c +0 -0
index 98923a8cf86d..b9dc2c540946 100644

drivers/infiniband/hw/i40iw/i40iw_ctrl.c void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf · line 4503

Quoted 8 lines

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +3 -2

@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
 	i40iw_fill_qos_list(info->params->qs_handle_list);
 
 	for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
-		vsi->qos[i].qs_handle > -			info->params->qs_handle_list[i];
-			i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+		vsi->qos[i].qs_handle =	info->params->qs_handle_list[i];
+		i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+			    vsi->qos[i].qs_handle);

Nice catch :)

FWIW:

Reviewed-by Yuval Shaia <[email protected]>

Quoted 7 lines

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +0 -1
 		spin_lock_init(&vsi->qos[i].lock);
 		INIT_LIST_HEAD(&vsi->qos[i].qplist);
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Shiraz Saleem

2017-01-09 19:41 UTC #3 lore raw

In reply to a message not in the archive

Quoted 10 lines · Dan Carpenter

The debug printk was indented more than it should have been and we can remove an unnecessary line break.
Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_ctrl.c +0 -0
index 98923a8cf86d..b9dc2c540946 100644

drivers/infiniband/hw/i40iw/i40iw_ctrl.c void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf · line 4501

Quoted 6 lines

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +1 -2

@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
 	i40iw_fill_qos_list(info->params->qs_handle_list);
 
 	for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
-		vsi->qos[i].qs_handle > -			info->params->qs_handle_list[i];
-			i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+		vsi->qos[i].qs_handle =	info->params->qs_handle_list[i];

It appears there is a tab char after the =. Rather than a space.

Quoted 5 lines

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +2 -0

+		i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+			    vsi->qos[i].qs_handle);
 		spin_lock_init(&vsi->qos[i].lock);
 		INIT_LIST_HEAD(&vsi->qos[i].qplist);
 	}

A message that is not in the archive (sent off-list or not yet received): 20170109194127.GA42156-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/[email protected]

Dan Carpenter

author

2017-01-09 20:12 UTC #5 lore raw

PATCH v2 1/1 i40iw: fix some indenting in i40iw_sc_vsi_init()

The debug printk was indented more than it should have been and we can remove an unnecessary line break.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: I accidentally had a tab instead of a space.

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +3 -2

index 98923a8cf86d..b9dc2c540946 100644
@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
 	i40iw_fill_qos_list(info->params->qs_handle_list);
 
 	for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
-		vsi->qos[i].qs_handle -			info->params->qs_handle_list[i];
-			i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+		vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
+		i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+			    vsi->qos[i].qs_handle);
 		spin_lock_init(&vsi->qos[i].lock);
 		INIT_LIST_HEAD(&vsi->qos[i].qplist);
 	}

Shiraz Saleem

Acked-by on v2 1/1

2017-01-09 20:31 UTC #6 lore raw

Quoted 6 lines · Dan Carpenter

The debug printk was indented more than it should have been and we can remove an unnecessary line break.
Signed-off-by Dan Carpenter <[email protected]>
---
v2: I accidentally had a tab instead of a space.

Thank you for the patch Dan.

Acked-by Shiraz Saleem <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20170109203112.GA42952-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/[email protected]

Doug Ledford

Applied

2017-01-24 21:29 UTC #8 lore raw

Quoted 5 lines · Shiraz Saleem

Quoted 4 lines · Dan Carpenter
The debug printk was indented more than it should have been and we can remove an unnecessary line break.

Quoted 7 lines

Quoted 3 lines
Signed-off-by Dan Carpenter <[email protected]>
---
v2: I accidentally had a tab instead of a space.
Thank you for the patch Dan.
Acked-by Shiraz Saleem <[email protected]>

Applied v2 of the patch, thanks.

Signature · 4 lines

Doug Ledford <[email protected]>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Yuval Shaia

Reviewed-by on v2 1/1

2017-01-09 20:40 UTC #9 lore raw

In reply to Dan Carpenter

Quoted 6 lines · Dan Carpenter

The debug printk was indented more than it should have been and we can remove an unnecessary line break.
Signed-off-by Dan Carpenter <[email protected]>
---
v2: I accidentally had a tab instead of a space.

Also for this one:

Reviewed-by Yuval Shaia <[email protected]>

Quoted 21 lines

drivers/infiniband/hw/i40iw/i40iw_ctrl.c +3 -3

index 98923a8cf86d..b9dc2c540946 100644
@@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf
 	i40iw_fill_qos_list(info->params->qs_handle_list);
 
 	for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) {
-		vsi->qos[i].qs_handle > -			info->params->qs_handle_list[i];
-			i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle);
+		vsi->qos[i].qs_handle = info->params->qs_handle_list[i];
+		i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i,
+			    vsi->qos[i].qs_handle);
 		spin_lock_init(&vsi->qos[i].lock);
 		INIT_LIST_HEAD(&vsi->qos[i].qplist);
 	}
--

To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html