DP compliance failure due to dithering for 18bpp video pattern
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
Some of the approaches that can solve this problem are:
1. Add a new method in intel_dp.c to request the compliance test state. Call this new method in intel_display.c to not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.
2. Move the dithering enable to compute_config methods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.
3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
Regards
Manasi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.
Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's PIPE_MISC for BDW+ and PIPE_CONF for the rest. So I'm wondering about doing...
4. Disable dithering at intel_dp_sink_crc_start() and enable it again (according to config->dither) at intel_dp_sink_crc_stop(). It's similar to the hsw_disable_ips() and hsw_enable_ips() calls, but would have to cover more platforms.
Ville, thoughts on changing dithering on the fly?
BR,
Jani.
Quoted 9 lines
Regards
Manasi_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...
Quoted 6 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 39 lines · Ville Syrjälä
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...Quoted 6 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.Ville, thoughts on changing dithering on the fly?
Quoted 7 lines
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.
I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.
intel_dp_sink_crc_start() gets called only through the debugfs interface. If we disable dithering here, DPR 120 which is calculating the CRC of the pixels on the rendered video pattern would already have dithering enabled on it. So how will this solve our issue of CRC failures in case of 18bpc test?
Manasi
Quoted 10 lines
Quoted 9 lines
Quoted 1 line
Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.
Quoted 8 lines
I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 34 lines · Manasi Navare
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...
Quoted 7 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.
intel_dp_sink_crc_start()gets called only through the debugfs interface.
Do you really use this sink crc for the compliance tests?
Or are you talking about some other CRC level check like in the compliance box?
Quoted 29 lines
If we disable dithering here, DPR 120 which is calculating the CRC of the pixels on the rendered video pattern would already have dithering enabled on it. So how will this solve our issue of CRC failures in case of 18bpc test?
Manasi
Quoted 10 lines
Quoted 9 lines
Quoted 1 line
Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.Quoted 8 lines
I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.--
Jani Nikula, Intel Open Source Technology Center_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 42 lines · Rodrigo Vivi
Quoted 40 lines · Manasi Navare
Quoted 38 lines · Jani Nikula
Quoted 37 lines · Ville Syrjälä
Quoted 36 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.
Quoted 5 lines
Quoted 1 line
intel_dp_sink_crc_start()gets called only through the debugfs interface.Do you really use this sink crc for the compliance tests?
Or are you talking about some other CRC level check like in the compliance box?
Exactly, DPR 120 does a CRC check on the pixel values during the 18bpp video pattern tests. So we need to disable dithering before that modeset or during intel_modeset_pipe_config() where it sets pipe_config->dither to true.
So I am not sure I understand how disabling the dithering at intel_dp_sink_crc_start() would help.
Manasi
Quoted 23 lines
Quoted 23 lines
If we disable dithering here, DPR 120 which is calculating the CRC of the pixels on the rendered video pattern would already have dithering enabled on it. So how will this solve our issue of CRC failures in case of 18bpc test?
Manasi
Quoted 16 lines
Quoted 9 lines
Quoted 1 line
Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.
Quoted 12 lines
Quoted 6 lines
Quoted 2 lines
--
Jani Nikula, Intel Open Source Technology Center_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 45 lines · Manasi Navare
Quoted 44 lines · Rodrigo Vivi
Quoted 41 lines · Manasi Navare
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.
intel_dp_sink_crc_start()gets called only through the debugfs interface.
Quoted 8 lines
Quoted 3 lines
Do you really use this sink crc for the compliance tests?
Or are you talking about some other CRC level check like in the compliance box?Exactly, DPR 120 does a CRC check on the pixel values during the 18bpp video pattern tests. So we need to disable dithering before that modeset or during
intel_modeset_pipe_config()where it setspipe_config->ditherto true.
So I am not sure I understand how disabling the dithering atintel_dp_sink_crc_start()would help.
Oh. I thought the test involved reading the DPCD for the CRC. I didn't realize the test sink not only calculates the CRC for the source to read from DPCD, but also makes a point of checking it.
If so, we do need to disable dithering at modeset.
Again, this is not a test failure according to the CTS (there's a mention of a visual inspection) but automation FTW.
BR,
Jani.
Quoted 37 lines
Manasi
Quoted 35 lines
Quoted 29 lines
If we disable dithering here, DPR 120 which is calculating the CRC of the pixels on the rendered video pattern would already have dithering enabled on it. So how will this solve our issue of CRC failures in case of 18bpc test?
Manasi
Quoted 10 lines
Quoted 9 lines
Quoted 1 line
Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.Quoted 8 lines
I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.--
Jani Nikula, Intel Open Source Technology Center_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 59 lines · Jani Nikula
Quoted 45 lines · Manasi Navare
Quoted 44 lines · Rodrigo Vivi
Quoted 41 lines · Manasi Navare
Quoted 33 lines · Jani Nikula
Quoted 32 lines · Ville Syrjälä
Quoted 31 lines · Jani Nikula
Quoted 6 lines · Manasi Navare
Hi All,
We are seeing CRC check failures in some of the 18bpp video pattern DP Compliance tests causing the tests to fail. On further investigation, it is rootcaused to dithering that the i915 driver enables in case of 18bpp pipe configuration that messes up the CRC and causes the test to fail.
The CTS spec actually accounts for CRC failures caused by dithering and color space conversions. See section 3.2.1. However, it would be preferrable to be able to automate this.
Quoted 6 lines
Some of the approaches that can solve this problem are:
1. Add a new method inintel_dp.cto request the compliance test state. Call this new method inintel_display.cto not enable dithering during a compliance test. Issue with this is it makes the general portion of the driver compliance aware.Quoted 8 lines
2. Move the dithering enable to
compute_configmethods in all encoder source files. Issue: Lot of duplicate code and DP is the only encoder that uses 18bpc.3. Disable dithering at all times in the driver. However this can cause image quality issue with 8bpc plane and 6 bit pipe.
Any suggestions on which approach can be implemented in order to pass compliance?
I can't find any mention in the specs that we couldn't enable/disable dithering on the fly. It's
PIPE_MISCfor BDW+ andPIPE_CONFfor the rest. So I'm wondering about doing...Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
4. Disable dithering at
intel_dp_sink_crc_start()and enable it again (according toconfig->dither) atintel_dp_sink_crc_stop(). It's similar to thehsw_disable_ips()andhsw_enable_ips()calls, but would have to cover more platforms.
intel_dp_sink_crc_start()gets called only through the debugfs interface.Quoted 8 lines
Quoted 3 lines
Do you really use this sink crc for the compliance tests?
Or are you talking about some other CRC level check like in the compliance box?Exactly, DPR 120 does a CRC check on the pixel values during the 18bpp video pattern tests. So we need to disable dithering before that modeset or during
intel_modeset_pipe_config()where it setspipe_config->ditherto true.
So I am not sure I understand how disabling the dithering atintel_dp_sink_crc_start()would help.Oh. I thought the test involved reading the DPCD for the CRC. I didn't realize the test sink not only calculates the CRC for the source to read from DPCD, but also makes a point of checking it.
Quoted 39 lines
If so, we do need to disable dithering at modeset.
Again, this is not a test failure according to the CTS (there's a mention of a visual inspection) but automation FTW.
BR,
Jani.Quoted 30 lines
Manasi
Quoted 28 lines
Quoted 28 lines
If we disable dithering here, DPR 120 which is calculating the CRC of the pixels on the rendered video pattern would already have dithering enabled on it. So how will this solve our issue of CRC failures in case of 18bpc test?
Manasi
Quoted 10 lines
Quoted 9 lines
Quoted 1 line
Ville, thoughts on changing dithering on the fly?
Should be fine I think.
BTW see
https://lists.freedesktop.org/archives/intel-gfx/2016-December/115186.html
if you intend to add more crc workaround type of things. There I'm changing the IPS w/a to force a full modeset because it was the easiest way to do things, and the current thing is just broken.Quoted 8 lines
I think forcing a modeset for sink crc would be rather annoying.
BR,
Jani.--
Jani Nikula, Intel Open Source Technology Center_______________________________________________
Intel-gfx mailing list
[email protected]
Jani/Ville,
So if I were to use the same method as HSW IPS, then I would add a field force_dither_disable to pipe_config and then set this to true in compute_config if it is compliance test request for 18bpp. Does this sound like a good approach? What I am confused about is do I need to force a full modeset for this force_dither_disable to actually disable pipe's dither or just setting that at compute_config() is enough?
Manasi
Quoted 10 lines
Quoted 7 lines
Quoted 7 lines
Signature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.brSignature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx