arm64: add missing printk newlines

PATCH New Mark Rutland 2 participants 2 messages Jan 9, 2017 – Jan 10, 2017 arm64

Share & tools

Mark Rutland

author reviewer

2017-01-09 14:13 UTC #0 lore raw

PATCH 1/1 arm64: add missing printk newlines

A few printk calls in arm64 omit a trailing newline, even though there is no subsequent KERN_CONT printk associated with them, and we actually want a newline.

This can result in unrelated lines being appended, rather than appearing on a new line. Additionally, timestamp prefixes may appear in-line. This makes the logs harder to read than necessary.

Avoid this by adding a trailing newline.

These were found with a shortlist generated by:

$ git grep 'pr\(intk\|_.*\)(.*)' -- arch/arm64 | grep -v pr_fmt | grep -v '\\n"'

Signed-off-by Mark Rutland <[email protected]>

CC James Morse <[email protected]>

Cc Catalin Marinas <[email protected]>

Cc Will Deacon <[email protected]>

---
 arch/arm64/kernel/armv8_deprecated.c | 2 +-
 arch/arm64/kernel/hibernate.c        | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

arch/arm64/kernel/armv8_deprecated.c +1 -1

index ecf9298..86032a0 100644
@@ -636,7 +636,7 @@ static int __init armv8_deprecated_init(void)
 		if(system_supports_mixed_endian_el0())
 			register_insn_emulation(&setend_ops);
 		else
-			pr_info("setend instruction emulation is not supported on the system");
+			pr_info("setend instruction emulation is not supported on this system\n");
 	}
 
 	cpuhp_setup_state_nocalls(CPUHP_AP_ARM64_ISNDEP_STARTING,

arch/arm64/kernel/hibernate.c +3 -3

index fe301cb..1b918aae 100644
@@ -472,7 +472,7 @@ int swsusp_arch_resume(void)
 	 */
 	tmp_pg_dir = (pgd_t *)get_safe_page(GFP_ATOMIC);
 	if (!tmp_pg_dir) {
-		pr_err("Failed to allocate memory for temporary page tables.");
+		pr_err("Failed to allocate memory for temporary page tables.\n");
 		rc = -ENOMEM;
 		goto out;
 	}

@@ -492,7 +492,7 @@ int swsusp_arch_resume(void)
 	 */
 	zero_page = (void *)get_safe_page(GFP_ATOMIC);
 	if (!zero_page) {
-		pr_err("Failed to allocate zero page.");
+		pr_err("Failed to allocate zero page.\n");
 		rc = -ENOMEM;
 		goto out;
 	}

@@ -512,7 +512,7 @@ int swsusp_arch_resume(void)
 				   &phys_hibernate_exit,
 				   (void *)get_safe_page, GFP_ATOMIC);
 	if (rc) {
-		pr_err("Failed to create safe executable page for hibernate_exit code.");
+		pr_err("Failed to create safe executable page for hibernate_exit code.\n");
 		goto out;
 	}

Signature · 1 line

1.9.1

Will Deacon

2017-01-10 12:36 UTC #1 lore raw

PATCH 1/1 arm64: add missing printk newlines

Quoted 14 lines · Mark Rutland

A few printk calls in arm64 omit a trailing newline, even though there is no subsequent KERN_CONT printk associated with them, and we actually want a newline.
This can result in unrelated lines being appended, rather than appearing on a new line. Additionally, timestamp prefixes may appear in-line. This makes the logs harder to read than necessary.
Avoid this by adding a trailing newline.
These were found with a shortlist generated by:
$ git grep 'pr$intk\|_.*$(.*)' -- arch/arm64 | grep -v pr_fmt | grep -v '\\n"'

Quoted 8 lines

Signed-off-by Mark Rutland <[email protected]>
CC James Morse <[email protected]>
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
---
 arch/arm64/kernel/armv8_deprecated.c | 2 +-
 arch/arm64/kernel/hibernate.c        | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

Applied for 4.11.

Will