Skip to contentSkip to conversation

ASoC: tm2_wm5110: include gpio/consumer.h

PATCH In review Arnd Bergmann 2 participants 4 messages Jan 10, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tm2_wm5110: include gpio/consumer.h

gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that is not always included implicitly, so we have to include both gpio.h and gpio/consumer.h here:

sound/soc/samsung/tm2_wm5110.c: In function 'tm2_mic_bias':
sound/soc/samsung/tm2_wm5110.c:220:3: error: implicit declaration of function 'gpiod_set_value_cansleep';did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]

Fixes 1bfbc260a5b4 ("ASoC: samsung: Add machine driver for Exynos5433 based TM2 board")
---
 sound/soc/samsung/tm2_wm5110.c | 1 +
 1 file changed, 1 insertion(+)
sound/soc/samsung/tm2_wm5110.c +1 -0
index 5cdf7d19b87f..24cc9d63ce87 100644
@@ -12,6 +12,7 @@
 
 #include <linux/clk.h>
 #include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <sound/pcm_params.h>
Signature · 1 line
2.9.0
maintainer
#1 lore raw
Quoted 3 lines · Arnd Bergmann

gpiod_set_value_cansleep is declared in linux/gpio/consumer.h, but that is not always included implicitly, so we have to include both gpio.h and gpio/consumer.h here:

This doesn't apply against current code, it looks like someone already made the same change.

#2 lore raw
Quoted 2 lines · Mark Brown

This doesn't apply against current code, it looks like someone already made the same change.Ok, I was sending out m

y final set of patches that I found build-testing v4.10-rc, which still needs the change,
and have moved on to linux-next testing now.

In case you have queued up that change for v4.11 but not also v4.10, maybe move it into the fixes branch.

Arnd

maintainer
#3 lore raw
Quoted 2 lines · Arnd Bergmann

In case you have queued up that change for v4.11 but not also v4.10, maybe move it into the fixes branch.

There's a merge in there as well.