at91: video: Support driver-model for the HLCD driver
Subsystems (2)
PATCH RESEND v2 1/1 at91: video: Support driver-model for the HLCD driver
Add driver-model support to this driver.
---
Changes in v2:
- Due to the peripheral clock driver improvement, remove the unneccessary clock calling.
drivers/video/Kconfig | 7 + drivers/video/Makefile | 2 +- drivers/video/atmel_hlcdfb.c | 314 ++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 319 insertions(+), 4 deletions(-)
drivers/video/Kconfig +7 -0
@@ -362,6 +362,13 @@ config DISPLAY The devices provide a simple interface to start up the display, read display information and enable it. +config VIDEO_ATMEL_HLCD + bool "Enable ATMEL video support using HLCDC" + depends on DM_VIDEO + help + Only the LCD is supported in U-Boot. This option enables this support + which can be used on devices which have an LCD display connected. + config VIDEO_BROADWELL_IGD bool "Enable Intel Broadwell integrated graphics device" depends on X86
drivers/video/Makefile +1 -1
@@ -22,7 +22,6 @@ endif obj-$(CONFIG_VIDEO_BROADWELL_IGD) += broadwell_igd.o obj-$(CONFIG_ATI_RADEON_FB) += ati_radeon_fb.o videomodes.o -obj-$(CONFIG_ATMEL_HLCD) += atmel_hlcdfb.o obj-$(CONFIG_ATMEL_LCD) += atmel_lcdfb.o obj-$(CONFIG_CFB_CONSOLE) += cfb_console.o obj-$(CONFIG_FSL_DIU_FB) += fsl_diu_fb.o videomodes.o
@@ -35,6 +34,7 @@ obj-$(CONFIG_S6E8AX0) += s6e8ax0.o obj-$(CONFIG_S6E63D6) += s6e63d6.o obj-$(CONFIG_LD9040) += ld9040.o obj-$(CONFIG_SED156X) += sed156x.o +obj-$(CONFIG_VIDEO_ATMEL_HLCD) += atmel_hlcdfb.o obj-$(CONFIG_VIDEO_BCM2835) += bcm2835.o obj-$(CONFIG_VIDEO_COREBOOT) += coreboot_fb.o obj-$(CONFIG_VIDEO_CT69000) += ct69000.o videomodes.o
drivers/video/atmel_hlcdfb.c +311 -3
336 lines not on this page · raw message
Signature · 1 line
2.11.0
PATCH RESEND v2 1/1 at91: video: Support driver-model for the HLCD driver
Hi,
Quoted 5 lines · On Wed, 11 Jan 2017 10:36:48 +0800 Songjun Wu songjun.wu at microchip.com wrote:
Add driver-model support to this driver.
Signed-off-by Songjun Wu <[email protected]>---
Quoted 8 lines
Changes in v2:
- Due to the peripheral clock driver improvement, remove the unneccessary clock calling.drivers/video/Kconfig | 7 + drivers/video/Makefile | 2 +- drivers/video/atmel_hlcdfb.c | 314 ++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 319 insertions(+), 4 deletions(-)
there are many issues with this patch. First it needs re-basing to apply on current master branch. The U-Boot image linking fails with this patch applied. You change CONFIG_ATMEL_HLCD to CONFIG_VIDEO_ATMEL_HLCD, but no board config files in include/config are updated accordingly.
If I update for this option e.g. in at91sam9x5ek.h, the driver doesn't build. The building also doesn't work when I enable DM support. Please fix all these issues before resubmitting. Thanks.
--
Anatolij
Wu
PATCH RESEND v2 1/1 at91: video: Support driver-model for the HLCD driver
Hi Anatolij,
Thank you very much for you comments.
I will make a new patch to fix these issues.
Quoted 31 lines · Anatolij Gustschin
Hi,
Quoted 5 lines · On Wed, 11 Jan 2017 10:36:48 +0800 Songjun Wu songjun.wu at microchip.com wrote:
Add driver-model support to this driver.
Signed-off-by Songjun Wu <[email protected]>---
Quoted 8 lines
Changes in v2:
- Due to the peripheral clock driver improvement, remove the unneccessary clock calling.drivers/video/Kconfig | 7 + drivers/video/Makefile | 2 +- drivers/video/atmel_hlcdfb.c | 314 ++++++++++++++++++++++++++++++++++++++++++- 3 files changed, 319 insertions(+), 4 deletions(-)there are many issues with this patch. First it needs re-basing to apply on current master branch. The U-Boot image linking fails with this patch applied. You change
CONFIG_ATMEL_HLCDtoCONFIG_VIDEO_ATMEL_HLCD, but no board config files ininclude/configare updated accordingly.If I update for this option e.g. in
at91sam9x5ek.h, the driver doesn't build. The building also doesn't work when I enable DM support. Please fix all these issues before resubmitting. Thanks.--
Anatolij