Skip to contentSkip to conversation

rtc: add STM32 RTC driver

rtc-linux Dan Carpenter 2 participants 5 messages Jan 16, 2017 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

Hello Amelie Delaunay,

The patch 4e64350f42e2: "rtc: add STM32 RTC driver" from Jan 11, 2017, leads to the following static checker warning:

	drivers/rtc/rtc-stm32.c:514 stm32_rtc_init()
	warn: always true condition '(pred_a >= 0) => (0-u32max >= 0)'

drivers/rtc/rtc-stm32.c
499 static int stm32_rtc_init(struct platform_device *pdev,
500 struct stm32_rtc *rtc)
501 {

   502          unsigned int prer, pred_a, pred_s, pred_a_max, pred_s_max, cr;
   503          unsigned int rate;
   504          int ret = 0;
   505  
   506          rate = clk_get_rate(rtc->ck_rtc);
   507  
   508          /* Find prediv_a and prediv_s to obtain the 1Hz calendar clock */
   509          pred_a_max = STM32_RTC_PRER_PRED_A >> STM32_RTC_PRER_PRED_A_SHIFT;
   510          pred_s_max = STM32_RTC_PRER_PRED_S >> STM32_RTC_PRER_PRED_S_SHIFT;
   511  
   512          for (pred_a = pred_a_max; pred_a >= 0; pred_a--) {
                                          ^^^^^^^^^^^

We should probably make pred_a, pred_s, pred_a_max and pred_s_max signed.

   513                  pred_s = (rate / (pred_a + 1)) - 1;
   514  
   515                  if (((pred_s + 1) * (pred_a + 1)) == rate)
   516                          break;
   517          }
   518  

regards,
dan carpenter

Signature · 8 lines
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
#1 lore raw

Hi Dan,

Thanks for reporting this issue.
I've already send a fix ("rtc: stm32: fix comparison warnings"): https://patchwork.kernel.org/patch/9518411/.

Regards,
Amelie

Quoted 44 lines

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: lundi 16 janvier 2017 13:14
To: Amelie DELAUNAY <[email protected]>
Cc: [email protected]
Subject: [bug report] rtc: add STM32 RTC driver

Hello Amelie Delaunay,

The patch 4e64350f42e2: "rtc: add STM32 RTC driver" from Jan 11, 2017, leads to the following static checker warning:

	drivers/rtc/rtc-stm32.c:514 stm32_rtc_init()
	warn: always true condition '(pred_a >= 0) => (0-u32max >= 0)'

drivers/rtc/rtc-stm32.c
499 static int stm32_rtc_init(struct platform_device *pdev,
500 struct stm32_rtc *rtc)

   501  {
   502          unsigned int prer, pred_a, pred_s, pred_a_max, pred_s_max, cr;
   503          unsigned int rate;
   504          int ret = 0;
   505
   506          rate = clk_get_rate(rtc->ck_rtc);
   507
   508          /* Find prediv_a and prediv_s to obtain the 1Hz calendar clock */
   509          pred_a_max = STM32_RTC_PRER_PRED_A >>
STM32_RTC_PRER_PRED_A_SHIFT;
   510          pred_s_max = STM32_RTC_PRER_PRED_S >>
STM32_RTC_PRER_PRED_S_SHIFT;
   511
   512          for (pred_a = pred_a_max; pred_a >= 0; pred_a--) {
                                          ^^^^^^^^^^^ We should probably make pred_a,

pred_s, pred_a_max and pred_s_max signed.

   513                  pred_s = (rate / (pred_a + 1)) - 1;
   514
   515                  if (((pred_s + 1) * (pred_a + 1)) == rate)
   516                          break;
   517          }
   518

regards,
dan carpenter

Signature · 8 lines
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
#2 lore raw
In reply to Dan Carpenter

Oh. That still won't fix this:

drivers/rtc/rtc-stm32.c
519 /*

   520           * Can't find a 1Hz, so give priority to RTC power consumption
   521           * by choosing the higher possible value for prediv_a
   522           */

523 if ((pred_s > pred_s_max) || (pred_a > pred_a_max)) {
524 pred_a = pred_a_max;
525 pred_s = (rate / (pred_a + 1)) - 1;
526
527 dev_warn(&pdev->dev, "ck_rtc is %s\n",
528 (rate - ((pred_a + 1) * (pred_s + 1)) < 0) ?

This is type promoted to unsigned int < 0.

529 "fast" : "slow");
530 }

regards,
dan carpenter

Signature · 8 lines
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
#3 lore raw

I've changed the comparison:
@@ -525,7 +525,7 @@ static int stm32_rtc_init(struct platform_device *pdev,
pred_s = (rate / (pred_a + 1)) - 1;

dev_warn(&pdev->dev, "ck_rtc is %s\n",
- (rate - ((pred_a + 1) * (pred_s + 1)) < 0) ?
+ (rate < ((pred_a + 1) * (pred_s + 1))) ?
"fast" : "slow");
}
Now, rate (unsigned) is compared to ((pred_a + 1) * (pred_s + 1)) (unsigned), so no further "unsigned expression < 0 is always false".

Regards,
Amelie

Quoted 22 lines · Dan Carpenter

Oh. That still won't fix this:

drivers/rtc/rtc-stm32.c
519 /*

   520           * Can't find a 1Hz, so give priority to RTC power consumption
   521           * by choosing the higher possible value for prediv_a
   522           */
   523          if ((pred_s > pred_s_max) || (pred_a > pred_a_max)) {
   524                  pred_a = pred_a_max;
   525                  pred_s = (rate / (pred_a + 1)) - 1;
   526
   527                  dev_warn(&pdev->dev, "ck_rtc is %s\n",
   528                           (rate - ((pred_a + 1) * (pred_s + 1)) < 0) ?

This is type promoted to unsigned int < 0.

   529                           "fast" : "slow");
   530          }

regards,
dan carpenter

Signature · 7 lines
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.
#4 lore raw

Yeah. I just read your patch now. Thanks.

regards,
dan carpenter

Signature · 8 lines
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.