x86/ioapic: Return suitable error code in mp_map_gsi_to_irq()

PATCH Superseded Andy Shevchenko 1 participant 1 message Jan 17, 2017 x86

lore

Share & tools

lore

Andy Shevchenko

author

2017-01-17 12:42 UTC #0 lore raw

PATCH v2 1/1 x86/ioapic: Return suitable error code in mp_map_gsi_to_irq()

mp_map_gsi_to_irq() in some cases might return legacy -1, which would be wrongly interpreted as -EPERM.

Correct those cases to return proper error code.

Signed-off-by Andy Shevchenko <[email protected]>

---
- return -ENODEV in both cases (Thomas)

 arch/x86/kernel/apic/io_apic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/x86/kernel/apic/io_apic.c +2 -2

index 945e512a112a..f62c38d325da 100644
@@ -1107,12 +1107,12 @@ int mp_map_gsi_to_irq(u32 gsi, unsigned int flags, struct irq_alloc_info *info)
 
 	ioapic = mp_find_ioapic(gsi);
 	if (ioapic < 0)
-		return -1;
+		return -ENODEV;
 
 	pin = mp_find_ioapic_pin(ioapic, gsi);
 	idx = find_irq_entry(ioapic, pin, mp_INT);
 	if ((flags & IOAPIC_MAP_CHECK) && idx < 0)
-		return -1;
+		return -ENODEV;
 
 	return mp_map_pin_to_irq(gsi, idx, ioapic, pin, flags, info);
 }

Signature · 1 line

2.11.0