Skip to contentSkip to conversation

ACPI/IORT: fix an error code

PATCH In review Dan Carpenter 3 participants 3 messages Jan 17, 2017 – Jan 18, 2017

Subsystems (3)
Kernel janitors ACPI ACPI arm64
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 ACPI/IORT: fix an error code

We accidentally return success if platform_device_alloc() fails.

Fixes 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation")
Signed-off-by Dan Carpenter <[email protected]>
drivers/acpi/arm64/iort.c +1 -1
index e0d2e6e..655407a 100644
@@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
 
 	pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
 	if (!pdev)
-		return PTR_ERR(pdev);
+		return -ENOMEM;
 
 	count = ops->iommu_count_resources(node);
Acked-by on v1 1/1
#1 lore raw

drivers/acpi/arm64/iort.c

Quoted 9 lines · Dan Carpenter

We accidentally return success if platform_device_alloc() fails.

Fixes 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation")
Signed-off-by Dan Carpenter <[email protected]>
drivers/acpi/arm64/iort.c +0 -0
index e0d2e6e..655407a 100644
Acked-by Lorenzo Pieralisi <[email protected]>
Quoted 9 lines
drivers/acpi/arm64/iort.c +1 -1
@@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
 
 	pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
 	if (!pdev)
-		return PTR_ERR(pdev);
+		return -ENOMEM;
 
 	count = ops->iommu_count_resources(node);
Acked-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 10 lines · Dan Carpenter

We accidentally return success if platform_device_alloc() fails.

Fixes 846f0e9e74a0 ("ACPI/IORT: Add support for ARM SMMU platform devices creation")
Signed-off-by Dan Carpenter <[email protected]>
drivers/acpi/arm64/iort.c +0 -0
index e0d2e6e..655407a 100644

drivers/acpi/arm64/iort.c static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node) · line 833

Quoted 7 lines
drivers/acpi/arm64/iort.c +1 -1
@@ -828,7 +828,7 @@ static int __init iort_add_smmu_platform_device(struct acpi_iort_node *node)
 
 	pdev = platform_device_alloc(ops->name, PLATFORM_DEVID_AUTO);
 	if (!pdev)
-		return PTR_ERR(pdev);
+		return -ENOMEM;
 
 	count = ops->iommu_count_resources(node);
Acked-by Hanjun Guo <[email protected]>

Thanks
Hanjun