dra7x: dts update for increase in QSPI SPL parttion size
cover dra7x: dts update for increase in QSPI SPL parttion size
This patch updates the SPL partition size for QSPI for dra7xx platforms.
Ravi Babu (2):
ARM: dts: dra7-evm: increase QSPI SPL partition size
ARM: dts: dra72x-evm: increase QSPI SPL partition size
arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ arch/arm/boot/dts/dra72-evm-common.dtsi | 24 ++++++------------------ 2 files changed, 12 insertions(+), 36 deletions(-)
Signature · 1 line
1.9.1
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
--- arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)
arch/arm/boot/dts/dra7-evm.dts +6 -18
@@ -681,41 +681,29 @@ */ partition at 0 { label = "QSPI.SPL"; - reg = <0x00000000 0x000010000>; + reg = <0x00000000 0x000040000>; }; partition at 1 { - label = "QSPI.SPL.backup1"; - reg = <0x00010000 0x00010000>; - }; - partition at 2 { - label = "QSPI.SPL.backup2"; - reg = <0x00020000 0x00010000>; - }; - partition at 3 { - label = "QSPI.SPL.backup3"; - reg = <0x00030000 0x00010000>; - }; - partition at 4 { label = "QSPI.u-boot"; reg = <0x00040000 0x00100000>; }; - partition at 5 { + partition at 2 { label = "QSPI.u-boot-spl-os"; reg = <0x00140000 0x00080000>; }; - partition at 6 { + partition at 3 { label = "QSPI.u-boot-env"; reg = <0x001c0000 0x00010000>; }; - partition at 7 { + partition at 4 { label = "QSPI.u-boot-env.backup1"; reg = <0x001d0000 0x0010000>; }; - partition at 8 { + partition at 5 { label = "QSPI.kernel"; reg = <0x001e0000 0x0800000>; }; - partition at 9 { + partition at 6 { label = "QSPI.file-system"; reg = <0x009e0000 0x01620000>; };
Signature · 1 line
1.9.1
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
Quoted 5 lines · Ravi Babu
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
And this will break the existing partitions potentially.. See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table".
It's best to have these left empty or as they originally were and let u-boot configure the partitions.
Regards,
Tony
Quoted 61 lines
Signed-off-by Ravi Babu <[email protected]>Signed-off-by Sekhar Nori <[email protected]>--- arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)arch/arm/boot/dts/dra7-evm.dts +6
-18@@ -681,41 +681,29 @@ */ partition at 0 { label = "QSPI.SPL"; - reg = <0x00000000 0x000010000>; + reg = <0x00000000 0x000040000>; }; partition at 1 { - label = "QSPI.SPL.backup1"; - reg = <0x00010000 0x00010000>; - }; - partition at 2 { - label = "QSPI.SPL.backup2"; - reg = <0x00020000 0x00010000>; - }; - partition at 3 { - label = "QSPI.SPL.backup3"; - reg = <0x00030000 0x00010000>; - }; - partition at 4 { label = "QSPI.u-boot"; reg = <0x00040000 0x00100000>; }; - partition at 5 { + partition at 2 { label = "QSPI.u-boot-spl-os"; reg = <0x00140000 0x00080000>; }; - partition at 6 { + partition at 3 { label = "QSPI.u-boot-env"; reg = <0x001c0000 0x00010000>; }; - partition at 7 { + partition at 4 { label = "QSPI.u-boot-env.backup1"; reg = <0x001d0000 0x0010000>; }; - partition at 8 { + partition at 5 { label = "QSPI.kernel"; reg = <0x001e0000 0x0800000>; }; - partition at 9 { + partition at 6 { label = "QSPI.file-system"; reg = <0x009e0000 0x01620000>; };Signature · 1 line
1.9.1
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
Hi Tony
Quoted 10 lines · Ravi Babu
Quoted 4 lines
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
And this will break the existing partitions potentially..
See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table".It's best to have these left empty or as they originally were and let u-boot configure the partitions.
Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform.
Quoted 51 lines
Quoted 51 lines
Signed-off-by Ravi Babu <[email protected]>Signed-off-by Sekhar Nori <[email protected]>--- arch/arm/boot/dts/dra7-evm.dts | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/dra7-evm.dtsindex 132f2be..2784241 100644arch/arm/boot/dts/dra7-evm.dts +5
-17@@ -681,41 +681,29 @@ */ partition at 0 { label = "QSPI.SPL"; - reg = <0x00000000 0x000010000>; + reg = <0x00000000 0x000040000>; }; partition at 1 { - label = "QSPI.SPL.backup1"; - reg = <0x00010000 0x00010000>; - }; - partition at 2 { - label = "QSPI.SPL.backup2"; - reg = <0x00020000 0x00010000>; - }; - partition at 3 { - label = "QSPI.SPL.backup3"; - reg = <0x00030000 0x00010000>; - }; - partition at 4 { label = "QSPI.u-boot"; reg = <0x00040000 0x00100000>; }; - partition at 5 { + partition at 2 { label = "QSPI.u-boot-spl-os"; reg = <0x00140000 0x00080000>; }; - partition at 6 { + partition at 3 { label = "QSPI.u-boot-env"; reg = <0x001c0000 0x00010000>; }; - partition at 7 { + partition at 4 { label = "QSPI.u-boot-env.backup1"; reg = <0x001d0000 0x0010000>; }; - partition at 8 { + partition at 5 { label = "QSPI.kernel";
Quoted 8 lines
arch/arm/boot/dts/dra7-evm.dts
Quoted 8 lines
arch/arm/boot/dts/dra7-evm.dts +1
-2reg = <0x001e0000 0x0800000>; }; - partition at 9 { + partition at 6 { label = "QSPI.file-system"; reg = <0x009e0000 0x01620000>; }; --
Regards
Ravi
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
Quoted 8 lines · B, Ravi
Hi Tony
Quoted 5 lines · Ravi Babu
Quoted 4 lines
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
Quoted 7 lines
Quoted 4 lines
And this will break the existing partitions potentially..
See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table".It's best to have these left empty or as they originally were and let u-boot configure the partitions.
Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform.
What about the renumbering of partitions in your patch?
Probably just best to make the partition information empty in the kernel as discussed.
Regards,
Tony
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
Hi Tony,
Quoted 12 lines · Tony Lindgren
Quoted 11 lines · B, Ravi
Hi Tony
Quoted 8 lines · Ravi Babu
Quoted 4 lines
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
And this will break the existing partitions potentially..
See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table".
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
It's best to have these left empty or as they originally were and let u-boot configure the partitions.
Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform.
What about the renumbering of partitions in your patch?
Thats true, partitions will get renumbered. But mtd numbering can change depending on probe order of devices anyway. So usespace which uses hardcoded mtd partition numbers is pretty fragile already, I guess.
Quoted 3 lines
Probably just best to make the partition information empty in the kernel as discussed.
Given that existing dtbs already have the partition information, wont this be treated as a regression for someone upgrading to new kernel?
Going forward, is the preference that new boards shall not have partition information in DT?
Thanks,
Sekhar
PATCH 1/2 ARM: dts: dra7-evm: increase QSPI SPL partition size
Quoted 27 lines · Sekhar Nori
Hi Tony,
Quoted 12 lines · Tony Lindgren
Quoted 11 lines · B, Ravi
Hi Tony
Quoted 8 lines · Ravi Babu
Quoted 4 lines
The SPL size for DRA74x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA74x EVM.
QSPI partition numbering changes because of this.
And this will break the existing partitions potentially..
See what was discussed on the list few days ago in thread "[PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table".Quoted 6 lines
Quoted 4 lines
Quoted 1 line
It's best to have these left empty or as they originally were and let u-boot configure the partitions.
Agree with you. For dra7xx platform the SPL size has been increased to 256KB and hence the existing QSPI SPL partition in kernel (64K size) will break when latest mainline u-boot is used. Here only SPL partition has been changed and other partition & size is NOT changed and kept intact. I feel it will not break the existing partitions for dra7xx platform.
What about the renumbering of partitions in your patch?
Thats true, partitions will get renumbered. But mtd numbering can change depending on probe order of devices anyway. So usespace which uses hardcoded mtd partition numbers is pretty fragile already, I guess.
Quoted 1 line
Quoted 5 lines
Quoted 2 lines
Probably just best to make the partition information empty in the kernel as discussed.
Given that existing dtbs already have the partition information, wont this be treated as a regression for someone upgrading to new kernel?
Well these "flag day" type changes are not acceptable because they are impossible to coordinate. You can't assume people update their bootloader on regular basis, or update both bootloader and kernel to some specific versions.
Quoted 2 lines
Going forward, is the preference that new boards shall not have partition information in DT?
Yes or else it will have to stay as it was originally set because of these issues.
Regards,
Tony
PATCH 2/2 ARM: dts: dra72x-evm: increase QSPI SPL partition size
In reply to Ravi BabuThe SPL size for DRA72x platform has increased and is now more than 64KB. Increase QSPI SPL partition size to 256KB for DRA72x EVM.
QSPI partition numbers change because of this.
--- arch/arm/boot/dts/dra72-evm-common.dtsi | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-)
arch/arm/boot/dts/dra72-evm-common.dtsi +6 -18
@@ -439,41 +439,29 @@ */ partition at 0 { label = "QSPI.SPL"; - reg = <0x00000000 0x000010000>; + reg = <0x00000000 0x000040000>; }; partition at 1 { - label = "QSPI.SPL.backup1"; - reg = <0x00010000 0x00010000>; - }; - partition at 2 { - label = "QSPI.SPL.backup2"; - reg = <0x00020000 0x00010000>; - }; - partition at 3 { - label = "QSPI.SPL.backup3"; - reg = <0x00030000 0x00010000>; - }; - partition at 4 { label = "QSPI.u-boot"; reg = <0x00040000 0x00100000>; }; - partition at 5 { + partition at 2 { label = "QSPI.u-boot-spl-os"; reg = <0x00140000 0x00080000>; }; - partition at 6 { + partition at 3 { label = "QSPI.u-boot-env"; reg = <0x001c0000 0x00010000>; }; - partition at 7 { + partition at 4 { label = "QSPI.u-boot-env.backup1"; reg = <0x001d0000 0x0010000>; }; - partition at 8 { + partition at 5 { label = "QSPI.kernel"; reg = <0x001e0000 0x0800000>; }; - partition at 9 { + partition at 6 { label = "QSPI.file-system"; reg = <0x009e0000 0x01620000>; };
Signature · 1 line
1.9.1